50 Commits

Author	SHA1	Message	Date
Salman Ahmed	1af230c48c	Merge branch 'master' into refactor-combo-colour-retrieval	2021-07-20 10:08:25 +03:00
Dean Herbert	c18b8ca86c	Add missing ToArray() call	2021-07-07 14:08:29 +09:00
Dean Herbert	ca791c2afa	Remove unused using statement	2021-07-07 13:53:00 +09:00
Dean Herbert	35d4b12a4f	Remove single local usage of AllSources	2021-07-07 13:52:52 +09:00
Dean Herbert	eb8b14a931	Reorder methods to make more sense	2021-07-07 13:51:51 +09:00
Dean Herbert	523546d8b6	Use List to guarantee lookup order	2021-07-06 22:51:56 +09:00
Dean Herbert	d75d67577a	Fix regressed tests	2021-07-06 17:37:34 +09:00
Dean Herbert	cd4885e450	Add xmldoc and remove any question of how the intitial flow is being run	2021-07-06 17:18:45 +09:00
Dean Herbert	032c285ede	Move private downwards	2021-07-06 17:07:29 +09:00
Dean Herbert	1232925f93	Make source manipulation methods protected	2021-07-06 17:06:00 +09:00
Dean Herbert	b4240d3ca4	Simplify lookups to avoid a second dictionary fetch	2021-07-06 17:04:59 +09:00
Dean Herbert	ec1224218c	Localise source changed flow for better clarity	2021-07-06 16:57:19 +09:00
Dean Herbert	935fbe7cc6	Remove double fetch/binding of parent source	2021-07-06 16:51:29 +09:00
Dean Herbert	93ef783339	Remove BindableList usage	2021-07-06 16:40:23 +09:00
Dean Herbert	0ad189e357	Expose skin sources via ISkinSource and revert to consuming based on hierarchy	2021-06-22 16:19:55 +09:00
Salman Ahmed	ebe0d43790	Add ability to disallow falling back to parent skins	2021-06-22 02:51:17 +03:00
Salman Ahmed	8de0d33c5a	Revert "Move collection change bind to LoadComplete" ... This reverts commit d6d87e1975. Actually that broke things due to the "disableable" instances not added early enough, revert for now.	2021-06-11 17:59:29 +03:00
Salman Ahmed	d6d87e1975	Move collection change bind to LoadComplete ... Best practice anyways	2021-06-11 17:35:33 +03:00
Salman Ahmed	f20146d446	Fix potentially adding null skin sources	2021-06-11 12:58:38 +03:00
Salman Ahmed	9e16359f18	Refactor disallowing in SkinProvidingContainer to become per source ... Fixes `FindProvider` becoming completely broken, because of no way to perform the checks on one skin source.	2021-06-11 12:29:29 +03:00
Salman Ahmed	8132852753	Add other affectable change action cases	2021-06-11 11:34:22 +03:00
Salman Ahmed	a985e3b8d3	Apply documentation settings for better readability ... Co-authored-by: Dean Herbert <pe@ppy.sh> Co-authored-by: Dan Balasescu <smoogipoo@smgi.me>	2021-06-11 11:25:07 +03:00
Salman Ahmed	2240e2c39c	Refrain from attempting to clear skin sources in disposal ... `Drawable.Dispose` is usually in an asynchronous context (async disposals stuff) and therefore this could cause a "collection was modified; enumeration opeartion may not execute" exception.	2021-06-10 17:23:16 +03:00
Salman Ahmed	5c9c424a0d	Switch state case placements for consistency ... Tickled me.	2021-06-10 13:15:18 +03:00
Salman Ahmed	59be3588eb	Change SkinSources to a bindable list for binding SourceChanged events	2021-06-10 13:07:32 +03:00
Salman Ahmed	dde84e5cbd	Merge branch 'master' into transformers-per-skin	2021-06-10 11:58:52 +03:00
Salman Ahmed	530026b675	Add simple xmldoc to ctors explaining their deal with SkinSources	2021-06-10 11:56:13 +03:00
Salman Ahmed	18edbdd135	Remove mentioning of "layer" in skin providers ... `SkinSources` sounds better.	2021-06-10 11:55:26 +03:00
Salman Ahmed	6538d44708	Make SkinProvidingContainer able to perform lookup on multiple skins ... Currently `protected` functionality for use in custom `SkinProvidingContainer`s, can be exposed to public constructors if it need to later on, but I'm not sure about doing that opposed to just nesting multiple `SkinProvidingContainer`.	2021-06-09 22:49:31 +03:00
Dean Herbert	2438c20d63	Fix SourceChanged not being correctly forwarded through LegacySkinTransformer	2021-06-09 17:56:07 +09:00
Dean Herbert	448e4e7ee5	Fix FindProvider calls on SkinProvidingContainer not considering disable flags ... Closes #13394.	2021-06-09 16:19:04 +09:00
Dean Herbert	c0305343bc	Fix FindProvider incorrectly returning LegacySkinTransformer itself	2021-06-07 23:23:44 +09:00
Dean Herbert	282c5a9177	Fix potential nullref in SkinProvidingContainer	2021-05-31 21:29:47 +09:00
Dean Herbert	88ed95e012	Add FindProvider lookup function	2021-05-31 21:29:47 +09:00
Salman Ahmed	f95744170f	Add skin config lookup for combo colours	2021-05-05 07:06:26 +03:00
Dean Herbert	00574a5288	Use ISample everywhere in Skin GetSample lookup path	2021-02-18 18:32:28 +09:00
smoogipoo	de9d075f94	Initial sample + samplechannel rework	2021-01-19 17:11:40 +09:00
Dean Herbert	94fee8c31d	Avoid doing a config lookup if initial conditional fails	2021-01-18 16:13:58 +09:00
Mysfit	0c01a3a685	Found a better solution than TValue type checking for additional beatmap colour settings. Added unit tests for Catch Beatmap Skin settings.	2021-01-14 23:30:24 -05:00
Mysfit	99e43c77c2	Simplified colour config checks in SkinProvidingContainer.cs	2021-01-14 16:53:55 -05:00
Jesse Myers	562634dfd2	Improve naming around the config lookup with fallback private method. ... Co-authored-by: Bartłomiej Dach <dach.bartlomiej@gmail.com>	2021-01-13 16:49:14 -05:00
Mysfit	8b95817f7a	Moved SkinProvidingContainer bindable fetching to common method. Replaced redundant test boolean declarations with inline values.	2021-01-13 16:05:46 -05:00
Mysfit	1248d39d7e	Reverted change to AllowConfigurationLookup and added a separate AllowColourLookup bool with config case based on lookup type in SkinProvidingContainer GetConfig call.	2021-01-13 13:07:07 -05:00
smoogipoo	9f7750e615	Add texture wrapping support to skins	2020-07-17 16:54:30 +09:00
Dean Herbert	24269c0384	Fix skins not being displayed correctly in the editor	2019-10-08 12:52:34 +09:00
Dean Herbert	bebc3309ce	Refactor skin configuration to be infinitely extensible	2019-09-03 17:57:34 +09:00
Dean Herbert	a15828ab25	Introduce the concept of SkinComponents ... Removes reliance on string lookups and better defines elements for introduction into database	2019-08-30 14:55:52 +09:00
Dean Herbert	7ea55a5cdd	Merge remote-tracking branch 'upstream/master' into add-ruleset-legacy-skin	2019-08-28 16:36:20 +09:00
Dean Herbert	7aeeb65ae7	Tidy up Player's container loading logic ... Fixes drawable ruleset being loaded before skin sources are finished, by loading them as a separate operation (to avoid children being loaded first).	2019-08-27 18:27:21 +09:00
Dean Herbert	de2c6aa23d	Rename and expand usability of SkinProvidingContainer	2019-08-26 12:21:11 +09:00