51150 Commits

This Branch

This Branch

All Branches

• Update framework
  Dean Herbert · 2022-01-25 13:50:41 +09:00
  df1297ade6
• During import if files are found to be missing, ensure they are restored

  This is one step closer to sanity in terms of physical files. As per the
  comment I have left in place, we really should be checking file sizes or
  hashes, but to keep things simple and fast I've opted to just cover the
  "missing file" scenario for now.
  
  Ran into this when testing against a foreign `client.realm` by:
  - Noticing a beatmap doesn't load
  - Deleting said beatmap
  - Downloading via beatmap overlay
  - Beatmap is restored but still doesn't work
  
  Note that I've kept the logic where this will undelete an existing
  import rather than create one from fresh, as I think that is beneficial
  to the user (ie. it will still keep any linked scores on restore).

  Dean Herbert · 2022-01-25 13:44:54 +09:00
  bbcc149e2e
• Merge pull request #16473 from mk56-spn/Liswiera-FL-changes

  Add method of adjusting flashlight radius in flashlight mod

  Dean Herbert · 2022-01-25 13:16:39 +09:00
  7d63999eef
• Update remaining cases of clashes with realm.Write and realm.RegisterForNotifications
  Dean Herbert · 2022-01-25 13:09:48 +09:00
  d7342880f5
• Update remaining cases of clashing variable name in realm.Run(realm..
  Dean Herbert · 2022-01-25 13:04:05 +09:00
  e23b10e6a5
• Fix cases of Access instead of Realm
  Dean Herbert · 2022-01-25 12:58:15 +09:00
  3e5c9e8436
• Fix TestMigration failing due to changes in realm migration logic

  Fixes failures as seen at https://github.com/ppy/osu/runs/4927916031?check_suite_focus=true.

  Dean Herbert · 2022-01-25 12:54:40 +09:00
  2d34831b5f
• Merge branch 'master' into Liswiera-FL-changes
  Bartłomiej Dach · 2022-01-24 21:32:36 +01:00
  8c3fbb6eb4
• Tweak allowable ranges of size multiplier
  Bartłomiej Dach · 2022-01-24 21:32:31 +01:00
  2375420d4c
• Disallow zero size multiplier in flashlight implementations
  Bartłomiej Dach · 2022-01-24 21:03:03 +01:00
  4a13c93ca7
• Simplify flashlight parameter passing flow
  Bartłomiej Dach · 2022-01-24 21:03:02 +01:00
  a227af75ed
• Extract DefaultFlashlightSize to base flashlight class
  Bartłomiej Dach · 2022-01-24 21:03:02 +01:00
  5874475dff
• Rename flashlight settings to be more accurate
  Bartłomiej Dach · 2022-01-24 21:03:02 +01:00
  a7c0d507ce
• Merge branch 'master' into realm-clean-up
  Bartłomiej Dach · 2022-01-24 19:15:31 +01:00
  da771044a7
• Merge pull request #16548 from peppy/music-controller-less-population

  Remove pointless initial `MusicController` beatmap set population

  Bartłomiej Dach · 2022-01-24 19:12:56 +01:00
  d544c52f3c
• Fix a failed BlockAllOperations leaving update realm in unretrieved state

  If the operation timed out on..
  
  ```csharp
     throw new TimeoutException(@"Took too long to acquire lock");
  ```
  
  ..from an update thread, it would not restore the update context.
  
  The next call would then fail on the assert that ensures a non-null
  context in such cases.
  
  Can add test coverage if required.

  Dean Herbert · 2022-01-24 20:53:29 +09:00
  6f4c337a56
• Merge branch 'master' into music-controller-less-population
  Dean Herbert · 2022-01-24 20:44:37 +09:00
  3bc86ee68f
• Update terminology to realm "instance" rather than "context"

  This matches the terminology used by realm themselves, which feels
  better.

  Dean Herbert · 2022-01-24 20:38:38 +09:00
  f30894840c
• Rename RealmContextFactory to RealmAccess
  Dean Herbert · 2022-01-24 20:38:07 +09:00
  6eb2c28e41
• Merge pull request #16547 from peppy/realm-stable-subscriptions

  Fix realm subscriptions getting lost after a context recycle

  Dan Balasescu · 2022-01-24 20:20:04 +09:00
  bb54ad9ad8
• Merge pull request #16590 from peppy/realm-migrate-on-failure

  Allow realm migration to run again if interrupted halfway

  Dan Balasescu · 2022-01-24 20:19:52 +09:00
  94ad7abfd6
• Don't include nested hit objects' DifficultyControLPoints in legacy encoder logic

  The editor doesn't currently propagate velocity to nested objects. We're
  not yet sure whether it should or not. For now, let's just ignore nested
  objects' `DifficultyControlPoints` for simplicity.
  
  Note that this only affects osu! ruleset due to the pre-check on
  `isOsuRuleset`.

  Dean Herbert · 2022-01-24 19:54:08 +09:00
  c3758047fd
• Add test coverage of saving velocity
  Dean Herbert · 2022-01-24 19:43:18 +09:00
  deaff340d2
• ModeMultiplier rename
  mk-56 · 2022-01-24 11:38:52 +01:00
  948867898c
• Merge branch 'master' into realm-stable-subscriptions
  Dan Balasescu · 2022-01-24 19:01:49 +09:00
  b396d55758
• Allow realm migration to run again if interrupted halfway
  Dean Herbert · 2022-01-24 18:55:15 +09:00
  66c5d77d63
• Fix attempt to revive update thread realm context from non-update thread
  Dean Herbert · 2022-01-24 18:36:16 +09:00
  9afa034296
• Guard against potential exception while blocking realm
  Dean Herbert · 2022-01-24 18:25:48 +09:00
  b0919722ac
• Merge branch 'master' into realm-stable-subscriptions
  Dean Herbert · 2022-01-24 18:25:47 +09:00
  9ff9611296
• Merge pull request #16588 from peppy/dont-exit-screens-test-browser

  Avoid adding "exit all screens" step when running tests interactively

  Dan Balasescu · 2022-01-24 18:24:41 +09:00
  37b74aafcc
• Fix copy pasted xmldoc
  Dean Herbert · 2022-01-24 18:05:30 +09:00
  e3083c2477
• Rename dictionaries to match methods
  Dean Herbert · 2022-01-24 17:58:53 +09:00
  bf5bf8d1fd
• Add xmldoc for RegisterForNotifications
  Dean Herbert · 2022-01-24 17:52:36 +09:00
  f4e7211ef1
• Lock unregistration for sanity
  Dean Herbert · 2022-01-24 17:46:53 +09:00
  abf14f0982
• Move context retrieval inside lock
  Dean Herbert · 2022-01-24 17:45:31 +09:00
  52cd906af6
• Remove bindable from ModeMultiplier
  mk-56 · 2022-01-24 09:07:07 +01:00
  161a2a321e
• Apply same fix to OsuGameTestScene
  Dean Herbert · 2022-01-24 17:05:49 +09:00
  e22aea0613
• Avoid adding "exit all screens" step when running tests interactively
  Dean Herbert · 2022-01-24 16:40:16 +09:00
  1e483ece32
• Merge pull request #16571 from bdach/custom-meter

  Add back editor support for non-standard time signatures

  Dean Herbert · 2022-01-24 16:09:47 +09:00
  5a12496873
• Merge branch 'master' into custom-meter
  Dean Herbert · 2022-01-24 15:46:44 +09:00
  d7db6fa918
• Merge pull request #16549 from Susko3/LoginPanel-flag

  Hide the login panel when clicking the country flag

  Dean Herbert · 2022-01-24 15:38:50 +09:00
  6581e8c2d3
• Refactor naming and add more comments to help understanding in RealmContextFactory subscription logic
  Dean Herbert · 2022-01-24 14:48:55 +09:00
  cb319cebdb
• Rename register methods to better explain their purpose
  Dean Herbert · 2022-01-24 14:37:36 +09:00
  40aa873190
• Add settings buttons to allow temporarily blocking realm access
  Dean Herbert · 2022-01-24 14:36:57 +09:00
  d7a9c5fd41
• Add locking over realmSubscriptionsResetMap for sanity
  Dean Herbert · 2022-01-24 13:36:51 +09:00
  997c13f643
• Adjust values to Bdach's refined taste
  mk-56 · 2022-01-24 00:42:43 +01:00
  ed84ae0ac0
• Merge pull request #16586 from bdach/beatmap-path-tostring
  Salman Ahmed · 2022-01-24 02:03:04 +03:00
  873d5bb104
• Fix saved beatmap filename depending on ToString() implementation
  Bartłomiej Dach · 2022-01-23 20:28:30 +01:00
  838a9f69ed
• Add failing test coverage for correct beatmap filename generation on save
  Bartłomiej Dach · 2022-01-23 20:28:19 +01:00
  e236f5d604
• Merge pull request #16545 from peppy/fix-intro-realm-usage

  Fix `IntroScreen` retrieving and iterating all realm beatmap sets

  Bartłomiej Dach · 2022-01-23 15:38:03 +01:00
  00a6d4e51c