34 Commits

• Tooling updates (#37031)

  Most of this is as everywhere else, but there's also interesting code
  inspection fixes from the InspectCode bump, so I'll talk about that a
  little.
  
  ## [Fix suspicious equality in
  `Hotkey`](https://github.com/ppy/osu/commit/948136e49e88a721827d54e51c5759fe9aca811d)
  
  Inspection:
  https://www.jetbrains.com/help/resharper/TypeWithSuspiciousEqualityIsUsedInRecord.Global.html
  
  Pretty annoying to fix, nullable array types are a pain. Does look legit
  though.
  
  ## [Fix `StarDifficulty` using inefficient struct
  equality](https://github.com/ppy/osu/commit/2db775ebb0bb9f18de67677ef84b993465d26545)
  
  Inspection:
  https://www.jetbrains.com/help/resharper/DefaultStructEqualityIsUsed.Global.html
  
  This is a dodgy one because there's no real sane way to define equality
  on `StarDifficulty` now that it has difficulty and performance
  attributes jammed into it. So I just basically shut the inspection up
  with a `record` modifier and move on.
  
  Unclear where the equality is used precisely. It's from a global
  inspection. F12 is very unhelpful when trying to track down usages of
  `Equals()`. We definitely have `Bindable<StarDifficulty>` instances and
  those do use equality. Maybe more than that.
  
  ## [Use `nameof` expressions to reference enum member
  names](https://github.com/ppy/osu/commit/aa08175c803bc725f3b15a92174dfe6d1b812d91)
  
  Inspection:
  https://www.jetbrains.com/help/resharper/CanSimplifyDictionaryRemovingWithSingleCall.html
  
  Pretty quaint.
  
  ## [Prefer using concrete values over `default` or
  `new()`](https://github.com/ppy/osu/commit/b21ee08d7748be10d42268d5c2eb77369026545d)
  
  Inspection:
  https://www.jetbrains.com/help/resharper/PreferConcreteValueOverDefault.html
  
  I could see this one going both ways, but I'm kinda sold on this
  inspection. Explicit is always better. Saves some allocations in the
  `CancellationToken` cases as well.
  
  ## [Explicitly call `.AsEnumerable()` in some realm
  usages](https://github.com/ppy/osu/commit/c8ce1ecd42b9d8abb8b9e2ab93d471f463e80401)
  
  Inspection:
  https://www.jetbrains.com/help/resharper/PossibleUnintendedQueryableAsEnumerable.html
  
  Not fully sold on this one but it's quick and simple so might as well.
  
  ## [Simplify dictionary removal with single `.Remove()`
  call](https://github.com/ppy/osu/commit/5964ceccea900302df726b7a8ecbf6b74eb2e427)
  
  Inspection:
  https://www.jetbrains.com/help/resharper/CanSimplifyDictionaryRemovingWithSingleCall.html
  
  Not much to say.

  Bartłomiej Dach · 2026-03-19 00:05:52 +09:00
  18d4ba5874
• Add metadata endpoint to refresh friend listing (#36386)

  Alternative to / closes https://github.com/ppy/osu/pull/36341
  See also: https://github.com/ppy/osu-server-spectator/pull/415
  
  This is a simple solution by adding a spectator endpoint to refresh the
  friend listing. A more complicated form of this is to make
  adding/removing friends only via spectator, but that would require
  osu-web changes too.

  Dan Balasescu · 2026-01-19 18:34:00 +09:00
  e62a01cf77
• Show self in online users

  I don't see a reason to hide self. I kinda expect to be able to see that
  I'm online.

  Dean Herbert · 2025-11-25 16:45:52 +09:00
  545b13c3fb
• Ensure all invocations of spectator server hub methods have their errors observed (#35488)

  Fell out when attempting
  https://github.com/ppy/osu-server-spectator/pull/346.
  
  Functionally, if a true non-`HubException` is produced via an invocation
  of a spectator server hub method, this doesn't really do much - the
  error will still log as 'unobserved' due to the default handler, it will
  still show up on sentry, etc. The only difference is that it'll get
  handled via the continuation installed in `FireAndForget()` rather than
  the `TaskScheduler.UnobservedTaskException` event.
  
  The only real case where this is relevant is when the server throws
  `HubException`s, which will now instead bubble up to a more
  human-readable form. Which is relevant to the aforementioned PR because
  that one makes any hub method potentially throw a `HubException` if the
  client version is too old.
  
  Obviously this does nothing for the existing old clients.

  Bartłomiej Dach · 2025-10-29 12:18:23 +09:00
  050c10cec2
• Always use MessagePack to talk to spectator server
  Dan Balasescu · 2025-08-06 16:36:33 +09:00
  d0e9fda874
• Add one more missing FireAndForget call

  ```csharp
  2025-07-17 08:52:06 [error]: An unobserved error has occurred.
  2025-07-17 08:52:06 [error]: System.TimeoutException: Server timeout
  (30000.00ms) elapsed without receiving a message from the server.
  2025-07-17 08:52:06 [error]: at
  Microsoft.AspNetCore.SignalR.Client.HubConnection.InvokeCoreAsync(String
  methodName, Type returnType, Object[] args, CancellationToken
  cancellationToken)
  2025-07-17 08:52:06 [error]: at
  Microsoft.AspNetCore.SignalR.Client.HubConnection.InvokeCoreAsyncCore(String
  methodName, Type returnType, Object[] args, CancellationToken
  cancellationToken)
  2025-07-17 08:52:06 [error]: at
  Microsoft.AspNetCore.SignalR.Client.HubConnection.InvokeCoreAsync(String
  methodName, Type returnType, Object[] args, CancellationToken
  cancellationToken)
  2025-07-17 08:52:06 [error]: at
  Microsoft.AspNetCore.SignalR.Client.HubConnectionExtensions.InvokeCoreAsync[TResult](HubConnection
  hubConnection, String methodName, Object[] args, CancellationToken
  cancellationToken)
  2025-07-17 08:52:06 [error]: at
  osu.Game.Online.Metadata.OnlineMetadataClient.<isConnectedChanged>b__31_1()
  ```

  Dean Herbert · 2025-07-18 16:24:17 +09:00
  f50323460f
• Simplify naming of endpoints
  Dean Herbert · 2025-02-07 17:33:32 +09:00
  41c8f64806
• Refactor user presence watching to be tokenised
  Dan Balasescu · 2025-02-04 17:54:03 +09:00
  61419ec9c8
• Rename fields from State to Presence when presence is involved
  Dean Herbert · 2025-01-17 16:25:48 +09:00
  3bb4b0c2b8
• Separate the local user state
  Dan Balasescu · 2025-01-17 15:59:34 +09:00
  a51938f4e9
• Move bindables to OsuConfigManager & SessionStatics
  Dan Balasescu · 2025-01-16 19:33:42 +09:00
  8400726887
• Expose as IBindable from IAPIProvider, writes via config
  Dan Balasescu · 2025-01-16 17:05:18 +09:00
  b54d959263
• Remove Status and Activity bindables from APIUser

  As for the tests, I'm (ab)using the `IsOnline` state for the time being
  to restore functionality.

  Dan Balasescu · 2025-01-14 23:45:30 +09:00
  20108e3b74
• Add separate path for friend presence notifications

  It proved to be too difficult to deal with the flow that clears user
  states on stopping the watching of global presence updates. It's not
  helped in the least that friends are updated via the API, so there's a
  third flow to consider (and the timings therein - both server-spectator
  and friends are updated concurrently).
  
  Simplest is to separate the friends flow, though this does mean some
  logic and state duplication.

  Dan Balasescu · 2025-01-09 17:31:01 +09:00
  7268b2e077
• Keep friend states when stopping watching global activity
  Dan Balasescu · 2025-01-09 13:23:16 +09:00
  f4d83fe685
• Add logging when starting and stopping watch operations in online metadata client

  For future use with debugging issues like
  https://github.com/ppy/osu/issues/29138, hopefully.

  Bartłomiej Dach · 2024-07-29 13:19:01 +02:00
  8b96b0b9e4
• Use room watching functionality to receive realtime daily challenge updates
  Bartłomiej Dach · 2024-06-28 13:35:16 +02:00
  df97215298
• Add client/server models for allowing clients to receive realtime playlist updates
  Bartłomiej Dach · 2024-06-27 11:32:18 +02:00
  d6e7781be1
• Add client/server models & operations for "daily challenge" feature
  Bartłomiej Dach · 2024-05-17 10:58:08 +02:00
  61a415fed2
• Do not attempt to stop watching user presence when requested to disconnect

  First of all, this sort of cleanup isn't really the client's
  responsibility, and secondly, at the point the client received this
  request to disconnect, *none of its requests will be honored anymore*
  (currently the only scenario of this if another client has connected
  - the server-side concurrency filter will reject this request).
  
  When disconnection is requested, the only valid thing to do with respect
  to talking to the server is to stop doing it.
  
  This will be moved server-side in a follow-up change, although I'm not
  even strictly sure that's required - I'd like to think signalr would
  know to clean up a disconnecting client from all groups they were in.

  Bartłomiej Dach · 2024-02-16 13:08:39 +01:00
  b4aa247032
• Actually disconnect from metadata hub when requested to

  Nothing in this override, on in the base implementation, would actually
  attempt to disconnect.

  Bartłomiej Dach · 2024-02-16 12:58:50 +01:00
  9fa60b169e
• Fix missing RPC method mapping

  Thanks, signalr.

  Bartłomiej Dach · 2024-02-16 12:58:13 +01:00
  171270d99c
• Fix users blipping online briefly before their online status is known
  Bartłomiej Dach · 2024-01-02 14:07:59 +01:00
  09b2a4e3b4
• Schedule even more
  Dean Herbert · 2023-12-20 19:42:05 +09:00
  5284b95bb8
• Fix thread safety of OnlineMetadataClient.UserStates

  Closes https://github.com/ppy/osu-framework/issues/6081.

  Dean Herbert · 2023-12-20 14:15:00 +09:00
  856c59f7f7
• Extend metadata client with user presence-observing capabilities
  Bartłomiej Dach · 2023-12-06 19:37:35 +01:00
  41c33f74f2
• Fix the MOTHERLOAD of undetected issues that are now visible thanks to net6.0
  Dean Herbert · 2022-12-16 18:16:26 +09:00
  27c497145f
• Partial everything
  Dan Balasescu · 2022-11-27 00:00:27 +09:00
  7bc8908ca9
• Catch any unobserved exceptions during beatmap metadata harvesting

  The process will retry when a connection is successful, so this doesn't
  need to be as loud as it was.
  
  Addresses https://github.com/ppy/osu/discussions/20331.

  Dean Herbert · 2022-09-16 14:00:06 +09:00
  21ac3fd88b
• Expose event from OnlineMetadataClient rather than calling BeatmapUpdater directly
  Dean Herbert · 2022-07-19 17:57:01 +09:00
  cd39f444ef
• Save last processed id to config for now
  Dean Herbert · 2022-07-05 21:42:35 +09:00
  bdd1bf4da0
• Hook up update flow to metadata stream
  Dean Herbert · 2022-07-05 21:32:00 +09:00
  59d0bac728
• Add recovery logic after disconnection
  Dean Herbert · 2022-07-05 21:32:00 +09:00
  b0d4f7aff6
• Add OnlineMetadataClient
  Dean Herbert · 2022-07-05 21:32:00 +09:00
  d217d66852