ekrctb
995ef953c6
Modify comment
2021-07-09 15:13:54 +09:00
Dean Herbert
9083b28114
Add test coverage of seeking and pausing
2021-07-09 14:47:11 +09:00
Dean Herbert
6a5f0e8237
Move handling of replay seek operations out of progress bar
...
This is in order to avoid using the now obsoleted property
`SliderBar.AllowKeyboardInputWhenNotHovered`
(see https://github.com/ppy/osu-framework/pull/4579 ).
2021-07-09 14:28:59 +09:00
Dean Herbert
741062a6da
Simplify bindable update methods
2021-07-09 13:58:44 +09:00
Dean Herbert
e0277763d0
Refactor DifficultyAdjustSettingsControl to help with readability
2021-07-09 13:50:07 +09:00
Dean Herbert
51bd83b3f4
Update override matching test to match expectations
2021-07-09 13:30:14 +09:00
Dean Herbert
f9cd7f10d8
Allow null values for ReadCurrentFromDifficulty
...
As long as this isn't a constructor parameter it feels best to
gracefully handle omission. Realistically having it in the ctor is the
best move, but it doesn't feel great in line with the other parameters
passed in via object initalisers.
2021-07-09 13:26:01 +09:00
Dean Herbert
90326f8864
Standardise variables
2021-07-09 13:24:26 +09:00
Dean Herbert
df4bd86cfc
Fix storage wrapping logic setting logger too early in startup sequence
2021-07-09 13:18:49 +09:00
Dean Herbert
f3b68a4fbf
Fix storage wrapping logic setting logger too early in startup sequence
2021-07-09 13:17:25 +09:00
ekrctb
7e14679606
Expand the selection movement limiting code with detailed comments
2021-07-09 12:58:08 +09:00
Dean Herbert
9786e1a932
Ensure run-from-screen song select reaches correct point in execution
...
Fixes issues as seen at
https://github.com/ppy/osu/runs/3023581865?check_suite_focus=true . Song
select may take a few frames to perform initial selection as there is a
bit of internal async logic. This ensures that the beatmap has been
updated before continuing with test execution.
2021-07-09 12:36:56 +09:00
Dean Herbert
887035c12e
Fix migration target having left over files potentially causing test failures
...
As seen at
https://github.com/ppy/osu/pull/13831/checks?check_run_id=3025050324 .
2021-07-09 12:21:25 +09:00
Dean Herbert
9f7c6adb58
Fix test failures due to logger pollution
...
As seen at
https://github.com/ppy/osu/pull/13831/checks?check_run_id=3025050307 . I
can't confirm that this will fix the issue but it looks like the only
plausible reason. I have confirmed that the logging is not coming from
the local (first logging is guaranteed to be after `SetupForRun`).
2021-07-09 12:15:30 +09:00
Dean Herbert
dbfeea9880
Merge pull request #13831 from nekodex/add-dropdown-sound-to-profile
...
Change profile section expansion button to use dropdown sounds
2021-07-09 11:58:48 +09:00
Jamie Taylor
2eb12a59b7
Rename function to be more accurate
2021-07-09 11:16:47 +09:00
Salman Ahmed
0223c569df
Remove no longer necessary method definitions
2021-07-09 00:49:05 +03:00
Salman Ahmed
a7be632770
Improve documentation
...
Co-authored-by: Bartłomiej Dach <dach.bartlomiej@gmail.com>
2021-07-09 00:39:09 +03:00
StanR
02298c2cf4
Fix incorrect curve, move total hits factor into a separate variable for clarity
2021-07-09 00:06:05 +03:00
Bartłomiej Dach
bd3f8b78cc
Merge pull request #13827 from peppy/fix-mod-select-cross-talk
...
Fix cross talk between `ModSelectOverlay`s
2021-07-08 20:31:55 +02:00
Bartłomiej Dach
3e21eeb7c2
Merge branch 'master' into fix-mod-select-cross-talk
2021-07-08 19:53:50 +02:00
Dean Herbert
1c7854b846
Merge pull request #13830 from nekodex/volume-control-switching-sound
...
Add sound for switching between volume controls
2021-07-09 01:03:36 +09:00
Salman Ahmed
f5166d8dd5
Merge branch 'master' into consume-bindable-current-factory
2021-07-08 18:13:48 +03:00
Dean Herbert
b7803b889e
Rename control class to be more descriptive
2021-07-08 20:37:38 +09:00
Jamie Taylor
8746ef0ba9
Avoid double playback of sample
2021-07-08 20:36:25 +09:00
Jamie Taylor
546f55d341
Change profile section expansion to use dropdown sounds
2021-07-08 20:23:11 +09:00
Jamie Taylor
93eb385dd4
Add sound for switching between volume controls
2021-07-08 20:01:39 +09:00
ekrctb
c937c45360
Don't move selected objects outside the playfield in catch editor
2021-07-08 18:49:32 +09:00
Dean Herbert
7153983dd4
Add test coverage
2021-07-08 18:29:54 +09:00
Dean Herbert
af270cccc4
Fix cross talk between ModSelectOverlays
2021-07-08 17:59:04 +09:00
StanR
592d3fdf00
Cleanup
2021-07-08 11:54:58 +03:00
StanR
c67f756c75
Change approach rate bonuses to be less punishing on mid-length maps
2021-07-08 11:52:43 +03:00
Dean Herbert
ba939c0b65
Simplify serialisation edge case by moving to Value override
2021-07-08 17:49:00 +09:00
Dean Herbert
52ea62e3b2
Add more comments and xmldoc
2021-07-08 17:49:00 +09:00
Dean Herbert
533db01cc0
Add comprehensive tests of difficulty adjust settings
2021-07-08 17:49:00 +09:00
Dean Herbert
88b00123f6
Use existing reflection methods to avoid manual binding of ExtendedLimits
2021-07-08 17:49:00 +09:00
Dean Herbert
bd7c334588
Avoid the need for per-settings control classes
2021-07-08 17:49:00 +09:00
Dean Herbert
a6e94dd491
Add back extended limits support
2021-07-08 17:49:00 +09:00
Dean Herbert
c4313d6e96
Initial implementation of new flow (only working for approach rate)
2021-07-08 17:48:08 +09:00
Dean Herbert
fcee69ffe6
Fix ShowsDefaultIndicator not actually being consumed
2021-07-08 17:48:08 +09:00
ekrctb
25b94061fd
Fix assert step not waiting for transformation
2021-07-08 16:40:18 +09:00
ekrctb
8ac3015f14
Add tests of banana shower placement blueprint
2021-07-08 16:36:44 +09:00
ekrctb
4ac7d629d7
Expose current placement blueprint
2021-07-08 16:36:41 +09:00
ekrctb
68116aa042
Fix placement blueprint animation is not running in test scene
2021-07-08 16:17:09 +09:00
ekrctb
ae67409f41
Add a test of fruit placement blueprint
2021-07-08 16:12:08 +09:00
ekrctb
8da1335e5f
Add catch placement blueprint visual test scenes (without tests)
2021-07-08 15:51:46 +09:00
ekrctb
bd4b3f5268
Add catch selection blueprint visual test scene (without tests)
2021-07-08 15:42:29 +09:00
Dean Herbert
d540156e94
Remove now unnecessary BeatmapDifficulty.ID
2021-07-08 14:31:25 +09:00
Dean Herbert
0e4f4a6fde
Initial storage changes
2021-07-08 14:28:13 +09:00
Dean Herbert
8d94e8f534
Enable tests and update expectations
2021-07-08 14:28:05 +09:00
