Dean Herbert
e86748626a
Merge pull request #22296 from frenzibyte/actually-fix-beatmap-options
2023-01-20 10:21:55 +09:00
Dean Herbert
684d05e9aa
Merge pull request #22297 from frenzibyte/fix-playlists-match-test-failure
2023-01-20 10:19:45 +09:00
Salman Ahmed
8174ef06c3
Fix intermittent failure in playlists match loading test
2023-01-20 01:18:41 +03:00
Salman Ahmed
f0464b0340
Actually fix intermittent failure in beatmap options state test
2023-01-19 22:47:35 +03:00
ekrctb
d8f9b7d02f
Use MaximumJudgementOffset for lifetime
2023-01-19 21:25:21 +09:00
ekrctb
11e1b22bf5
Move MaximumJudgementOffset to HitObject
...
We want to access this property for computing lifetime
2023-01-19 21:23:55 +09:00
Dean Herbert
5a1940facf
Merge pull request #22290 from mk56-spn/judgement_fix
...
Fix JudgementCounterDisplay.cs max judgement not hiding upon display mode change
2023-01-19 20:00:44 +09:00
ekrctb
32acaa44be
Remove now-redundant code
2023-01-19 19:57:25 +09:00
ekrctb
812a4b412a
Move judgement result revert logic to Playfield
...
Previously, some judgement results were not reverted
when the source DHO is not alive (e.g. frames skipped in editor).
Now, all results are reverted in the exact reverse order.
2023-01-19 19:57:13 +09:00
Dean Herbert
2ce32e3209
Refactor update logic to be easier to follow
2023-01-19 19:27:05 +09:00
mk56-spn
b22363ed8c
Fix JudgementCounterDisplay.cs max judgement always showing upon changing display mode
2023-01-19 10:31:02 +01:00
Dean Herbert
c6dfbab702
Merge pull request #22283 from Feodor0090/comment-reply
...
Add ability to leave replies to comments
2023-01-19 16:41:05 +09:00
Dean Herbert
4916a742d5
Immediately focus the textbox when clicking to reply to a comment
2023-01-19 16:08:27 +09:00
Dean Herbert
81e6c3792c
Remove unused method
2023-01-19 16:03:46 +09:00
Dean Herbert
56ce8504ae
Merge branch 'master' into comment-reply
2023-01-19 16:01:47 +09:00
Dean Herbert
07af18b8a7
Remove ReplyCommentEditor into its own class
2023-01-19 16:01:37 +09:00
Dean Herbert
db8084570d
Merge pull request #22285 from bdach/segmented-graph-tint
...
Apply draw colour to segmented graph
2023-01-19 13:36:19 +09:00
Dean Herbert
e58abf7d1a
Merge pull request #22284 from bdach/judgement-counter-broken
...
Fix "show max judgement" setting not applying initially on judgement counter display
2023-01-19 09:09:06 +09:00
Bartłomiej Dach
83c38a8960
Merge pull request #22233 from peppy/osu-ruleset-multi-touch-basic
...
Add basic multi-touch support for osu! ruleset
2023-01-19 00:59:45 +01:00
Bartłomiej Dach
2fba80dfd3
Merge branch 'master' into osu-ruleset-multi-touch-basic
2023-01-19 00:26:57 +01:00
Bartłomiej Dach
593f5f6d56
Merge pull request #22144 from ItsShamed/skin/argon-song-progress-cleaner
...
Add "argon" variant of song progress display
2023-01-19 00:25:39 +01:00
Bartłomiej Dach
a0fe71c706
Use alternative segment colour computation method
2023-01-19 00:08:32 +01:00
Bartłomiej Dach
b62ff8d644
Merge branch 'master' into skin/argon-song-progress-cleaner
2023-01-18 23:52:12 +01:00
Bartłomiej Dach
b8b7442eb8
Make SongProgressInfo.ShowProgress init-only (and remove duplicate init)
2023-01-18 23:35:40 +01:00
Bartłomiej Dach
903c37bf32
Apply draw colour to segmented graph segments
2023-01-18 23:17:57 +01:00
Bartłomiej Dach
e09b768a99
Add test steps demonstrating failure
2023-01-18 23:07:40 +01:00
Wleter
f8d8a627b8
change property name
2023-01-18 22:00:39 +01:00
Bartłomiej Dach
769f8c6190
Fix ShowMaxJudgement callback conflicting with JudgementCounter.Pop{In,Out}
...
Both `JudgementCounterDisplay` (via the `ShowMaxJudgement` callback)
and the `JudgementCounter.Pop{In,Out}` methods were operating on the
alpha of the `JudgementCounter`. This meant that if the counter display
was created with max judgement initially hidden, it would be hidden
by the `ShowMaxJudgement` callback first, but then _unhidden_
by `PopIn()`.
2023-01-18 21:46:28 +01:00
Wleter
40e99069fc
fix typos and newlines
2023-01-18 21:43:09 +01:00
Bartłomiej Dach
7299d227d1
Add failing test case
2023-01-18 21:42:22 +01:00
Bartłomiej Dach
06212bca51
Restructure test scene to demonstrate failure
2023-01-18 21:41:00 +01:00
Wleter
ab78dd0436
add collection of selection points.
2023-01-18 21:34:23 +01:00
ansel
7f4d8bdcaa
Add test
2023-01-18 21:27:42 +03:00
ansel
77bc4fbf70
Integrate editor into comment
2023-01-18 20:50:07 +03:00
ansel
0d91277ea5
Add ability to change number on replies button
2023-01-18 20:49:30 +03:00
ansel
c74500b4b4
Add reply editor
2023-01-18 20:49:07 +03:00
Bartłomiej Dach
761298cd8e
Merge pull request #22275 from peppy/fix-legacy-old-judgement-animation
...
Fix legacy judgement animation not matching perfectly
2023-01-18 18:27:13 +01:00
Gabe Livengood
150195b887
use extension method to check accuracy impact
2023-01-18 12:24:41 -05:00
Gabe Livengood
e0f3fa1af6
remove this in ruleset assignment
2023-01-18 12:22:27 -05:00
Bartłomiej Dach
c7249383ba
Merge pull request #22248 from peppy/fix-carousel-sort-change-after-play
...
Fix beatmap sorting at song select sometimes changing after setting a score
2023-01-18 17:57:08 +01:00
Bartłomiej Dach
4a6f6300c5
Merge branch 'master' into fix-carousel-sort-change-after-play
2023-01-18 17:15:20 +01:00
Bartłomiej Dach
7ba448b13c
Update comment to match implementation
2023-01-18 17:12:57 +01:00
cdwcgt
997a1a8b02
add test for CheckPreviewTime
2023-01-19 01:08:56 +09:00
cdwcgt
e5eab72aeb
add check for preview time setting
2023-01-19 01:08:37 +09:00
ansel
0f2ca5d5ed
Expose method for drawable comment creation
2023-01-18 18:10:35 +03:00
Wleter
c9375c056e
revert back name change
2023-01-18 15:54:24 +01:00
ansel
18baf3dd5d
Log delete failure
2023-01-18 17:30:34 +03:00
StanR
8ae82484b5
Usings
2023-01-18 16:38:58 +03:00
Dean Herbert
0f3a586738
Merge pull request #22273 from peppy/frame-stable-cache
...
Cache `IFrameStableClock` in `Player` for easier access
2023-01-18 22:31:35 +09:00
StanR
24ed84aad0
Add tiered level badge colouring
2023-01-18 16:25:11 +03:00
