Dean Herbert
7f8eebc510
Merge pull request #30578 from smoogipoo/beatmap-legacy-object-type
...
Simplify convertible hitobject parsing and add `IHasLegacyHitObjectType`
2024-11-14 16:16:44 +09:00
Dean Herbert
d37c1bb6d0
Remove redundant null initialisation and apply nullability
2024-11-14 13:37:58 +09:00
Dean Herbert
7670a81181
Merge branch 'master' into bat-max-performance
2024-11-14 13:35:29 +09:00
Dan Balasescu
7206e97b7b
Add IHasLegacyHitObjectType to ConvertHitObject
2024-11-11 16:10:15 +09:00
Dan Balasescu
e1d93a7d9c
Merge implementations of ConvertHitObjectParser
...
Having these be separate implementations sounded awesome at the time,
but it only ever led to confusion. There's no practical difference if,
for example, catch sees hitobjects with `IHasPosition` instead of
`IHasXPosition`.
2024-11-11 15:09:13 +09:00
Dean Herbert
c7d0a7dde2
Update xmldoc and make realm transactions more obvious
2024-11-07 18:31:06 +09:00
Dan Balasescu
bd630c189e
Fix tests not working by forgoing beatmap updates
2024-11-07 17:26:10 +09:00
Bartłomiej Dach
23f3890293
Fix effect point scroll speeds below 0.1x not being encoded properly
...
Closes https://github.com/ppy/osu/issues/30472 .
Caused by mismatching bounds between
2bd12e14db/osu.Game/Beatmaps/ControlPoints/EffectControlPoint.cs (L22-L26)2bd12e14db/osu.Game/Beatmaps/ControlPoints/DifficultyControlPoint.cs (L21-L28)
2024-11-05 11:56:19 +01:00
Bartłomiej Dach
3dc2408965
Merge branch 'master' into bat-max-performance
2024-11-01 13:13:20 +01:00
Bartłomiej Dach
7e3564cb4a
Bring back matching by filename when performing online metadata lookups
2024-10-30 10:25:20 +01:00
Bartłomiej Dach
2b0fd3558f
Remove more no-longer-required checks
...
The scenario that remaining guard was trying to protect against is
obviated by and no longer possible after
776fabd77c
2024-10-30 08:44:23 +01:00
Bartłomiej Dach
776fabd77c
Only use MD5 when performing metadata lookups
...
Both online and offline using the cache.
The rationale behind this change is that in the current state of
affairs, `TestPartiallyMaliciousSet()` fails in a way that cannot be
reconciled without this sort of change.
The test exercises a scenario where the beatmap being imported has an
online ID in the `.osu` file, but its hash does not match the online
hash of the beatmap. This turns out to be a more frequent scenario than
envisioned because of users doing stupid things with manual file editing
rather than reporting issues properly.
The scenario is realistic only because the behaviour of the endpoint
responsible for looking up beatmaps is such that if multiple parameters
are given (e.g. all three of beatmap MD5, online ID, and filename), it
will try the three in succession:
f6b341813b/app/Http/Controllers/BeatmapsController.php (L260-L266)
2024-10-30 08:12:30 +01:00
Bartłomiej Dach
1a2e323c11
Remove problematic online ID check
2024-10-30 07:40:08 +01:00
Dean Herbert
5939c78760
Merge branch 'master' into auto-addition2
2024-10-23 15:53:07 +09:00
Dean Herbert
8193038986
Expose no-op constructors as protected
2024-10-18 13:30:29 +09:00
Dan Balasescu
bfcf6693ca
Simplify implementation
2024-10-17 20:00:17 +09:00
Dan Balasescu
d195a69447
Compute maximum performance along with difficulty
2024-10-17 19:26:19 +09:00
Dean Herbert
53671ad11e
Only update beatmaps which actually had offsets
...
Without this every beatmap gets a write and it reloads the whole of song
select, basically.
2024-10-14 00:35:18 +09:00
Artemis Rosman
e4f9c861ba
Add functionality to mass reset offsets
2024-10-13 00:50:45 +11:00
Dean Herbert
307cc5581d
Fix usage of locked context without locking
...
Raised in the latest Rider EAP, seems valid enough.
2024-10-01 18:01:06 +09:00
OliBomby
0a78eb9628
Implement auto additions editor-only
2024-10-01 16:40:48 +09:00
Dean Herbert
89e8baf1d3
Add inline comments for iOS locals
2024-09-26 16:48:42 +09:00
Dan Balasescu
3ab04d98f6
Fix Realm-related iOS crashes by removing object references
2024-09-25 16:45:37 +09:00
Bartłomiej Dach
a4f6d4a300
Backpopulate missing ranked/submitted dates using new local metadata cache
...
People keep asking why https://github.com/ppy/osu/pull/29553 didn't fix
their databases (as stated in the PR, it didn't intend to), so this
should do it for them.
2024-09-13 16:00:49 +02:00
Dan Balasescu
5d09aaae27
Merge pull request #29446 from OliBomby/last-anchor
...
Fix path control points losing curve type on save/reload or undo
2024-09-02 18:40:19 +09:00
Bartłomiej Dach
bd6943ebc2
Merge pull request #29537 from normalid-awa/feature/song-select/allow-copy-url-from-context-menu
...
Allow copying beatmap link in song select carousel context menu
2024-08-22 14:03:39 +02:00
Dean Herbert
066c34e950
Merge pull request #29553 from bdach/local-cache-updates
...
Add support for retrieving submit/rank date from local metadata cache in version 2
2024-08-22 14:55:43 +09:00
Dean Herbert
87123d99bf
Move URL implementation to extension methods and share with other usages
2024-08-22 02:08:01 +09:00
Dean Herbert
a943000579
Merge pull request #29435 from OliBomby/improve-snaps
...
Fix timeline snapping ignoring nearby timing points
2024-08-22 01:36:30 +09:00
Bartłomiej Dach
5f88435d96
Add support for retrieving submit/rank date from local metadata cache in version 2
...
Closes https://github.com/ppy/osu/issues/22416 .
2024-08-21 15:42:22 +02:00
OliBomby
8d72ec8bd6
move timing point binary search back inline
2024-08-21 01:50:52 +02:00
Bartłomiej Dach
c2dd2ad978
Clamp beat divisor to sane range when decoding
...
In my view this is a nice change, but do note that on its own it does
nothing to fix https://github.com/ppy/osu/issues/29492 , because of
`BeatmapInfo` reference management foibles when opening the editor. See
also: https://github.com/ppy/osu/issues/20883#issuecomment-1288149271 ,
https://github.com/ppy/osu/pull/28473 .
2024-08-20 13:52:29 +02:00
OliBomby
4cc38cea63
fix last anchor converting to implicit segment
2024-08-16 14:24:03 +02:00
Joseph Madamba
e2bf02cf94
Fix preview play button having incorrect click area
2024-08-15 22:49:12 -07:00
Joseph Madamba
fda17a5a72
Expose BeatmapCardNormal height const
2024-08-15 22:49:12 -07:00
OliBomby
2e11172e8e
Take into account next timing point when snapping time
2024-08-16 01:01:24 +02:00
OliBomby
ac064e814f
Add BinarySearchUtils
2024-08-16 00:15:40 +02:00
Dean Herbert
d2c1d83567
Merge branch 'master' into daily-challenge-intro-audio-auto-download
2024-08-10 01:21:43 +09:00
Dean Herbert
d072c6a743
Fix hit object coordinates being truncated to int values
...
Closes https://github.com/ppy/osu/issues/29340 .
2024-08-09 16:34:39 +09:00
Dean Herbert
5d66eda982
Add support for automatically downloading daily challenge during the intro display
2024-08-08 15:10:18 +09:00
Dean Herbert
60fc02bb9b
Merge branch 'master' into feature/skin/legacy-input-overlay
2024-08-06 14:05:33 +09:00
Dean Herbert
dc73856f76
Fix original date not being restored when no changes are made on an import-as-update operation
2024-08-02 20:46:03 +09:00
Bartłomiej Dach
3c28c116ca
Simplify input overlay text colour decode (and fix incorrect default)
2024-07-24 14:53:01 +02:00
normalid
b24be96d04
Fix code quality
2024-07-24 12:57:30 +08:00
normalid
c52a993607
Support custom input overlay color
2024-07-23 23:35:25 +08:00
Dean Herbert
f11f01f9b7
Fix various visuals of playlist beatmap panels
...
Supersedes https://github.com/ppy/osu/pull/28907 .
- Fix border being fat
- Fix thumbnail not masking correctly
- Fix background layer not being correctly fit to the panel
- Dim the main background on hover
- Minor tweaks to dimming
2024-07-19 19:26:04 +09:00
Dean Herbert
e6b7d2530e
Change red shade for timing control points
2024-07-12 13:39:40 +09:00
Dean Herbert
95464ebf36
Merge branch 'master' into timeline-redesign
2024-07-11 18:38:17 +09:00
Dean Herbert
b5bb94e4ec
Merge branch 'master' into file-mounting-v3
2024-07-11 15:54:54 +09:00
Dean Herbert
2eb6cf57af
Fix incorrect continuation in ImportAsUpdate causing UI blockage
2024-07-11 13:42:24 +09:00
