75266 Commits

This Branch

This Branch

All Branches

• Fix new inspection after framework bump
  Bartłomiej Dach · 2024-06-18 18:32:58 +02:00
  8836b98070
• Merge branch 'master' into navigate-to-timestamp
  Bartłomiej Dach · 2024-06-18 18:32:33 +02:00
  5551bae7ce
• Correct xmldoc
  Bartłomiej Dach · 2024-06-18 18:32:24 +02:00
  f764ec24cd
• Parse plain numbers as millisecond count when parsing timestamp
  Bartłomiej Dach · 2024-06-18 16:48:04 +02:00
  7ee29667db
• Merge pull request #28518 from bdach/update-framework

  Update framework

  Dan Balasescu · 2024-06-18 23:44:42 +09:00
  1933c14bee
• Fix tests
  Bartłomiej Dach · 2024-06-18 16:41:13 +02:00
  623055b60a
• Fix bottom timeline break visualisations not updating
  Bartłomiej Dach · 2024-06-18 15:54:34 +02:00
  f88f05717a
• Implement ability to manually adjust breaks
  Bartłomiej Dach · 2024-06-18 15:51:29 +02:00
  814f1e552f
• Add break display to editor timeline
  Bartłomiej Dach · 2024-06-18 14:55:59 +02:00
  a9e662a2b6
• Updated the tests according to new logic

  and fixed one minor CI code quality thing

  Givikap120 · 2024-06-18 15:48:21 +03:00
  1ddfc8f011
• Changed timed difficulty attributes to be "per-HitObject" instead of "per-DifficultyHitObject"
  Givikap120 · 2024-06-18 15:41:41 +03:00
  ec2b8f3bc3
• Allow more lenient parsing of incoming timestamps
  Bartłomiej Dach · 2024-06-18 13:13:50 +02:00
  44b9a06639
• Address review feedback
  Bartłomiej Dach · 2024-06-18 13:07:18 +02:00
  e1827ac28d
• Fix test failures
  Bartłomiej Dach · 2024-06-18 10:41:26 +02:00
  5fe21f16b9
• Extend slider selection box bounds to contain all control points inside

  Previously, the selection box was only guaranteed to contain the actual
  body of the slider itself, the control point nodes were allowed to exit
  it. This lead to a lot of weird interactions with the selection box
  controls (rotation/drag handles, also the buttons under/over it) as the
  slider anchors could overlap with them.
  
  To bypass this issue entirely just ensure that the selection box's size
  does include the control point nodes at all times.

  Bartłomiej Dach · 2024-06-18 10:28:36 +02:00
  87888ff0bb
• Change editor speed adjustment back to adjusting tempo

  - Partially reverts https://github.com/ppy/osu/pull/12080
  - Addresses https://github.com/ppy/osu/discussions/27830,
    https://github.com/ppy/osu/discussions/23789,
    https://github.com/ppy/osu/discussions/15368, et al.
  
  The important distinction here is that to prevent misuse when timing,
  the control will revert to 1.0x speed and disable when moving to timing
  screen, with a tooltip explaining why.

  Bartłomiej Dach · 2024-06-18 09:46:00 +02:00
  1b4a3b0e2e
• Fix nullability insepction
  Dean Herbert · 2024-06-18 15:13:52 +08:00
  e6187ebec0
• Fix code quality inspections
  Bartłomiej Dach · 2024-06-18 08:33:02 +02:00
  2421751419
• Adjust & expand test coverage
  Bartłomiej Dach · 2024-06-18 08:32:12 +02:00
  73786a6f9f
• Adjust hotkeys to address feedback
  Bartłomiej Dach · 2024-06-18 08:25:05 +02:00
  a3326086f7
• Add slider placement binding description in tooltip
  Bartłomiej Dach · 2024-06-18 08:16:25 +02:00
  310265c43f
• Adjust calls to DrawableExtensions.With<T>()
  Bartłomiej Dach · 2024-06-18 07:41:20 +02:00
  366ba26cb6
• Adjust calls to GetContainingInputManager()
  Bartłomiej Dach · 2024-06-18 07:41:19 +02:00
  659505f711
• Null-propagate all calls to GetContainingFocusManager()
  Bartłomiej Dach · 2024-06-18 07:30:46 +02:00
  8a4ae5d23d
• Adjust AudioFilter to framework-side changes

  Co-authored-by: Dan Balasescu <smoogipoo@smgi.me>

  Bartłomiej Dach · 2024-06-18 07:30:46 +02:00
  7f08008059
• Update framework
  Bartłomiej Dach · 2024-06-18 07:26:20 +02:00
  da4160439e
• Merge pull request #23443 from OliBomby/edit-nodesample

  Make NodeSamples editable

  Dean Herbert · 2024-06-18 11:12:02 +09:00
  316125d47a
• Implement direct choice of slider control point path type via Alt-number
  Bartłomiej Dach · 2024-06-17 18:33:36 +02:00
  683d5310b1
• Fix test failure
  Bartłomiej Dach · 2024-06-17 18:14:33 +02:00
  a631d245da
• Allow to jump to a specific timestamp via bottom bar in editor

  Apparently this is a stable feature and is helpful for modding.

  Bartłomiej Dach · 2024-06-17 17:07:55 +02:00
  5652a558f9
• Add testing for keyboard control of path during selection
  Bartłomiej Dach · 2024-06-17 15:56:48 +02:00
  7898100698
• Add testing for keyboard control of path during placement
  Bartłomiej Dach · 2024-06-17 15:56:48 +02:00
  1e137271ab
• Add ability to cycle through available types when selecting single control point on a slider
  Bartłomiej Dach · 2024-06-17 15:56:48 +02:00
  88bdc12022
• Add ability to start a new segment during placement via S key
  Bartłomiej Dach · 2024-06-17 15:56:48 +02:00
  16ea8f67b0
• Add ability to better control slider control point type during placement via Tab
  Bartłomiej Dach · 2024-06-17 15:56:48 +02:00
  b5f0e58524
• Merge pull request #28507 from bdach/editor-opacity

  Reduce editor opacity of several editor components when hovering over composer

  Dean Herbert · 2024-06-17 22:16:08 +09:00
  b535f7c519
• Merge pull request #28468 from bdach/daily-challenge/event-feed

  Implement event feed view for daily challenge screen

  Dean Herbert · 2024-06-17 20:16:48 +09:00
  a6f09bc626
• Record on single line
  Dean Herbert · 2024-06-17 19:16:23 +08:00
  d3d325c46c
• Disable collection expression inspections completely
  Dean Herbert · 2024-06-17 19:11:08 +08:00
  05596a391d
• Reduce editor opacity of several editor components when hovering over composer

  Addresses https://github.com/ppy/osu/discussions/24384.

  Bartłomiej Dach · 2024-06-17 12:14:28 +02:00
  7cfe8d8df2
• Merge pull request #28505 from bdach/move-timeline-toggles-elsewhere

  Move timeline toggle controls to "view" menu

  Dean Herbert · 2024-06-17 18:59:38 +09:00
  cc0ef20afd
• Align beat snap control width with right toolbox
  Bartłomiej Dach · 2024-06-17 11:47:37 +02:00
  07f1994a13
• Remove unused delegate for now

  To silence inspections.

  Bartłomiej Dach · 2024-06-17 11:09:07 +02:00
  3884bce239
• Remove redundant type spec
  Bartłomiej Dach · 2024-06-17 10:54:52 +02:00
  f7910f774d
• Merge pull request #28504 from bdach/osu-playfield-border-includes-radius

  Account for osu! circle radius when drawing playfield border

  Dean Herbert · 2024-06-17 17:48:29 +09:00
  291a7f07e6
• Merge pull request #28503 from smoogipoo/partial-aot-trimming

  Annotate `ControlPoint` and `Mod` for AOT trimming support

  Bartłomiej Dach · 2024-06-17 10:36:17 +02:00
  57688c2cfa
• Remove stuff that looks bad after moving timeline toggle controls
  Bartłomiej Dach · 2024-06-17 10:23:00 +02:00
  03049d45bb
• Move timeline toggle controls to "view" menu
  Bartłomiej Dach · 2024-06-17 10:16:40 +02:00
  b42752c9f0
• Also annotate ControlPointInfo

  Same deal with this class. Fully qualifying the type names because this
  has `#nullable disable` and makes use of `NotNull` which is also present
  in the `System.Diagnostics.CodeAnalysis` namespace and AAAAAAARGH
  NAMESPACE CONFLICTS.

  Dan Balasescu · 2024-06-17 17:13:44 +09:00
  f86e9c9a4a
• Fix playfield border size not updating in editor on circle size change
  Bartłomiej Dach · 2024-06-17 09:36:01 +02:00
  1b00d0181a