48098 Commits

• Merge pull request #31110 from peppy/timing-current-point-indicator

  Change the way "current" points are hinted on timing screen

  Bartłomiej Dach · 2024-12-16 13:27:06 +09:00
  9652c5a7ca
• Revert "Fix text anchor for mania tooltip"

  This reverts commit c0b6e784a5.
  
  The change affects editor and other stuff and I'm not sure it's correct.
  It's not like client needs to match the appearance really. It already
  doesn't in many places.

  Bartłomiej Dach · 2024-12-16 13:18:47 +09:00
  ecb7a809f2
• Split actual methods & fix completely broken localisation

  Localisable strings cannot be plainly interpolated or joined. That is a
  lossy operation that loses data.

  Bartłomiej Dach · 2024-12-16 13:16:52 +09:00
  cfdb959cf6
• Clean up model

  - Properly annotate things as nullable
  - Remove weird passthrough property (more on that later)

  Bartłomiej Dach · 2024-12-16 13:14:21 +09:00
  8d1d026f56
• Expose high precision mouse toggle when searching for "sensitivity" and other keywords
  Dean Herbert · 2024-12-16 13:12:21 +09:00
  a8948628e6
• Merge pull request #31109 from peppy/fix-editor-timing-undo-redo

  Fix adjusting control point offset after undo/redo causing catastrophic failure

  Bartłomiej Dach · 2024-12-16 12:40:22 +09:00
  573d709fae
• Merge branch 'master' into timing-current-point-indicator
  Bartłomiej Dach · 2024-12-16 12:22:14 +09:00
  98e8d0b497
• Fix code quality
  Bartłomiej Dach · 2024-12-16 12:22:06 +09:00
  1058abb4ab
• Implement ability to mark beatmap as played

  Reported at https://osu.ppy.sh/community/forums/topics/2015478?n=1.
  
  Would you believe it that this button that has been there for literal
  years never did anything?
  
  Implemented at a per-beatmap level. Also additionally added to context
  menu (at @peppy's suggestion), and also copy reworded from "Delete from
  unplayed" to "Mark as played" because double negation hurt my tiny
  brain.

  Bartłomiej Dach · 2024-12-16 10:49:19 +09:00
  a6e00d6eac
• Fix code quality issues
  Nicholas Chin · 2024-12-15 13:53:33 +08:00
  e2edd9e0d5
• Use Count comparison instead of Any
  Nicholas Chin · 2024-12-14 08:29:32 +08:00
  153e6c0c22
• Merge pull request #31108 from peppy/quick-retry-for-replays

  Allow using "quick retry" shortcut in more cases from results screen

  Dean Herbert · 2024-12-13 08:18:59 -08:00
  c93b6dba2b
• Fix text anchor for mania tooltip
  Nicholas Chin · 2024-12-13 21:58:23 +08:00
  c0b6e784a5
• Reword comment to hopefully be more understandable
  Dean Herbert · 2024-12-13 20:02:17 +09:00
  9025103b8b
• Change the way "current" points are hinted on timing screen

  I actually thought things were bugged with the previous display method,
  since the hinting was very similar to the hover colour/state.
  
  I've adjusted this to hopefully give users a better idea of what this is
  intending to show them.

  Dean Herbert · 2024-12-13 19:45:18 +09:00
  da840e3fac
• Fix adjusting control point offset after undo/redo causing catastrophic failure

  Closes https://github.com/ppy/osu/issues/31098.
  
  Low effort fix because it was already half broken. The test was testing
  in isolation but in actual editor usage it wasn't working as expected.

  Dean Herbert · 2024-12-13 19:33:51 +09:00
  64555debc2
• Merge pull request #31106 from peppy/player-settings-fix-overlap-skins

  Fix player settings overlay cog overlapping skin elements

  Dan Balasescu · 2024-12-13 19:30:39 +09:00
  35c70ceb18
• Add note about player settings overlay button
  Dean Herbert · 2024-12-13 18:58:20 +09:00
  4b0cdd761d
• Merge pull request #31101 from Joehuu/recommended-diff-beatmap-listing

  Add recommended difficulty numerical value near filter in beatmap listing

  Dan Balasescu · 2024-12-13 18:57:16 +09:00
  f84c67babd
• Also allow using "quick retry" for other replays
  Dean Herbert · 2024-12-13 18:14:45 +09:00
  d00bc4bdd1
• Fix "quick retry" hotkey not working for autoplay
  Dean Herbert · 2024-12-13 18:08:29 +09:00
  0e0d96829f
• Fix player settings overlay cog overlapping skin elements

  This brings it down to be in line with the flowing elements that usually
  do their best to not get in the way.
  
  Decided against putting it in the `HUDOverlay` flow for simplicity. It
  will work fine until it doesn't.

  Dean Herbert · 2024-12-13 17:28:15 +09:00
  a796af9511
• Fix player settings overlay appearing while in skin editor
  Dean Herbert · 2024-12-13 17:18:34 +09:00
  1e809c7f16
• Merge pull request #31073 from bdach/filter-playing-rooms

  Add ability to filter out currently playing rooms

  Dan Balasescu · 2024-12-13 17:03:30 +09:00
  2930db5d6e
• Unbind event on disposal
  Dan Balasescu · 2024-12-13 16:39:16 +09:00
  7bb1a5118e
• Merge branch 'master' into recommended-diff-beatmap-listing
  Dan Balasescu · 2024-12-13 16:38:07 +09:00
  62a1a5883a
• Adjust padding to avoid wrapping on checkbox text
  Dean Herbert · 2024-12-13 15:42:30 +09:00
  313de33986
• Update recommended difficulty for osu!taiko
  Joseph Madamba · 2024-12-12 16:17:57 -08:00
  38b3d5fc00
• Add test and null protections
  Joseph Madamba · 2024-12-12 15:23:00 -08:00
  f7364de01a
• Add recommended difficulty numerical value near filter in beatmap listing
  Joseph Madamba · 2024-12-12 15:23:00 -08:00
  92e07b4f99
• Add FormatStarRating() method util
  Joseph Madamba · 2024-12-12 15:23:00 -08:00
  e95dc2b308
• Apply NRT to incoming changed files
  Joseph Madamba · 2024-12-12 15:22:58 -08:00
  3035e8435d
• Replace switch expression with LocalisableDescription attribute for variant display

  Use existing localisation strings from BeatmapsStrings instead of CommonStrings for consistent localisation handling

  Nicholas Chin · 2024-12-12 22:39:21 +08:00
  a22f3416d6
• Store value of toggle to setting
  Bartłomiej Dach · 2024-12-12 15:17:39 +09:00
  0328708889
• Adjust copy
  Bartłomiej Dach · 2024-12-12 15:17:39 +09:00
  61ee830588
• Merge branch 'master' into filter-playing-rooms
  Bartłomiej Dach · 2024-12-12 13:06:22 +09:00
  d8d5a00f3b
• Merge pull request #30838 from smoogipoo/better-room-status

  Improve multiplayer room status handling

  Bartłomiej Dach · 2024-12-12 13:05:59 +09:00
  88241d5b95
• Move BeatmapInfoWedgeV2 to correct namespace
  Dean Herbert · 2024-12-12 12:53:05 +09:00
  862b41c38e
• Merge branch 'master' into skin-mounting
  Bartłomiej Dach · 2024-12-12 12:16:22 +09:00
  09d55ed306
• Rename SkinInfo when it is changed in skin.ini

  Peppy spoke about using a shortcut and/or hashes to determine if the
  skin.ini is changed, and if so, then to rename the skin.
  
  In my opinion, hashing and doing numerous comparisons is probably less
  efficient than just syncing the SkinInfo's name during the update.
  
  This is an easy solution that does what it needs to.

  smallketchup82 · 2024-12-11 10:19:10 -05:00
  165afe357f
• Add missing mania tooltip overlay for 4k and 7k
  Nicholas Chin · 2024-12-11 23:15:05 +08:00
  26f15def70
• Adjust in line with upstream changes
  Dean Herbert · 2024-12-11 18:17:59 +09:00
  e8c0e27cc0
• Increase timed update frequency and add inline comment
  Dean Herbert · 2024-12-11 18:08:34 +09:00
  0aa17a905b
• Merge branch 'master' into better-room-status
  Dean Herbert · 2024-12-11 18:06:55 +09:00
  a3998fbd52
• Merge pull request #31076 from peppy/beatmap-store-interface

  Access beatmap store via abstract base class

  Bartłomiej Dach · 2024-12-11 17:48:32 +09:00
  4e4a99decc
• Merge branch 'master' into ios-beatmap-export
  Dean Herbert · 2024-12-10 23:59:15 -08:00
  2a4f596f90
• Merge pull request #31039 from frenzibyte/ios-temporary-export-storage

  Use temporary storage for file exports on iOS

  Dean Herbert · 2024-12-10 23:53:40 -08:00
  02c52e41bd
• Remove BeatmapCarousel testing backdoor
  Dean Herbert · 2024-12-11 16:28:51 +09:00
  a868c33380
• Access beatmap store via abstract base class

  The intention here is to make things more testable going forward.
  Specifically, to remove the "back-door" entrance into `BeatmapCarousel`
  where `BeatmapSets` can be set by tests and bypas/block realm retrieval.

  Dean Herbert · 2024-12-11 16:28:51 +09:00
  c94b393e30
• Remove no-longer-correct comment
  Dean Herbert · 2024-12-11 16:28:50 +09:00
  bab9b9c937