48098 Commits

• Select timing point on enter if no effect point is active at the time

  Noticed during testing.

  Bartłomiej Dach · 2025-02-04 12:44:05 +01:00
  2dbf30a096
• Always select the closest control point group regardless of whether it has a timing point
  Bartłomiej Dach · 2025-02-04 12:35:02 +01:00
  a0b6610054
• Fix incorrect snapping behaviour when previous object is not snapped to beat
  Bartłomiej Dach · 2025-02-04 11:45:15 +01:00
  731f100aaf
• Remove Scheduler.AddOnce from updateSpecifics

  To keep things simple, let's not bother debouncing this. The debouncing
  was causing spectating handling to fail because of two interdependent
  components binding to `BeatmapAvailability`:
  
  Binding to update the screen's `Beatmap` after a download completes:
  
  https://github.com/ppy/osu/blob/58747061171c4ebe70201dfe4d3329ed7f4343f5/osu.Game/Screens/OnlinePlay/Match/RoomSubScreen.cs#L266-L267
  
  Binding to attempt a load request:
  
  https://github.com/ppy/osu/blob/8bb7bea04e56fab9247baa59ae879e16c8b4bd9b/osu.Game/Screens/OnlinePlay/Multiplayer/MultiplayerMatchSubScreen.cs#L67
  
  The first must update the beatmap before the second runs, else gameplay
  will not load due to `Beatmap.IsDefault`.

  Dean Herbert · 2025-02-04 18:41:28 +09:00
  6c6063464a
• Add expanded state to sample drawable representations
  Dean Herbert · 2025-02-04 18:06:16 +09:00
  599b59cb14
• Watch global user presence while in spectator screen
  Dan Balasescu · 2025-02-04 17:55:50 +09:00
  2f90bb4d67
• Refactor user presence watching to be tokenised
  Dan Balasescu · 2025-02-04 17:54:03 +09:00
  61419ec9c8
• Add tracking of expansion states for groups and sets
  Dean Herbert · 2025-02-04 17:51:51 +09:00
  58560f8acf
• Implement visual appearance of beatmap submission wizard
  Bartłomiej Dach · 2025-02-04 09:06:33 +01:00
  4dd4e52e6d
• Implement "form button" control
  Bartłomiej Dach · 2025-02-04 09:05:33 +01:00
  3893303988
• Merge pull request #31764 from peppy/beatmap-carousel-v2-grouping

  Add group support to beatmap carousel v2

  Bartłomiej Dach · 2025-02-04 08:13:54 +01:00
  6e59cab928
• Merge pull request #31734 from bdach/simplify-slider-encoding-logic

  Fix multi-segment-type sliders getting mangled on legacy export

  Dean Herbert · 2025-02-04 15:08:44 +09:00
  1e1fb5476e
• Merge pull request #31776 from frenzibyte/carousel-v2-depth-ordering

  Fix depth ordering in new carousel not being relative to selected item

  Dean Herbert · 2025-02-04 13:02:21 +09:00
  ec88c5ed75
• Adjust group traversal logic to handle cases where keyboard selection redirects
  Dean Herbert · 2025-02-04 02:55:59 +09:00
  e454fa558c
• Remove redundant conditional check
  Dean Herbert · 2025-02-04 02:41:39 +09:00
  b433eef138
• Fix code quality
  Bartłomiej Dach · 2025-02-03 15:18:03 +01:00
  2d6f64e891
• Remove unused method

  Only used in test code.

  Bartłomiej Dach · 2025-02-03 14:01:51 +01:00
  df37768ff4
• Refactor IDistanceSnapProvider to accept slider velocity objects as a reference

  Method signatures are also changed to be a lot more explicit as to what
  inputs they expect.

  Bartłomiej Dach · 2025-02-03 14:00:57 +01:00
  a1185df2eb
• Refactor how grouping is performed
  Dean Herbert · 2025-02-03 20:40:52 +09:00
  c7780c9fdc
• Merge pull request #31775 from peppy/avoid-beatmap-access-beat-sync-container

  Avoid accessing `WorkingBeatmap.Beatmap` every update call

  Bartłomiej Dach · 2025-02-03 12:24:05 +01:00
  1793b8ccb4
• Merge pull request #31778 from peppy/editor-menu-mutual-exclusive

  Make distance snap settings mutually exclusive

  Bartłomiej Dach · 2025-02-03 11:58:34 +01:00
  b60a8341e4
• Tidy up WorkingBeatmap passing in ctor
  Dean Herbert · 2025-02-03 19:26:14 +09:00
  99192404f1
• Rename freestyle select screen classes for better discoverability
  Dean Herbert · 2025-02-03 19:21:21 +09:00
  8bb7bea04e
• Tidy up button construction code
  Dean Herbert · 2025-02-03 19:09:58 +09:00
  37abb1a21b
• Standardise naming to use "Freestyle" not "FreeStyle"
  Dean Herbert · 2025-02-03 19:01:59 +09:00
  444e0970d6
• Merge branch 'master' into user-panel-status
  Dean Herbert · 2025-02-03 18:31:28 +09:00
  f24716563c
• Added warning
  NecoDev · 2025-02-03 16:47:38 +08:00
  55f46e3b66
• Change menus to fade out with a slight delay so settings changes are visible

  Useful for cases like https://github.com/ppy/osu/pull/31778, where a
  change to one setting can affect another.

  Dean Herbert · 2025-02-03 17:38:17 +09:00
  df51d345c5
• Make distance snap settings mutually exclusive
  Dean Herbert · 2025-02-03 17:34:55 +09:00
  26a8fb6984
• Merge branch 'master' into fix-limit-distance-snap-to-current
  Bartłomiej Dach · 2025-02-03 08:57:27 +01:00
  ee7d281e73
• Merge pull request #31742 from smoogipoo/fix-results-persistent-sounds

  Fix results screen sounds persisting after exit

  Dean Herbert · 2025-02-03 16:39:47 +09:00
  b9f840c32e
• Apply depth ordering relative to selected item
  Salman Alshamrani · 2025-02-03 02:34:29 -05:00
  c587958f38
• Avoid accessing WorkingBeatmap.Beatmap every update call

  Notice in passing.
  
  Comes with overheads that can be easily avoided. Left a note for a
  future (slightly more involved) optimisation.

  Dean Herbert · 2025-02-03 16:30:31 +09:00
  a23de0b188
• Remove unused using
  Dan Balasescu · 2025-02-03 14:20:56 +09:00
  9033a4d480
• Play sound via results screen instead
  Dan Balasescu · 2025-02-03 14:15:46 +09:00
  210fa14759
• Fix null handling when no items are populated but a selection is made
  Dean Herbert · 2025-02-03 02:39:45 +09:00
  6a18d18feb
• Add test coverage for grouped selection
  Dean Herbert · 2025-02-03 02:39:45 +09:00
  9c34819ff4
• Simplify keyboard traversal logic
  Dean Herbert · 2025-02-03 02:24:27 +09:00
  645c26ca19
• Fix backwards traversal of groupings and allow toggling groups without updating selection
  Dean Herbert · 2025-02-03 02:24:27 +09:00
  d74939e6e9
• Improve selection flow using early exit and invalidation
  Dean Herbert · 2025-02-03 02:24:27 +09:00
  764f799dcb
• Add initial difficulty grouping support
  Dean Herbert · 2025-02-03 02:24:27 +09:00
  d5dc55149d
• Re-enable masking by default
  Dean Herbert · 2025-02-03 02:24:26 +09:00
  3cde11ab77
• Merge pull request #31747 from bdach/do-not-reset-online-info-on-save

  Do not reset online information when saving beatmap

  Dean Herbert · 2025-02-02 22:24:56 +09:00
  f65be009a3
• Merge pull request #31368 from frenzibyte/mobile-fix-mania

  Improve osu!mania playability on mobile devices

  Dean Herbert · 2025-02-01 14:49:46 +09:00
  cf3a379b1c
• Merge pull request #31733 from bdach/bss/abstract-out-wizard

  Abstract out `WizardOverlay` for multi-step wizard type screens

  Dean Herbert · 2025-02-01 14:10:35 +09:00
  334b578fb6
• Fix broken user-facing messaging when beatmap hash mismatch is detected
  Bartłomiej Dach · 2025-01-31 12:22:05 +01:00
  7ef8616703
• Do not reset online info on beatmap save
  Bartłomiej Dach · 2025-01-31 12:21:42 +01:00
  c3981f1097
• Avoid moving already placed objects temporally when "limit distance snap to current time" is active
  Bartłomiej Dach · 2025-01-31 09:51:13 +01:00
  8718483c70
• Do not double up first control point of path
  Bartłomiej Dach · 2025-01-31 09:01:42 +01:00
  20280cd195
• Fix results screen sounds persisting after exit
  Dan Balasescu · 2025-01-31 16:22:37 +09:00
  cf2d0e6911