48098 Commits

• Introduce new model for "beatmaps under grouping" & allow beatmaps to appear in multiple groups

  This bypasses the immediate first issue of not being able to display
  multiple instances of a beatmap on the carousel because of model
  equality being baked into the structure. It inevitably poses a bunch of
  *other* problems, but it's a start.

  Bartłomiej Dach · 2025-08-29 13:12:12 +02:00
  a84c364e44
• Make grouping by collections and rank achieved testable without involving realm
  Bartłomiej Dach · 2025-08-29 13:12:12 +02:00
  d304a31757
• Merge branch 'master' into online-lookups-on-reenter
  Dean Herbert · 2025-08-29 19:03:41 +09:00
  3ca5e20e70
• Merge pull request #34822 from bdach/carousel-multi-grouping-clean
  Dean Herbert · 2025-08-29 19:02:58 +09:00
  404044e8d7
• Merge pull request #34830 from minetoblend/fix/hitobject-lifetime-delay

  Fix hitobject drawables becoming visible 1 frame too late

  Dan Balasescu · 2025-08-29 18:38:24 +09:00
  d5575b4037
• Move footer to ScreenTestScene
  Dan Balasescu · 2025-08-29 17:49:48 +09:00
  04ba5aa575
• Merge branch 'master' into carousel-multi-grouping-clean
  Bartłomiej Dach · 2025-08-29 10:41:46 +02:00
  51ed19cb99
• Apply suggested rename
  Bartłomiej Dach · 2025-08-29 09:58:56 +02:00
  526ee32268
• Fix song select not performing online lookup on re-enter

  Closes https://github.com/ppy/osu/issues/34825.
  
  Root cause is
  
  	https://github.com/ppy/osu/blob/24ec43b3b65fa3b164b7713341cd62b1e0dacc2e/osu.Game/Screens/SelectV2/SongSelect.cs#L345-L356
  
  not specifying `(..., true)`, therefore the fetch doesn't happen on
  enter if song select doesn't change the global beatmap as a side effect
  of the enter, which is the case on re-entering.

  Bartłomiej Dach · 2025-08-29 09:31:20 +02:00
  df6d6edaca
• Fix obviously incorrect conditional

  Co-authored-by: Bartłomiej Dach <dach.bartlomiej@gmail.com>

  Dean Herbert · 2025-08-29 16:01:49 +09:00
  9e77a5b050
• Fix some mods showing tooltips when settings are default
  Dean Herbert · 2025-08-29 14:08:18 +09:00
  e83f3d5e77
• Return early to avoid creating mod description strings unnecessarily
  Dean Herbert · 2025-08-29 14:08:06 +09:00
  f2f5cf19a2
• Fix operations in PooledDrawableWithLifetimeContainer.CheckChildrenLife being in wrong order

  Previously CompositeDrawable.CheckChildrenLife() would be run before lifetimeManager.Update() which lead to the new drawables being inserted into the container but not being made alive immediately, leading to the drawable not becoming visibile until the next update loop.

  marvin · 2025-08-28 23:36:29 +02:00
  bb9f9e4d35
• Merge pull request #34808 from peppy/fix-difficulty-churn

  Fix beatmap carousel triggering full filters more often than it needs to

  Bartłomiej Dach · 2025-08-28 14:26:25 +02:00
  3eaa5314ac
• Support beatmap sets being split apart by the active group mode in beatmap carousel
  Bartłomiej Dach · 2025-08-28 13:09:08 +02:00
  8dd131f17e
• Ensure filtering also runs after local gameplay LastPlayed changes
  Dean Herbert · 2025-08-28 19:10:20 +09:00
  7e109add96
• Merge pull request #34740 from bdach/maximised-player-audio

  Always use audio from maximised player if there is one in multiplayer spectator

  Dean Herbert · 2025-08-28 18:27:56 +09:00
  f953d58922
• Configure await calls
  Dan Balasescu · 2025-08-28 13:47:55 +09:00
  9ae6e509b7
• Fix potential loss of room events during join
  Dan Balasescu · 2025-08-28 13:20:02 +09:00
  b95573f97d
• Preserve pre-post notification completion target
  Dan Balasescu · 2025-08-28 13:07:05 +09:00
  e831d1b6fa
• Merge branch 'master' into fix-difficulty-churn
  Dean Herbert · 2025-08-28 02:38:10 +09:00
  ed15e1fb88
• Merge pull request #34812 from bdach/failed-at-judgement

  Fix `HealthProcessor` potentially incorrectly reverting failed state

  Dean Herbert · 2025-08-28 02:37:44 +09:00
  33b99a51b1
• Fix hidden beatmap state not being reflected immediately
  Dean Herbert · 2025-08-28 02:33:18 +09:00
  8a6c857719
• Allow grouping modes that apply max aggregate to split beatmap sets apart
  Bartłomiej Dach · 2025-08-27 14:45:20 +02:00
  4030383276
• Apply in more places
  Dean Herbert · 2025-08-27 19:59:44 +09:00
  f9c1b24df4
• Fix HealthProcessor potentially incorrectly reverting failed state

  This stems from me looking into `TestSceneFailAnimation` failures
  (https://github.com/ppy/osu/runs/48663953318). As it turns out, I should
  not have been mad by CI, and rather should have been mad at myself for
  failing to read.
  
  `FailedAtJudgement` in fact does not mean "this judgement, and only this
  judgement, triggered failure". If any further judgements occur
  post-fail, they will also have `FailedAtJudgement` set to true. It is
  essentially a *dump* of the state of `HealthProcessor.Failed` prior to
  applying the judgement.
  
  	https://github.com/ppy/osu/blob/ec21685c2531af3b243f7f0833ffbb340bf3c044/osu.Game/Rulesets/Scoring/HealthProcessor.cs#L49-L57
  
  Because of this, reverting several judgements which occur post-fail
  could lead to failed state reverting earlier than intended, and thus
  potentially trigger a second fail, thus tripping the `Player` assertion.

  Bartłomiej Dach · 2025-08-27 12:27:11 +02:00
  197c318180
• Fix beatmap panels locally handling mod changes unnecessarily

  The `BeatmapDifficultyCache` handles mod changes, so handling locally is
  unnecessary. By handling locally, it creates a visual issue when
  adjusting mods often. Test using Ctrl +/- at song select and observing
  that without this change, the star rating will flicker back to the
  default due to the local re-fetch.

  Dean Herbert · 2025-08-27 18:31:50 +09:00
  fda40d7fd5
• Fix beatmap carousel re-filtering when it doesn't need to

  Local rules ensure we only handle callbacks when we need to.

  Dean Herbert · 2025-08-27 18:21:19 +09:00
  be6fb9aa77
• Avoid triggering changes when add operations are empty

  Only seems to happen in tests. I think.

  Dean Herbert · 2025-08-27 18:13:13 +09:00
  0e57ee9ba6
• Add test coverage ensuring filtering does not occur on unnecessary updates
  Dean Herbert · 2025-08-27 18:13:12 +09:00
  043235fed2
• Update framework
  Dean Herbert · 2025-08-26 21:43:09 +09:00
  244bad07c7
• Work around excessive refreshes of carousel beatmap set panel backgrounds

  Closes https://github.com/ppy/osu/issues/34511 I guess.

  Bartłomiej Dach · 2025-08-26 13:27:54 +02:00
  c0fd5637de
• Merge pull request #34801 from peppy/replay-player-null

  Fix crash on exiting `ReplayPlayer` is beatmap was not loaded successfully

  Bartłomiej Dach · 2025-08-26 12:11:27 +02:00
  5e7a99c97f
• Add test coverage and fix one more fail case
  Dean Herbert · 2025-08-26 18:41:14 +09:00
  2ccb65aa65
• Fix crash on exiting ReplayPlayer is beatmap was not loaded successfully

  Closes https://github.com/ppy/osu/issues/34763.

  Dean Herbert · 2025-08-26 18:31:42 +09:00
  4d851f2527
• Apply NRT to ReplayPlayer for good measure
  Dean Herbert · 2025-08-26 18:30:12 +09:00
  4bafbfb9e4
• Sort scores immediately for good measure
  Dean Herbert · 2025-08-26 17:51:14 +09:00
  3f179e3903
• Fix playlist leaderboard provider potentially inserting local user in wrong order

  Due to `Perform` being used from a BDL method in conjunction with
  `Success` (which is scheduled to the *update* thread), there was a
  chance that the order of execution would be not quite as intended.
  
  To rectify, let's not use `Success` and just continue with synchronous
  flow.

  Dean Herbert · 2025-08-26 17:51:02 +09:00
  196b28115e
• Fix copy-paste fail in log message
  Bartłomiej Dach · 2025-08-25 13:43:03 +02:00
  a2bf8e3988
• Merge pull request #34761 from frenzibyte/fix-flashlight

  Fix flashlight not always matching gameplay scaling

  Bartłomiej Dach · 2025-08-25 12:03:58 +02:00
  6e8246b539
• Fix xmldoc error and reword
  Salman Alshamrani · 2025-08-24 18:55:45 +03:00
  3cca458c21
• Fix flashlight not handling internal playfield sizing changes

  Note that this does not handle sizing/scaling changes applied directly
  to `Playfield`, but it handles any changes within the layers inside
  `PlayfieldAdjustmentContainer`.

  Salman Alshamrani · 2025-08-24 17:51:05 +03:00
  bc59270f3e
• Merge pull request #34766 from bdach/remove-double-lookup

  Pull up online beatmap set lookup to song select level to avoid two components doing the same fetch independently

  Dean Herbert · 2025-08-23 20:50:17 +09:00
  16343fd7d6
• Merge pull request #34757 from bdach/new-mod-icons

  Update mod icons

  Dean Herbert · 2025-08-23 19:55:10 +09:00
  acafc06bcc
• Fix song select favourite button potentially showing stale data from (un)favourite request callback
  Bartłomiej Dach · 2025-08-22 14:25:25 +02:00
  5292d4a04e
• Pull up online beatmap set lookup to song select level to avoid two components doing the same fetch independently
  Bartłomiej Dach · 2025-08-22 14:25:21 +02:00
  d3ae20dd88
• Merge pull request #34723 from bdach/status-updates-are-great-arent-they

  Refresh realm before performing song select refetches following an online metadata lookup

  Dean Herbert · 2025-08-22 20:25:36 +09:00
  c852e5854c
• Update tests
  Bartłomiej Dach · 2025-08-22 12:44:08 +02:00
  03e7e2b0d8
• Add indicator for pinned rooms in upper right of room panel
  Bartłomiej Dach · 2025-08-22 10:17:15 +02:00
  20b316d32d
• Fix flashlight not correctly scaled to match playfield
  Salman Alshamrani · 2025-08-21 19:03:43 +03:00
  a049f5065d