mirror of
https://github.com/ppy/osu.git
synced 2026-05-23 18:19:53 +08:00
Fix beatmap panels locally handling mod changes unnecessarily
The `BeatmapDifficultyCache` handles mod changes, so handling locally is unnecessary. By handling locally, it creates a visual issue when adjusting mods often. Test using Ctrl +/- at song select and observing that without this change, the star rating will flicker back to the default due to the local re-fetch.
This commit is contained in:
@@ -205,11 +205,7 @@ namespace osu.Game.Screens.SelectV2
|
||||
updateKeyCount();
|
||||
});
|
||||
|
||||
mods.BindValueChanged(_ =>
|
||||
{
|
||||
computeStarRating();
|
||||
updateKeyCount();
|
||||
}, true);
|
||||
mods.BindValueChanged(_ => updateKeyCount(), true);
|
||||
}
|
||||
|
||||
protected override void PrepareForUse()
|
||||
|
||||
Reference in New Issue
Block a user