From fda40d7fd5a3f5657e6c495202ee23719ebb1890 Mon Sep 17 00:00:00 2001 From: Dean Herbert Date: Wed, 27 Aug 2025 18:31:27 +0900 Subject: [PATCH] Fix beatmap panels locally handling mod changes unnecessarily The `BeatmapDifficultyCache` handles mod changes, so handling locally is unnecessary. By handling locally, it creates a visual issue when adjusting mods often. Test using Ctrl +/- at song select and observing that without this change, the star rating will flicker back to the default due to the local re-fetch. --- osu.Game/Screens/SelectV2/PanelBeatmap.cs | 6 +----- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/osu.Game/Screens/SelectV2/PanelBeatmap.cs b/osu.Game/Screens/SelectV2/PanelBeatmap.cs index d91864ed95..2475e32a39 100644 --- a/osu.Game/Screens/SelectV2/PanelBeatmap.cs +++ b/osu.Game/Screens/SelectV2/PanelBeatmap.cs @@ -205,11 +205,7 @@ namespace osu.Game.Screens.SelectV2 updateKeyCount(); }); - mods.BindValueChanged(_ => - { - computeStarRating(); - updateKeyCount(); - }, true); + mods.BindValueChanged(_ => updateKeyCount(), true); } protected override void PrepareForUse()