48098 Commits

• Merge pull request #34657 from peppy/audio-hotfix-aaaaaaaaaaaa

  Ignore more potentially incorrect data from BASS

  Bartłomiej Dach · 2025-08-15 11:05:52 +02:00
  6f733fd3fc
• Rename variables
  Bartłomiej Dach · 2025-08-15 10:21:50 +02:00
  5722e85791
• Merge pull request #34533 from AeroKoder/user-avatar-notification

  Made the user avatar square, in `UserAvatarNotification`.

  Dean Herbert · 2025-08-15 16:05:00 +09:00
  6ed7ba350d
• Merge pull request #33558 from frenzibyte/ssv2-crash

  Fix song select crashing on beatmap with two difficulties of same online ID

  Bartłomiej Dach · 2025-08-15 08:50:51 +02:00
  0e5900add9
• Fix half written comment and adjust threshold down slightly
  Dean Herbert · 2025-08-15 15:40:30 +09:00
  1f10bff7a7
• Don't enforce hotfix during debug builds, to allow interactive tests to run correctly
  Dean Herbert · 2025-08-15 15:29:51 +09:00
  69647f4c9c
• exclude all beatmap audios from the check

  - prevents false positives on maps with multiple audios

  Hivie · 2025-08-15 00:11:16 +01:00
  7b455efe34
• add check for inconsistent audio usage
  Hivie · 2025-08-15 00:08:55 +01:00
  148bc4ac34
• Merge pull request #34659 from bdach/bss-submission-double-bind

  Fix navigating back and forth from beatmap submission settings screen crashing

  Dean Herbert · 2025-08-15 02:45:37 +09:00
  4bb5509267
• Merge pull request #34640 from bdach/multiple-tag-filters

  Add support for specifying multiple user tag filters at once

  Dean Herbert · 2025-08-15 02:39:47 +09:00
  734043fb0d
• Merge branch 'master' into bss-submission-double-bind
  Salman Alshamrani · 2025-08-14 17:20:51 +03:00
  28c9a62634
• Refetch leaderboard when (slow) retrying a beatmap

  Probably closes https://github.com/ppy/osu/issues/34645.
  
  Obviously this is only good if the score has managed to process online
  and slot into a leaderboard before the user requested a retry. I can't
  make miracles happen.
  
  Notably this is not applied to quick retry, because it would make quick
  retry slower, and the presumption is that if the user is quick-retrying
  their last score is likely useless for global leaderboards anyway. (The
  one exception to that last part is possibly quick-retrying from results
  screen, which is a flow that we have, but maybe fine to ignore it...?)

  Bartłomiej Dach · 2025-08-14 14:31:49 +02:00
  44e76a61a9
• handle pairwise comparison for video start times
  Hivie · 2025-08-14 13:14:58 +01:00
  f928f9953b
• Also ensure that ordering doesn't matter
  Dean Herbert · 2025-08-14 21:14:35 +09:00
  7a1cad7312
• Merge branch 'master' into ssv2-crash
  Salman Alshamrani · 2025-08-14 14:09:54 +03:00
  347d621437
• Fix navigating back and forth from beatmap submission settings screen crashing

  supersedes https://github.com/ppy/osu/pull/34656

  Bartłomiej Dach · 2025-08-14 12:57:10 +02:00
  3bfa7bf862
• Fix current change check not solid enough
  Salman Alshamrani · 2025-08-14 13:48:08 +03:00
  76630cff98
• Fix calibrating offset with auto-adjust enabled does not account for UR

  Covered by test `TestAutomaticAdjustmentWithUnstableRate`.

  Salman Alshamrani · 2025-08-14 13:48:08 +03:00
  de7e3c96a6
• Move beatmap offset write logic to a separate method

  Note that calling `writeOffsetToBeatmap` from `currentChanged` is still intentionally not
  scheduled, see https://github.com/ppy/osu/pull/34612#discussion_r2269052138.
  
  This commit is done so that if that call is scheduled, then the logic
  above it that update the play graph and visibility state of the button
  still don't get scheduled, otherwise the test will fail (as noticed in https://github.com/ppy/osu/pull/34612#discussion_r2269208998).

  Salman Alshamrani · 2025-08-14 13:48:08 +03:00
  1db49d250f
• Fix tags popover search functionality not always working

  This is super haphazard in the first place but I'm going to look past
  that for now.
  
  Basically, due to the order of operation, the tags could be initialised
  via `updateTags()` before the perform search action was initialised,
  leading to clicks doing nothing.

  Dean Herbert · 2025-08-14 19:43:03 +09:00
  6c4c2c1a6a
• Ignore more potentially incorrect data from BASS

  This is still a workaround but arguably it's something we could leave in
  place without much loss. I think this at least feels better than the
  previous code.
  
  Notably, you could argue the test coverage of the fail case is lower
  since made it implicit that all tests will avoid the "backwards seek"
  detections.  But we never really had tests correctly- fail on the original
  so I don't see any loss of value.

  Dean Herbert · 2025-08-14 19:20:30 +09:00
  82906300b4
• Remove TODO comment
  Salman Alshamrani · 2025-08-14 12:38:04 +03:00
  693c39c23b
• Merge branch 'master' into multiple-tag-filters
  Salman Alshamrani · 2025-08-14 12:32:32 +03:00
  032c81a21e
• Merge branch 'master' into difficulty-range-from-non-expired
  Salman Alshamrani · 2025-08-14 10:21:03 +03:00
  bbc1509cd1
• add verify check for video usage
  Hivie · 2025-08-13 20:26:46 +01:00
  e52a4638fe
• add util for getting storyboard video of a difficulty
  Hivie · 2025-08-13 20:26:26 +01:00
  79fcd045b3
• Merge pull request #34644 from smoogipoo/fix-status-icon-colour

  Fix incorrect status colour for DnD users

  Dean Herbert · 2025-08-14 02:44:28 +09:00
  5469357b23
• Merge pull request #34584 from Hiviexd/verify/refactor-verifier-context

  Refactor `BeatmapVerifierContext`

  Dean Herbert · 2025-08-14 02:28:57 +09:00
  75c72b150e
• Fix incorrect status colour for DnD users
  Dan Balasescu · 2025-08-13 19:50:30 +09:00
  47022d23f1
• Clean up ctors

  There were too many of them, and they were a bit twisty for my liking.

  Bartłomiej Dach · 2025-08-13 12:32:17 +02:00
  19f28813a0
• Expand xmldoc
  Bartłomiej Dach · 2025-08-13 12:24:40 +02:00
  076d6df78e
• Simplify multi-valued not-equal enum filter implementation (and cover with tests)
  Bartłomiej Dach · 2025-08-13 11:54:52 +02:00
  0475fe3215
• Limit leaderboard size to sane minimum values
  Salman Alshamrani · 2025-08-13 12:52:08 +03:00
  a3443f76be
• Fix leaderboard not resizing correctly
  Salman Alshamrani · 2025-08-13 12:51:51 +03:00
  d998847271
• Improve xmldoc
  Bartłomiej Dach · 2025-08-13 11:50:35 +02:00
  844704212d
• Refactor string filter not-equal implementation to not make my eyes bleed
  Bartłomiej Dach · 2025-08-13 11:45:56 +02:00
  da69cdfa2a
• Reduce code duplication
  Bartłomiej Dach · 2025-08-13 11:42:26 +02:00
  b356e3bee3
• Fix date range filter being inexplicably implemented a little different than the equality filter

  Why???

  Bartłomiej Dach · 2025-08-13 11:35:38 +02:00
  7a2b032b00
• Fix FilterCriteria only being able to support one tag filter at once

  Other textual keyword filters also worked like that, wherein if you did
  `artist=a artist=b` the second filter would overwrite the second, but in
  those cases the query is against a single field, so attempting to put
  multiple search criteria in conjunction on a single field is kind of
  nonsensical, so it was sort of fine to do that.
  
  Which is not the case for user tags, which are multi-valued.

  Bartłomiej Dach · 2025-08-13 10:24:54 +02:00
  3fb1880466
• Fix keyword filters potentially being wrongly merged together due to regex wildcard greedy matching

  Because of greedy matching, a filter of
  
      tag="style/clean"! tag="song representation/simple"!
  
  would not parse into 2 separate filters like
  
      (tag, =, "style/clean"!)
      (tag, =, "song representation/simple"!)
  
  but rather a single one like
  
      (tag, =, "style/clean"! tag="song representation/simple"!)
  
  This sort of matches what web did in
  https://github.com/ppy/osu-web/pull/12044, except web does some stuff
  with quote escaping that I'd rather not, and also the search syntax
  seems to slightly deviate because web seems to be using single quotes
  and double quotes to open the value part of the filter. I'm not sure
  what the difference is and I'd rather not go into all that right now.

  Bartłomiej Dach · 2025-08-13 10:21:10 +02:00
  08a0025e31
• Calculate multiplayer room difficulty range based only on non-expired items

  Previously (https://github.com/ppy/osu/pull/34464) this was based on
  room status, but in review of the web-side change it was pointed out
  that even an open room could have no active items
  (https://github.com/ppy/osu-web/pull/12325#pullrequestreview-3082894354).

  Bartłomiej Dach · 2025-08-13 09:32:50 +02:00
  aa88d90eb2
• Fix code quality

  Fix code quality 2
  
  code quality fix 3
  
  Fix code quality 4
  
  Add empty line

  Valerus9 · 2025-08-13 14:59:29 +09:00
  bd90ef1bf4
• Add tests coverage for filters with not equal
  Valerus9 · 2025-08-13 14:59:20 +09:00
  997b8a0bba
• Simplify logic of IsInRange()
  Valerus9 · 2025-08-13 14:59:20 +09:00
  cc970ffd80
• Rename ExludeIfInRange to InvertRange, add xmldox to InvertRange
  Valerus9 · 2025-08-13 14:59:19 +09:00
  3a78cfc627
• Implement not equal operator

  Added blank lines

  Valerus9 · 2025-08-13 14:59:19 +09:00
  3162478172
• Merge pull request #34625 from peppy/fix-song-select-event-feedback

  Fix selection being finalised immediately on beatmap updates arriving

  Bartłomiej Dach · 2025-08-12 14:57:01 +02:00
  734dea1be4
• Add rudimentary support of rewinding failed state to health processor

  As indicated in the inline comment this is very best effort, just to
  make the HP bar not very obviously stuck in a very obviously incorrect
  state after the replay is rewound from a failure. There's likely to be a
  bunch of replay accuracy issues related to this, but I'm just making the
  minimum effort to get this to work semi-acceptably for now.

  Bartłomiej Dach · 2025-08-12 14:26:00 +02:00
  30857de55e
• Show indicator in replay player once replay fails

  This indicator allows the player to either rewind to an earlier part of
  the replay, or to proceed to results. It also plays a shortened variant
  of the failure animation SFX.

  Bartłomiej Dach · 2025-08-12 14:25:58 +02:00
  35a472ae39
• Refactor fail management to be more centralised

  Before this commit, there was `AllowFailAnimation` (used by multiplayer)
  and `OnFail()` (used by score submitting implementations of player to
  ensure a failed play submits).
  
  The former is replaced by `PerformFail()` which allows for arbitrary
  operations on failure, which replay player shall leverage in subsequent
  commits. The latter would ideally be replaced by nothing, but it's
  placed in a very awkward place behind a schedule, so by force of
  necessity to avoid code duplication it's replaced by
  `ConcludeFailedScore()` which is overridden to submit the score in all
  submitting players --- except for multiplayer, which is never supposed
  to be calling it, so in that case it just throws an exception.

  Bartłomiej Dach · 2025-08-12 14:18:48 +02:00
  85d48f5df6