53 Commits

• Use sb element path as a name
  Andrei Zavatski · 2024-05-25 13:24:25 +03:00
  1e90e5e38e
• Fix storyboard animations stripping path directory on skin lookup
  Salman Ahmed · 2024-01-17 18:39:48 +03:00
  5597b48882
• Merge branch 'master' into fix-storyboard-skin-textures-lookup
  Dean Herbert · 2023-09-27 17:17:51 +09:00
  a7237e48aa
• Merge branch 'master' into limit-gameplay-sprite-dimensions
  Dean Herbert · 2023-09-26 16:40:32 +09:00
  990c54519b
• Apply same fix to DrawableStoryboardAnimation
  Dean Herbert · 2023-09-20 12:54:36 +09:00
  b5e64d933c
• Refactor storyboard resource lookup to be more streamlined
  Dean Herbert · 2023-09-14 16:15:50 +09:00
  900376b662
• Add support for limiting skin texture/animation dimensions
  Salman Ahmed · 2023-09-03 02:21:47 +03:00
  6674c70280
• Change IBeatSyncProvider.Clock to always be non-null
  Dean Herbert · 2023-07-13 22:13:40 +09:00
  20e4e2581a
• Actually use new end time property when setting lifetimes
  Dean Herbert · 2023-04-26 13:28:51 +09:00
  1efc78c0f8
• Fix some more inspections
  Dean Herbert · 2022-12-16 20:21:19 +09:00
  192536643c
• Partial everything
  Dan Balasescu · 2022-11-27 00:00:27 +09:00
  7bc8908ca9
• Remove null conditional
  Salman Ahmed · 2022-09-23 17:06:55 +03:00
  835cae3087
• Fix crash when storyboard attempts to play at main menu
  Dean Herbert · 2022-09-23 20:10:57 +09:00
  4e9053b099
• Fix storyboard animations not starting their animation playback from the correct point in time
  Dean Herbert · 2022-09-12 14:05:16 +09:00
  24138b65a7
• Fix VectorScale set to 0 still showing some sprites in storyboard

  This implementation was matching the [framework side implementation of
  scale](https://github.com/ppy/osu-framework/blob/16d1c2d3356b0f59271fb49cff5fe8373ae9cdf3/osu.Framework/Graphics/Drawable.cs#L973-L976)
  but I don't think it's required here.
  
  I'm still not sure if the framework implementation is correct, but
  removing it locally does seem to fix broken storyboard cases.
  
  Closes https://github.com/ppy/osu/issues/20155.

  Dean Herbert · 2022-09-07 15:39:19 +09:00
  824e68dab3
• Automated #nullable processing
  Dan Balasescu · 2022-06-17 16:37:17 +09:00
  f8830c6850
• Add null check guards to unsubscriptions in Dispose()
  Bartłomiej Dach · 2022-04-07 21:37:42 +02:00
  71c0216c55
• Change DrawableStoryboardAnimation to derive from TextureAnimation
  Dean Herbert · 2022-04-07 17:35:59 +09:00
  040afff670
• Fix DrawableStoryboardAnimation to handle skin fallback frame count similar to stable

  Reasoning is explained in the inline comment (basically, stable doesn't
  care what the user specifies as the frame count when falling back to
  skin resources).
  
  This change also removes on to two layers of drawables, which should be
  a win in heavy storyboards.

  Dean Herbert · 2022-04-07 17:35:56 +09:00
  cbc4e5319d
• Fix DrawableStoryboardAnimation not specifying sizing correctly

  Usually this would be handled by `TextureAnimation`, but because we are
  inheriting from `DrawableAnimation` here for reasons, we needed to
  implement this ourselves. Follows the implementation in
  `TextureAnimation`.

  Dean Herbert · 2022-04-07 15:18:55 +09:00
  a7e262627f
• Update DrawableStoryboardSprite to use helper method
  Salman Ahmed · 2022-03-14 06:30:54 +03:00
  c1697c7621
• Share origin adjustment logic between storyboard sprite and animation
  Salman Ahmed · 2022-03-14 05:44:34 +03:00
  740a72e16d
• Update HasFlag usages to HasFlagFast
  smoogipoo · 2021-02-25 15:38:56 +09:00
  dff1d80f39
• Remove redundant class name qualifier
  Bartłomiej Dach · 2020-11-10 12:20:49 +01:00
  61093030ee
• Rename variables
  Bartłomiej Dach · 2020-11-10 12:20:26 +01:00
  ce837eaba0
• Rewrite - Add empty drawable whenever sprite not found
  cadon0 · 2020-11-10 23:52:37 +13:00
  539806e9d6
• Fix paths for storyboard animation sprites
  cadon0 · 2020-11-10 23:52:37 +13:00
  6446074976
• Centralise and share logic for storyboard frame lookup method
  Dean Herbert · 2020-10-23 15:34:00 +09:00
  1b84402b96
• Utilise UseSkinSprites value in storyboard sprite logic
  Bartłomiej Dach · 2020-10-20 23:01:25 +02:00
  58a54c5b6c
• Use SkinnableSprite to avoid unnecessary reloads
  Bartłomiej Dach · 2020-10-20 22:49:56 +02:00
  e54836a63e
• Allow storyboard animations to load textures from skins
  Sebastian Krajewski · 2020-10-09 18:02:21 +02:00
  f41fc71e42
• Update usages of Animation and Video in line with framework changes
  Dean Herbert · 2020-04-03 16:00:06 +09:00
  51db361c32
• Enforce using get-only auto property where possible
  Dean Herbert · 2020-01-20 13:50:27 +09:00
  cd5290b030
• Update MathUtils namespace usages
  smoogipoo · 2020-01-09 13:43:44 +09:00
  91735ff367
• Fix storyboard flipping potentially not having an effect (#7260)

  Fix storyboard flipping potentially not having an effect

  Dean Herbert · 2019-12-18 17:48:41 +09:00
  69f888fc49
• Fix storyboard flipping potentially not having an effect
  smoogipoo · 2019-12-18 17:27:13 +09:00
  5aca523d35
• Fix storyboard vectorscale and scale cross-pollution
  smoogipoo · 2019-12-18 17:21:38 +09:00
  602ce698d5
• CA1309: compare strings correctly.
  Huo Yaoyuan · 2019-12-17 13:00:15 +08:00
  caf3f774ba
• Reduce unnecessary allocations
  smoogipoo · 2019-05-14 13:04:49 +09:00
  93b26cd026
• Apply newline additions
  Dean Herbert · 2019-04-01 12:16:32 +09:00
  612db31c38
• Fix remaining issues
  Dean Herbert · 2019-02-28 13:31:40 +09:00
  26d53d06a9
• Adjust namespaces
  smoogipoo · 2019-02-21 19:05:52 +09:00
  d8c55bc729
• Use leased bindables
  Dean Herbert · 2019-02-01 16:44:06 +09:00
  ca5c8d37d1
• Update licence header (and remove year)
  Dean Herbert · 2019-01-24 17:43:03 +09:00
  8617aaa2a7
• Use Find instead of FirstOrDefault
  Roman Kapustin · 2019-01-05 19:35:33 +03:00
  4b5fc85875
• OpenTK -> osuTK
  smoogipoo · 2018-11-20 17:14:59 +09:00
  f27bd3ef3e
• Rename GameBeatmap -> BindableBeatmap
  smoogipoo · 2018-06-06 20:16:20 +09:00
  72cc53aded
• Privatise the OsuGame beatmap, add local beatmap to OsuTestCase
  smoogipoo · 2018-05-23 17:38:02 +09:00
  8004b8af4d
• Normalize all the line endings
  Dean Herbert · 2018-04-13 18:26:38 +09:00
  32a74f95a5
• Add rewind support for storyboards
  Dean Herbert · 2018-03-04 01:48:31 +09:00
  659578e8fa