68 Commits

• Extract helper method for retrieving all user local scores
  Bartłomiej Dach · 2025-09-03 12:05:02 +02:00
  0bbad3e1cd
• Address review comments
  Tom Martin · 2025-06-11 04:34:13 +01:00
  33905f2e70
• Always allow a map's user-tags to be read
  Tom Martin · 2025-06-07 22:51:13 +01:00
  934e529eca
• Close popovers on hiding the statistics view

  Now that the tagging popover is back,
  https://github.com/ppy/osu/issues/32630 actually needs fixing.

  Bartłomiej Dach · 2025-04-07 14:48:26 +02:00
  11e48f9f8e
• Allow tagging already played beatmaps without playing another time

  Addresses
  https://github.com/ppy/osu/discussions/32568#discussioncomment-12610577.
  
  No changes in criteria (yet?), just allowing locally imported plays to
  count the same way as full beatmap completion does.
  
  The test scene is a bit rough / semi-manual but dealing with score
  imports is a bit of a pain in general. The way to semi-manually test
  with the test scene is to import a subset of scores, then recreate the
  statistics panel, and observe behaviour. I'm not sure it's worth it to
  be putting subscriptions in there, so the full recreation of the panel
  is necessary.

  Bartłomiej Dach · 2025-03-25 14:16:26 +01:00
  40d20f4e10
• Use better copy when preventing beatmap tagging after they've been played converted
  Bartłomiej Dach · 2025-03-20 10:42:18 +01:00
  a4e2b87bdd
• Disallow tagging beatmaps when playing as convert
  Dean Herbert · 2025-03-20 16:38:37 +09:00
  51c4e073d1
• Require high enough score rank for tagging beatmap
  Bartłomiej Dach · 2025-03-13 10:17:27 +01:00
  5b1a4c8ed1
• Simplify boolean flags
  Bartłomiej Dach · 2025-03-13 10:17:27 +01:00
  f78e371b1b
• Fix xmldoc
  Bartłomiej Dach · 2025-03-12 12:38:55 +01:00
  73fba15adf
• Add user tag control to results screen's statistics panel
  Bartłomiej Dach · 2025-03-12 12:19:21 +01:00
  d1ce64b3f6
• Remove inheritance in StatisticsPanel
  Bartłomiej Dach · 2025-03-12 12:17:38 +01:00
  5f0451eb79
• Apply NRT to StatisticsPanel
  Bartłomiej Dach · 2024-05-14 15:19:46 +02:00
  10a8e84046
• Fix differing anchor specs on statistics panel flow items
  Bartłomiej Dach · 2023-07-13 20:00:29 +02:00
  20bde40ce2
• Disable masking on inner scroll container
  Dean Herbert · 2023-07-13 19:01:59 +09:00
  2c27b17c85
• Rename StatisticContainer to StatisticItemContainer and add a background
  Dean Herbert · 2023-07-13 18:59:11 +09:00
  e34839c891
• Remove more GridContainer nonsense
  Dean Herbert · 2023-07-13 18:30:57 +09:00
  98bf15182e
• Adjust results screen transition tweens to feel better
  Dean Herbert · 2023-07-07 17:39:54 +09:00
  82babbf8fa
• Simplify column dimensions code

  `dimensions` would always receive exactly one item, so might as well
  inline it.
  
  And yes, at this point the grid container is mostly a glorified
  `FillFlowContainer { Direction = FlowDirection.Vertical }`, but I am not
  touching that in this pull pending further decisions with respect to
  direction.

  Bartłomiej Dach · 2023-06-03 19:40:01 +02:00
  602d5db3bb
• Return StatisticItems rather than StatisticRows from ruleset

  There were no usages of more than one column being provided per row, so
  it seemed like unnecessarily complexity. I'm currently trying to reduce
  complexity so we can improve the layout of the results screen, which
  currently has up to three levels of nested `GridContainer`s.
  
  Of note, I can't add backwards compatibility because the method
  signature has not changed in `Ruleset` (only the return type). If we do
  want to keep compatibility with other rulesets, we could designate a new
  name for the updated method.

  Dean Herbert · 2023-06-01 14:35:15 +09:00
  985604fab5
• Remove unused Dimension specification from StatisticItem
  Dean Herbert · 2023-06-01 14:25:18 +09:00
  dc595b83f1
• Add protected method for customising statistics panel rows
  Bartłomiej Dach · 2022-12-24 14:35:00 +01:00
  3abdf557ea
• Partial everything
  Dan Balasescu · 2022-11-27 00:00:27 +09:00
  7bc8908ca9
• Avoid potential realm fetch after disposal in StatisticsPanel

  As seen at https://github.com/ppy/osu/runs/7513799859?check_suite_focus=true.

  Dean Herbert · 2022-07-26 15:12:23 +09:00
  99bdf41717
• Add panel appearance sounds
  Jamie Taylor · 2022-07-22 21:03:46 +09:00
  6ce8e74e6b
• Update parameter discards
  Dean Herbert · 2022-06-24 21:26:19 +09:00
  31a447fda0
• Automated #nullable processing
  Dan Balasescu · 2022-06-17 16:37:17 +09:00
  f8830c6850
• Remove weird panelIsComplete flag and replace LINQ with simple foreach
  Dean Herbert · 2022-02-03 19:00:03 +09:00
  6974c2d255
• Refactor populateStatistics to avoid disposing
  Henry Lin · 2022-02-03 11:52:37 +08:00
  aff36d4e16
• Don't prompt for a replay if no item requires hit events
  Henry Lin · 2022-02-02 19:07:14 +08:00
  3c2a6fe208
• Use spacing instead of bottom margin
  Henry Lin · 2022-02-02 19:02:29 +08:00
  1e19c7046a
• Also dispose rows
  Henry Lin · 2022-02-02 19:00:46 +08:00
  b0023b9809
• Dispose container before replacing
  Henry Lin · 2022-02-02 17:32:16 +08:00
  36bfef4f54
• Remove useless null checks
  Henry Lin · 2022-02-02 17:26:17 +08:00
  90e30bc9e8
• Add scrolling to the extended statistics panel
  Henry Lin · 2022-02-02 17:20:22 +08:00
  5e3d124eef
• Update statistics item display logic
  Henry Lin · 2022-02-02 13:41:51 +08:00
  3ba5d88914
• Lazily create content of StatisticItem
  Henry Lin · 2022-02-02 13:29:18 +08:00
  c5c4c85006
• Fix CI reported warnings
  Dean Herbert · 2022-01-12 22:39:00 +09:00
  51251e3204
• more fixes (almost compiles, except ruleset and manager)
  Dean Herbert · 2022-01-12 16:57:27 +09:00
  53792811b2
• Move spinner hiding before newScore null check
  Joseph Madamba · 2021-11-07 19:35:30 -08:00
  9e13c20bd4
• Fix loading spinner potentially showing on statistics unavailable message
  Joseph Madamba · 2021-11-07 17:25:33 -08:00
  ac5d9853d3
• Rename last remaining BeatmapInfo Beatmap usage
  Dean Herbert · 2021-10-04 17:35:53 +09:00
  853cf6feaa
• Merge pull request #10224 from peppy/results-statistics-replay-button

  Add more descriptive description and download button when statistics not available

  Dan Balasescu · 2020-09-24 14:31:38 +09:00
  02d8355321
• Fix braces style
  Dean Herbert · 2020-09-24 12:39:08 +09:00
  fda6e88dd3
• Fix extended statistics not being vertically centered
  Dean Herbert · 2020-09-24 12:21:46 +09:00
  cb903ec9e2
• Add more descriptive description and download button when statistics not available
  Dean Herbert · 2020-09-24 12:21:08 +09:00
  f4d2c2684d
• Reapply lost anchoring fix
  Bartłomiej Dach · 2020-08-27 20:51:28 +02:00
  6846a245f4
• Revert IStatisticRow changes
  Bartłomiej Dach · 2020-08-27 20:13:44 +02:00
  f152e1b924
• Add fade to prevent jarring transitions
  Bartłomiej Dach · 2020-08-26 22:34:28 +02:00
  f8042e6fd3
• Move out row anchor/origin set to one central place
  Bartłomiej Dach · 2020-08-26 22:34:27 +02:00
  d81d538b7e