41 Commits

• Fix player settings overlay potentially disappearing unexpectedly

  Closes https://github.com/ppy/osu/issues/33793.
  
  Can be tested with this diff:
  
  ```diff
  diff --git a/osu.Game/Screens/Play/HUD/PlayerSettingsOverlay.cs
  b/osu.Game/Screens/Play/HUD/PlayerSettingsOverlay.cs
  index 635d140a4a..b3a827b699 100644
  --- a/osu.Game/Screens/Play/HUD/PlayerSettingsOverlay.cs
  +++ b/osu.Game/Screens/Play/HUD/PlayerSettingsOverlay.cs
  @@ -60,6 +60,8 @@ public PlayerSettingsOverlay()
               Origin = Anchor.TopRight;
               Anchor = Anchor.TopRight;
  
  +            X = 0.01f;
  +
               base.Content.Add(content = new FillFlowContainer
               {
                   AutoSizeAxes = Axes.Both,
  
  ```

  Dean Herbert · 2025-06-24 15:37:32 +09:00
  c0a51da110
• Fix settings in replay hiding when dragging a slider
  Rudi Herouard · 2025-01-20 13:43:45 +01:00
  89586d5ab2
• Merge pull request #31106 from peppy/player-settings-fix-overlap-skins

  Fix player settings overlay cog overlapping skin elements

  Dan Balasescu · 2024-12-13 19:30:39 +09:00
  35c70ceb18
• Add note about player settings overlay button
  Dean Herbert · 2024-12-13 18:58:20 +09:00
  4b0cdd761d
• Fix player settings overlay cog overlapping skin elements

  This brings it down to be in line with the flowing elements that usually
  do their best to not get in the way.
  
  Decided against putting it in the `HUDOverlay` flow for simplicity. It
  will work fine until it doesn't.

  Dean Herbert · 2024-12-13 17:28:15 +09:00
  a796af9511
• Fix player settings overlay appearing while in skin editor
  Dean Herbert · 2024-12-13 17:18:34 +09:00
  1e809c7f16
• Fix settings showing up during gameplay
  Dean Herbert · 2024-12-01 18:44:26 +09:00
  6afe083ec9
• Combine new implementation back into the old one and use everywhere
  Dean Herbert · 2024-11-27 17:47:42 +09:00
  0f73941808
• Make PlayerSettingsOverlay's api more stringent
  Dean Herbert · 2024-01-17 15:13:59 +09:00
  e7732caaf7
• Move load procedure to async method and simplify code
  Dean Herbert · 2024-01-17 15:02:42 +09:00
  42f64c2c44
• move creation of PlaybackSettings to ReplayPlayer
  Nitrous · 2024-01-12 15:12:02 +08:00
  c404628113
• Remember state of replay settings visibility
  Dean Herbert · 2023-07-06 00:53:37 +09:00
  95a9b532df
• Remove not-yet-implemented settings group comments
  Dean Herbert · 2023-07-06 00:46:09 +09:00
  fbab5acac1
• Automated pass
  Dean Herbert · 2023-06-24 01:00:03 +09:00
  0ab0c52ad5
• Fix audio settings not displaying while watching a replay
  Dean Herbert · 2023-06-09 17:58:44 +09:00
  c2663f27a1
• Merge branch 'master' into replay-menu-expanded-state-memory
  Dean Herbert · 2023-01-17 14:30:23 +09:00
  6a0bf89401
• make PlayerSettingsGroup expand on hover
  integer · 2023-01-13 23:07:59 +00:00
  c3c1d77e8e
• revert additions to SessionStatics
  integer · 2023-01-13 23:07:21 +00:00
  0b5c89d01f
• replay menus remembers expanded state

  no messing with readonly fields

  integer · 2022-12-27 00:13:46 +00:00
  a0690e7ffb
• Partial everything
  Dan Balasescu · 2022-11-27 00:00:27 +09:00
  7bc8908ca9
• Automated #nullable processing
  Dan Balasescu · 2022-06-17 16:37:17 +09:00
  f8830c6850
• Add IExpandable support for SettingsToolboxGroup
  Salman Ahmed · 2022-01-23 05:41:16 +03:00
  326f12f847
• Align top-right elements with lowest point in score display
  Dean Herbert · 2020-10-15 17:14:42 +09:00
  d8d085ede9
• Add spaces to comments
  alex · 2020-05-04 18:36:24 -07:00
  0e2ccac33b
• Fix PlayerSettingsOverlay being shown by default
  Dean Herbert · 2019-10-28 18:37:58 +09:00
  46b44f4f99
• Update VisibilityContainer usage in line with framework
  Dean Herbert · 2019-06-11 15:13:58 +09:00
  609a82bc94
• Move all clock related gameplay logic inside GameplayClockContainer
  Dean Herbert · 2019-03-07 16:02:24 +09:00
  58ef397f4f
• Fix remaining issues
  Dean Herbert · 2019-02-28 13:31:40 +09:00
  26d53d06a9
• Update licence header (and remove year)
  Dean Herbert · 2019-01-24 17:43:03 +09:00
  8617aaa2a7
• Update PlayerSettingsOverlay.cs

  Framework renamed this variable so it needs to be renamed here too.

  chrisny286 · 2019-01-21 17:19:40 +01:00
  fb51578df3
• OpenTK -> osuTK
  smoogipoo · 2018-11-20 17:14:59 +09:00
  f27bd3ef3e
• Use UIEvent level getters for modifier keys.
  ekrctb · 2018-10-02 13:26:36 +09:00
  b7a2ad1aa5
• Adapt signature change of event handlers
  ekrctb · 2018-10-02 12:02:55 +09:00
  50091252e2
• Change signature to new event handler
  ekrctb · 2018-10-02 12:02:47 +09:00
  99fc04c8af
• Update framework with positional/non-positional changes
  smoogipoo · 2018-09-26 14:01:15 +09:00
  a8f156584b
• Update framework
  Dean Herbert · 2018-07-21 16:21:53 +09:00
  0f37758314
• Normalize all the line endings
  Dean Herbert · 2018-04-13 18:26:38 +09:00
  32a74f95a5
• Collapse visual settings by default in player
  Dean Herbert · 2018-02-16 12:47:32 +09:00
  29adedfa96
• Fix PlayerSettingsOverlay not reappearing when Hidden
  tgi74000 · 2018-02-01 16:07:49 +01:00
  b0fbae9dfc
• PlayerGroup -> PlayerSettingsGroup
  TocoToucan · 2018-01-15 20:52:52 +03:00
  a81f32a388
• Rename ReplaySomething -> PlayerSomething
  TocoToucan · 2018-01-13 22:25:09 +03:00
  43d2ae348a