1
0
mirror of https://github.com/ppy/osu.git synced 2026-05-24 07:59:57 +08:00

Fix player settings overlay potentially disappearing unexpectedly

Closes https://github.com/ppy/osu/issues/33793.

Can be tested with this diff:

```diff
diff --git a/osu.Game/Screens/Play/HUD/PlayerSettingsOverlay.cs
b/osu.Game/Screens/Play/HUD/PlayerSettingsOverlay.cs
index 635d140a4a..b3a827b699 100644
--- a/osu.Game/Screens/Play/HUD/PlayerSettingsOverlay.cs
+++ b/osu.Game/Screens/Play/HUD/PlayerSettingsOverlay.cs
@@ -60,6 +60,8 @@ public PlayerSettingsOverlay()
             Origin = Anchor.TopRight;
             Anchor = Anchor.TopRight;

+            X = 0.01f;
+
             base.Content.Add(content = new FillFlowContainer
             {
                 AutoSizeAxes = Axes.Both,

```
This commit is contained in:
Dean Herbert
2025-06-24 15:33:51 +09:00
Unverified
parent 40ac1fa634
commit c0a51da110
@@ -6,6 +6,7 @@ using osu.Framework.Extensions.Color4Extensions;
using osu.Framework.Graphics;
using osu.Framework.Graphics.Colour;
using osu.Framework.Graphics.Containers;
using osu.Framework.Graphics.Primitives;
using osu.Framework.Graphics.Shapes;
using osu.Framework.Graphics.Sprites;
using osu.Framework.Input;
@@ -47,6 +48,12 @@ namespace osu.Game.Screens.Play.HUD
[Resolved]
private HUDOverlay? hudOverlay { get; set; }
// Player settings are kept off the edge of the screen.
//
// In edge cases, floating point error could result in the whole control getting masked away
// while collapsed down, so let's avoid that.
protected override bool ComputeIsMaskedAway(RectangleF maskingBounds) => false;
public PlayerSettingsOverlay()
: base(0, EXPANDED_WIDTH)
{