44 Commits

• Fix editor metadata section reload potentially confusing title and author

  Probably closes https://github.com/ppy/osu/issues/34449. I say probably
  because I couldn't break this myself without commenting out chunks of
  code that apply the metadata from the id3 tags, and the reporter of that
  issue did not provide mp3s to test with or a clear reproduction
  scenario. But chances are this is going to fix the problem anyhow.

  Bartłomiej Dach · 2025-07-31 10:58:43 +02:00
  d7a17d59e3
• Fix ID3 metadata half-applying on audio file switch

  Should be self-explanatory (feedback loop between `reloadMetadata()`
  changing text box current, and text box current changing calling
  `applyMetadata()`).

  Bartłomiej Dach · 2025-04-28 09:41:38 +02:00
  8ea89b9d52
• Fix renamed translation keys
  Jamie Taylor · 2025-04-23 15:30:41 +09:00
  3b80c0af0a
• Make dependency on editor optional
  Bartłomiej Dach · 2025-04-07 15:00:47 +02:00
  5db4f80e84
• Fix code quality harder
  Bartłomiej Dach · 2025-04-07 14:59:51 +02:00
  f968f8ed68
• Fix nullability inspection
  Bartłomiej Dach · 2025-04-07 13:44:42 +02:00
  d34a1fb448
• Avoid saving a state when clearly not dirty
  Dean Herbert · 2025-04-07 19:37:26 +09:00
  3738d75202
• Ensure a state is saved when committing metadata to trigger pending changes flow
  Dean Herbert · 2025-04-03 18:49:18 +09:00
  f19fa73fb2
• Change editor to save metadata changes without explicit textbox commit

  Closes https://github.com/ppy/osu/issues/32365.

  Dean Herbert · 2025-04-03 15:31:24 +09:00
  ce288023fe
• Update textbox usage in line with framework changes
  Dean Herbert · 2025-01-14 16:29:56 +09:00
  904a08af26
• Fix failing test scene due to new dependency
  Dean Herbert · 2024-12-28 01:02:15 +09:00
  1b2a223a5f
• Populate metadata from ID3 tags when changing beatmap audio track in editor

  - Closes https://github.com/ppy/osu/issues/21189
  - Supersedes / closes https://github.com/ppy/osu-framework/pull/5627
  - Supersedes / closes https://github.com/ppy/osu/pull/22235
  
  The reason why I opted for a complete rewrite rather than a revival of
  that aforementioned pull series is that it always felt quite gross to me
  to be pulling framework's audio subsystem into the task of reading ID3
  tags, and I also partially don't believe that BASS is *good* at reading
  ID3 tags. Meanwhile, we already have another library pulled in that is
  *explicitly* intended for reading multimedia metadata, and using it
  does not require framework changes. (And it was pulled in explicitly for
  use in the editor verify tab as well.)
  
  The hard and dumb part of this diff is hacking the gibson such that
  the metadata section on setup screen actually *updates itself*
  after the resources section is done doing its thing. After significant
  gnashing of teeth I just did the bare minimum to make work by caching
  a common parent and exposing an `Action?` on it. If anyone has better
  ideas, I'm all ears.

  Bartłomiej Dach · 2024-12-27 15:16:03 +01:00
  6a6db5a22b
• Replace setup screen controls with new "form" controls
  Bartłomiej Dach · 2024-10-03 11:49:03 +02:00
  b15608343b
• Adjust calls to GetContainingInputManager()
  Bartłomiej Dach · 2024-06-18 07:41:19 +02:00
  659505f711
• Null-propagate all calls to GetContainingFocusManager()
  Bartłomiej Dach · 2024-06-18 07:30:46 +02:00
  8a4ae5d23d
• Merge branch 'master' into fix-editor-didnt-save
  Bartłomiej Dach · 2024-05-24 10:16:46 +02:00
  4089071299
• Update focus specifications in line with framework changes
  Dean Herbert · 2024-05-22 21:32:49 +08:00
  66ceda1d67
• Fix potential editor data loss if exiting while a textbox is focused
  Dean Herbert · 2024-01-26 13:59:32 +09:00
  45f2980dc0
• Enable nullability for setup screen
  ansel · 2023-01-14 02:24:28 +03:00
  4b42240fba
• Partial everything
  Dan Balasescu · 2022-11-27 00:00:27 +09:00
  7bc8908ca9
• Merge pull request #19693 from its5Q/editor-localisation

  Add localisation support for beatmap editor setup

  Dean Herbert · 2022-08-20 11:51:57 +09:00
  cbdd870ecf
• Replace osu-web strings with new strings and merge to single file
  its5Q · 2022-08-16 01:14:16 +10:00
  797a8da996
• Add localisation support for beatmap editor setup
  its5Q · 2022-08-11 03:53:20 +10:00
  2499b7f0cd
• Limit metadata updates to once per frame
  Dean Herbert · 2022-08-02 22:02:30 +09:00
  de186f67e0
• Fix multiple cases of mutations at editor setup screen not triggering a state save
  Dean Herbert · 2022-08-02 16:47:37 +09:00
  efa3c3b757
• Automated #nullable processing
  Dan Balasescu · 2022-06-17 16:37:17 +09:00
  f8830c6850
• Use existing web localisation for most hardcoded strings
  Joseph Madamba · 2022-04-20 16:31:11 -07:00
  5e5c8e78a6
• Update further ChangeFocus usages
  Salman Ahmed · 2022-02-15 02:42:39 +03:00
  f5d0eb41cb
• Remove all usage of AuthorString
  Dean Herbert · 2022-01-18 23:30:40 +09:00
  67bf95bc91
• Rename BeatmapInfo.Version to DifficultyName to match underlying interface
  Dean Herbert · 2021-11-11 17:20:53 +09:00
  51a353e12d
• Update all existing usages of AuthorString/AuthorId

  Unfortunately the getters need to be left in place else EF breaks.

  Dean Herbert · 2021-11-04 18:59:37 +09:00
  ed07ee8c61
• Just wait for metadata section to be loaded
  Dean Herbert · 2021-10-14 22:12:38 +09:00
  ad0732484f
• Add test coverage for romanised data transfer
  Bartłomiej Dach · 2021-06-10 22:18:39 +02:00
  417aaacc53
• Add romanised author & title fields
  Bartłomiej Dach · 2021-06-10 22:17:45 +02:00
  e41a5a0fcd
• Add source and tags text boxes to metadata section
  Bartłomiej Dach · 2021-06-10 14:13:59 +02:00
  252fe0a6cc
• Split common method for metadata textbox creation
  Bartłomiej Dach · 2021-06-10 13:55:34 +02:00
  5a2e710095
• Apply fixed label width to setup screen items
  Bartłomiej Dach · 2021-06-08 17:18:00 +02:00
  410cb16340
• Explicitly associate setup sections with titles
  Bartłomiej Dach · 2021-04-03 19:58:49 +02:00
  95d7e6c74b
• Put back the label
  Dean Herbert · 2021-03-17 17:14:04 +09:00
  d0e61e5b4d
• Focus artist textbox on entering song setup if fields are empty
  Dean Herbert · 2021-03-17 16:57:14 +09:00
  5adc675862
• Start the editor with empty artist/creator/difficulty name fields
  Dean Herbert · 2021-03-17 16:47:12 +09:00
  eda891223c
• Move resolved usage of WorkingBeatmap in editor components as local as possible to avoid misuse
  Dean Herbert · 2021-01-04 16:56:37 +09:00
  b7dd54847f
• Use content instead of exposing the flow container
  Dean Herbert · 2020-10-06 19:26:57 +09:00
  06a51297a3
• Split setup screen up into sections (and use a SectionContainer)
  Dean Herbert · 2020-10-06 17:29:08 +09:00
  98fe5f78ee