561 Commits

• Fix editor memory leak
  Dan Balasescu · 2025-09-02 09:21:31 +09:00
  cac136d3c6
• Fix potential div-by-zero
  Andrei Zavatski · 2025-07-18 15:55:33 +03:00
  04cd91bd36
• Use boxes with inflation instead of a shader
  Andrei Zavatski · 2025-07-18 15:52:51 +03:00
  0f2a078447
• Combine CentreMarker with MarkerVisualisation
  Andrei Zavatski · 2025-07-18 13:19:41 +03:00
  5cb51e5e21
• Fix timeline not updating ticks correctly after arbitrary timing control point changes (again)

  Closes https://github.com/ppy/osu/issues/33393.
  
  This is admittedly a half-assed diff. This was apparently "fixed" once
  before, eons ago, in https://github.com/ppy/osu/pull/11032, but I'm not
  sure whether it regressed, or where, because I don't want to bisect four
  years back. (At that time `ControlPointInfo.ControlPointsChanged`
  did not exist yet.)
  
  Also there's the part where changes to control points do not undo or
  redo (see https://github.com/ppy/osu/issues/31942), but I'm not touching
  that *either*, because if I start touching that, then I will get yelled
  at for not reviewing the 2.5k line PR that rewrites the entirety of
  change handling in editor instead
  (https://github.com/ppy/osu/pull/30314). I will attempt to get through
  that mental block sometime within the year. Please do not rush me.
  
  The cheap cop-out argument is that hooking this up to `ControlPointInfo`
  specifically is probably "more efficient" anyway.

  Bartłomiej Dach · 2025-06-10 14:44:23 +02:00
  f5aeedc7e1
• Merge pull request #32319 from 64ArthurAraujo/editor-darker-placement-blueprint

  Adjust timeline placement display

  Bartłomiej Dach · 2025-03-11 15:28:16 +01:00
  3710d0ede5
• Show border instead of adjusting dim
  Dean Herbert · 2025-03-11 18:35:10 +09:00
  770291b462
• Disallow adjusting slider repeats with more lenient check condition
  Dean Herbert · 2025-03-11 16:12:32 +09:00
  d4f0fc0fde
• Change amount from 0.9f to 0.6f
  Arthur Araujo · 2025-03-10 16:09:18 -03:00
  a78868712c
• Always zoom timeline to centre rather than focus point

  Closes https://github.com/ppy/osu/issues/32183.

  Dean Herbert · 2025-03-03 18:53:41 +09:00
  52860def6c
• Remove dependence of blueprint containers on IPositionSnapProvider
  Bartłomiej Dach · 2025-01-24 11:59:05 +01:00
  15b6e28ebe
• Update game ScrollContainer usage in line with framework changes

  See https://github.com/ppy/osu-framework/pull/6467.

  Dean Herbert · 2025-01-11 01:42:59 +09:00
  94ea003d90
• Simplify editor "ternary button" structure

  As I look into re-implementing the ability to choose combo colour for an
  object (also known as "colourhax") from the editor UI, I stumble upon
  these wretched ternary items again and sigh a deep sigh of annoyance.
  
  The structure is overly rigid. `TernaryItem` does nothing that
  `DrawableTernaryItem` couldn't, except make it more annoying to add
  specific sub-variants of `DrawableTernaryItem` that could do more
  things.
  
  Yes you could sprinkle more levels of virtuals to
  `CreateDrawableButton()` or something, but after all, as Saint Exupéry
  says, "perfection is finally attained not when there is no longer
  anything to add, but when there is no longer anything to take away."
  So I'm leaning for taking one step towards perfection.

  Bartłomiej Dach · 2025-01-09 13:41:22 +01:00
  5c8ae6f851
• Do not expose track directly in EditorClock

  Intends to stop people from mutating it directly, and going through
  `EditorClock` members like `AudioAdjustments` instead.

  Bartłomiej Dach · 2025-01-07 11:40:18 +01:00
  98bb723438
• Fix allocations in updateSamplePointContractedState
  Andrei Zavatski · 2025-01-07 00:48:58 +03:00
  791ca915e4
• Reduce HitSampleInfo constants allocations
  Andrei Zavatski · 2025-01-07 00:36:58 +03:00
  e8dc09f5bc
• Take custom bank name length into account when collapsing sample point indicators

  Would close https://github.com/ppy/osu/issues/31312.
  
  Not super happy with the performance overhead of this, but this is
  already a heuristic-based implementation to avoid every-frame
  `.ChildrenOfType<>()` calls or similar, so not super sure how to do
  better. The `Array.Contains()` check stands out in profiling, but
  without it the indicators can collapse *too* eagerly sometimes.

  Bartłomiej Dach · 2024-12-30 12:04:41 +01:00
  693db097ee
• Merge branch 'master' into beatmap-info-purge
  Dean Herbert · 2024-11-22 18:47:32 +09:00
  086a34f5c0
• Merge branch 'master' into hs-toggle2
  Dean Herbert · 2024-11-13 19:15:00 +09:00
  54ca705680
• Add ability to hide breaks from timeline

  This was another IRL request from a mapper / team member. The rationale
  here is that it can be very annoying to map with break time enabled if
  you have a large gap in the beatmap you are trying to fill with
  hitobjects, as you are placing objects on top of a very gray area.

  Dean Herbert · 2024-11-05 12:56:19 +09:00
  9d65d394d3
• Merge branch 'master' into hs-toggle2
  Bartłomiej Dach · 2024-11-01 18:44:33 +01:00
  f2afec23f9
• Remove hide sample toggle

  In line with feedback from
  https://github.com/ppy/osu/pull/29896#issuecomment-2378676851.

  Bartłomiej Dach · 2024-11-01 18:44:24 +01:00
  8f48682d0a
• only consider hit objects which are visible in timeline for contracted state
  OliBomby · 2024-10-24 21:22:09 +02:00
  eb61da4232
• Merge branch 'master' into auto-addition2
  Dean Herbert · 2024-10-23 15:53:07 +09:00
  5939c78760
• Merge pull request #28863 from OliBomby/additions

  Add toggles and hotkeys for configuring sample addition bank

  Dean Herbert · 2024-10-23 15:52:55 +09:00
  2103b3e186
• Fix timeline blueprints sometimes causing crashes due to current placement blueprint becoming unsorted

  Closes https://github.com/ppy/osu/issues/30324.

  Bartłomiej Dach · 2024-10-21 14:48:57 +02:00
  dbc2e78dd9
• dont contract samples for stacked objects
  OliBomby · 2024-10-20 00:07:40 +02:00
  22aef90cb7
• Update sample point contracted state each frame
  OliBomby · 2024-10-19 23:57:41 +02:00
  f137fed04e
• Use FinishTransforms to init visual state
  OliBomby · 2024-10-19 23:57:05 +02:00
  c03017438e
• contract sample point pieces based on smallest gap on the timeline

  It finds the smallest distance between two sample point pieces on the alive timeline blueprints

  OliBomby · 2024-10-05 20:52:45 +02:00
  48da758c39
• Implement auto additions editor-only
  OliBomby · 2024-10-01 16:40:48 +09:00
  0a78eb9628
• Merge branch 'master' into additions
  Dean Herbert · 2024-10-01 16:38:56 +09:00
  1b4215576d
• Make points slightly smaller when contracted and fix width getting obliterated
  Dean Herbert · 2024-09-27 17:24:24 +09:00
  9dcce67b81
• Use bindable flow for zoom handling
  Dean Herbert · 2024-09-27 17:13:26 +09:00
  ce41dc4629
• Reduce sample point pieces to pink dot if zoomed out
  OliBomby · 2024-09-19 16:20:26 +02:00
  34087a0f1a
• Add to existing selection when dragging with control pressed

  Closes https://github.com/ppy/osu/issues/29023.

  Bartłomiej Dach · 2024-09-18 15:18:13 +02:00
  f6195c5515
• Add view menu toggle for sample points
  OliBomby · 2024-09-17 11:27:23 +02:00
  e4cfa7c86f
• Merge branch 'master' into beatmap-info-purge
  Dean Herbert · 2024-09-15 04:53:35 +09:00
  58fe502af4
• Merge remote-tracking branch 'upstream/master' into doubleclick
  OliBomby · 2024-08-29 19:34:18 +02:00
  ba0c4df2a9
• dont seek on right-click, only on keyboard request
  OliBomby · 2024-08-29 19:34:14 +02:00
  8fe7ab131c
• Automatic seek to sample point on right-click
  OliBomby · 2024-08-27 19:40:33 +02:00
  b5b4f915a9
• Add float comparison leniency just in case
  OliBomby · 2024-08-27 19:04:16 +02:00
  daad476593
• Move zero marker below control points to avoid common overlap scenario
  Dean Herbert · 2024-08-22 01:09:22 +09:00
  fb5fb78fd3
• Add back incorrectly removed control point display toggle
  Dean Herbert · 2024-08-22 01:05:47 +09:00
  843b10ef34
• Revert "add arrow indicator"

  This reverts commit 1ce9e97fd4.

  OliBomby · 2024-08-21 14:12:58 +02:00
  423feadd64
• Remove expanding behaviour of timeline completely
  Dean Herbert · 2024-08-21 16:57:52 +09:00
  fef56cc29e
• Adjust visuals of tick display (and fine tune some other timeline elements)
  Dean Herbert · 2024-08-21 16:46:14 +09:00
  7e6490133d
• Reduce size of hit objects on timeline
  Dean Herbert · 2024-08-21 16:46:13 +09:00
  1a48a6f654
• Simplify timing point display on timeline
  Dean Herbert · 2024-08-21 16:46:13 +09:00
  3065f808a7
• Adjust centre marker visuals a bit
  Dean Herbert · 2024-08-21 16:46:12 +09:00
  a0002943a1