5678 Commits

• Remove dependence of blueprint containers on IPositionSnapProvider
  Bartłomiej Dach · 2025-01-24 11:59:05 +01:00
  15b6e28ebe
• Expose GameplayStartTime in IGameplayClock
  Dean Herbert · 2025-01-24 15:29:49 +09:00
  5cc8181bad
• Merge branch 'master' into pp-dev
  Dean Herbert · 2025-01-21 13:19:01 +09:00
  aeca37c230
• Move error function from osu.Game.Utils to osu.Game.Rulesets.Difficulty.Utils (#31520)

  * Move error function implementation to osu.Game.Rulesets.Difficulty.Utils
  
  * Rename ErrorFunction.cs to DifficultyCalculationUtils_ErrorFunction.cs

  Natelytle · 2025-01-17 19:37:34 +00:00
  5b4ba9225d
• Merge branch 'master' into mobile-fix-mania
  Dean Herbert · 2025-01-16 18:08:46 +09:00
  42e5cb58b7
• Typo fix
  Shawn Presser · 2025-01-15 19:29:41 -06:00
  6008c3138e
• Merge pull request #31446 from EVAST9919/new-combo-editor

  Fix performance degradation while trying to place object with a new combo in the editor.

  Dean Herbert · 2025-01-15 12:56:06 +09:00
  ef7982fbfa
• Fix failing tests

  - Caches `DrawableRuleset` in editor compose screen for mania playfield adjustment container (because it's used to wrap the blueprint container as well)
  - Fixes `ManiaModWithPlayfieldCover` performing a no-longer-correct direct cast with a naive-but-working approach.

  Salman Alshamrani · 2025-01-12 22:56:40 -05:00
  c1ac27d658
• Merge branch 'master' into mobile-fix-mania
  Salman Alshamrani · 2025-01-12 02:00:49 -05:00
  f121b03a78
• Merge branch 'master' into new-combo-editor
  Bartłomiej Dach · 2025-01-10 14:13:14 +01:00
  933f5db208
• Add combo colour override control to editor

  Closes https://github.com/ppy/osu/issues/25608.
  
  Logic mostly matching stable. All operations are done on `ComboOffset`
  which still makes overridden combo colours weirdly relatively dependent
  on each other rather than them be an "absolute" choice, but alas...
  
  As per stable, two consecutive new combos can use the same colour only
  if they are separated by a break:
  
      https://github.com/peppy/osu-stable-reference/blob/52f3f75ed7efd7b9eb56e1e45c95bb91504337be/osu!/GameModes/Edit/Modes/EditorModeCompose.cs#L4564-L4571
  
  This control is only available once the user has changed the combo
  colours from defaults; additionally, only a single new combo object
  must be selected for the colour selector to show up.

  Bartłomiej Dach · 2025-01-10 13:40:56 +01:00
  48196949e0
• Merge pull request #31462 from bdach/ternary-button-is-bad

  Simplify editor "ternary button" structure

  Dan Balasescu · 2025-01-10 14:24:41 +09:00
  38d95abc24
• Punish speed PP for scores with high deviation (#30907)
  Givikap120 · 2025-01-09 13:27:54 +00:00
  b21c6457b1
• Simplify editor "ternary button" structure

  As I look into re-implementing the ability to choose combo colour for an
  object (also known as "colourhax") from the editor UI, I stumble upon
  these wretched ternary items again and sigh a deep sigh of annoyance.
  
  The structure is overly rigid. `TernaryItem` does nothing that
  `DrawableTernaryItem` couldn't, except make it more annoying to add
  specific sub-variants of `DrawableTernaryItem` that could do more
  things.
  
  Yes you could sprinkle more levels of virtuals to
  `CreateDrawableButton()` or something, but after all, as Saint Exupéry
  says, "perfection is finally attained not when there is no longer
  anything to add, but when there is no longer anything to take away."
  So I'm leaning for taking one step towards perfection.

  Bartłomiej Dach · 2025-01-09 13:41:22 +01:00
  5c8ae6f851
• Fix rate adjustments changing the spacing between replay frames
  Dean Herbert · 2025-01-09 13:30:04 +09:00
  c8f72fdbe9
• Simplify angle bonus formula (#31449)

  * Simplify angle bonus formula
  
  * Simplify further
  
  * Simplify acute too
  
  * Tests

  StanR · 2025-01-08 10:03:22 +00:00
  392bb5718c
• Fix combo properties multiple reassignments
  Andrei Zavatski · 2025-01-07 14:00:31 +03:00
  8f4eafea4e
• Merge pull request #31306 from bdach/aspire-slider-breakage

  Fix slider event generator incorrectly not generating repeats when tick distance is zero

  Dan Balasescu · 2025-01-07 11:50:18 +09:00
  77d9c955ea
• Reduce HitSampleInfo constants allocations
  Andrei Zavatski · 2025-01-07 00:36:58 +03:00
  e8dc09f5bc
• Always block scroll input above editor toolbox areas

  Originally this was an intentional choice (see
  https://github.com/ppy/osu/pull/18088) when these controls were more
  transparent and didn't for a solid toolbox area.
  
  But this is no longer the case, so for now let's always block scroll to
  match user expectations.
  
  Closes #31262.

  Dean Herbert · 2025-01-02 14:31:27 +09:00
  cca63b599e
• Allow locking orientation on iOS in certain circumstances
  Salman Alshamrani · 2024-12-29 22:15:21 -05:00
  7563a18c7f
• Rewrite of the Rhythm Skill within osu!taiko (#31284)

  * implement bell curve into diffcalcutils
  
  * remove unneeded attributes
  
  * implement new rhythm skill
  
  * change dho variables
  
  * update dho rhythm
  
  * interval interface
  
  * implement rhythmevaluator
  
  * evenhitobjects
  
  * evenpatterns
  
  * evenrhythm
  
  * change attribute ordering
  
  * initial balancing
  
  * change naming to Same instead of Even
  
  * remove attribute bump for display
  
  * Fix diffcalc tests
  
  ---------
  
  Co-authored-by: StanR <hi@stanr.info>

  Jay Lawton · 2024-12-27 16:30:30 +03:00
  824497d82c
• Fix slider event generator incorrectly not generating repeats when tick distance is zero

  RFC. This closes https://github.com/ppy/osu/issues/31186.
  
  To explain why: The issue occurs on
  https://osu.ppy.sh/beatmapsets/594828#osu/1258033, specifically on the
  slider at time 128604. The failure site is
  
  	https://github.com/ppy/osu/blob/fa0d2f4af22fb9319e2a8773bf635368d86360be/osu.Game.Rulesets.Osu/Edit/Blueprints/Sliders/SliderCircleOverlay.cs#L65-L66
  
  wherein `LastRepeat` is `null`, even though the slider's `RepeatCount`
  is 1 and thus `SpanCount` is 2.
  
  In this case, `SliderEventGenerator` is given a non-zero `tickDistance`
  but a zero `length`. The former is clamped to the latter:
  
  	https://github.com/ppy/osu/blob/fa0d2f4af22fb9319e2a8773bf635368d86360be/osu.Game/Rulesets/Objects/SliderEventGenerator.cs#L34
  
  Because of this, a whole block of code pertaining to tick generation
  gets turned off, because of zero tick spacing - however, that block also
  includes within it *repeat* generation, for seemingly very little reason
  whatsoever:
  
  	https://github.com/ppy/osu/blob/fa0d2f4af22fb9319e2a8773bf635368d86360be/osu.Game/Rulesets/Objects/SliderEventGenerator.cs#L47-L77
  
  While a zero tick distance would indeed cause `generateTicks()` to loop
  forever, it should have absolutely no effect on repeats.
  
  While this *is* ultimately an aspire-tier bug caused by people pushing
  things to limits, I do believe that in this case a fix is warranted
  because of how hard the current behaviour violates invariants. I do not
  like the possibility of having a slider with multiple spans and no
  repeats.

  Bartłomiej Dach · 2024-12-27 12:38:31 +01:00
  e7225399a2
• Add setters to hitobject coordinate interfaces
  Bartłomiej Dach · 2024-12-27 11:01:47 +01:00
  0d16ed028b
• Change slider drop penalty to use actual number of difficult sliders, fix slider drop penalty being too lenient (#31055)

  * Change slider drop penalty to use actual number of difficult sliders, fix slider nerf being too lenient
  
  * Move cubing to performance calculation
  
  * Add separate list for slider strains
  
  * Rename difficulty atttribute
  
  * Rename attribute in perfcalc
  
  * Check if AimDifficultSliderCount is more than 0, code quality fixes
  
  * Add `AimDifficultSliderCount` to the list of databased attributes
  
  * Code quality
  
  ---------
  
  Co-authored-by: James Wilson <tsunyoku@gmail.com>

  StanR · 2024-12-21 23:45:29 +00:00
  6808a5a77c
• Simplify osu! high-bpm acute angle jumps bonus (#30902)

  * Simplify osu! high-bpm acute angle jumps bonus
  
  * Add aim wiggle bonus
  
  * Add hitwindow-based aim velocity decrease
  
  * Revert "Add hitwindow-based aim velocity decrease"
  
  This reverts commit bcebe9662c.
  
  * Move wiggle multiplier to a const, slightly decrease acute bonus multiplier
  
  * Make sure the previous object in the wiggle bonus is also part of the wiggle
  
  * Scale the wiggle bonus multiplayer down
  
  * Increase the acute angle jump bonus multiplier
  
  * Make wiggle bonus only apply on >150 bpm streams, make repetitive angle penalty
  
  * Reduce wiggle bonus multiplier to not break velocity>difficulty relation
  
  * Adjust wiggle falloff function to fix stability issues
  
  * Adjust wiggle consts
  
  * Update tests

  StanR · 2024-12-20 23:32:51 +00:00
  f722f94f26
• Merge branch 'master' into skinnable-mod-display
  Dean Herbert · 2024-12-20 14:08:51 +09:00
  55dff1f0ef
• Merge pull request #30984 from smoogipoo/fix-mania-spinner-conversion

  Fix "spinner" conversion for mania-specific beatmaps

  Bartłomiej Dach · 2024-12-19 15:30:10 +01:00
  1057aa867f
• Refactor TaikoDifficultyCalculator and add DifficultStrain attributes (#31191)

  * refactor + countdifficultstrain
  
  * norm in utils
  
  * adjust scaling shift
  
  * fix comment
  
  * revert all value changes
  
  * add the else back
  
  * remove cds comments

  Jay Lawton · 2024-12-19 11:32:59 +00:00
  4ca88ae2d6
• Merge branch 'master' into bookmarks
  Bartłomiej Dach · 2024-12-07 22:22:04 +09:00
  459533aba6
• Implement skinnable mod display

  Also makes the mod display initialization sequence (start expanded, then
  unexpand) controlled by HUDOverlay rather than mod display itself. This
  enabled different treatment depending on whether the mod display is
  viewed in the skin editor or in the player.
  
  Co-authored-by: Bartłomiej Dach <dach.bartlomiej@gmail.com>

  Thomas Müller · 2024-12-07 12:06:33 +09:00
  0a00f7a7c2
• Populate default LegacyType value on convert hitobjects

  Normally not an issue, but some tests create their own hitobjects
  deriving from `ConvertHitObject`.

  Dan Balasescu · 2024-12-06 17:47:14 +09:00
  8dda5aada8
• Merge branch 'master' into netcore-analyzer
  Huo Yaoyuan · 2024-12-05 17:18:56 +08:00
  d92ea910cf
• Move bookmarks out of BeatmapInfo

  Not sure why I didn't do that in https://github.com/ppy/osu/pull/28473...

  Bartłomiej Dach · 2024-12-03 14:17:14 +01:00
  808934581f
• Update for suggestions
  Huo Yaoyuan · 2024-12-03 00:03:59 +08:00
  7ece8ec1dc
• Merge pull request #28473 from bdach/beatmap-info-purge

  Move unnecessary properties from `BeatmapInfo` / realm to `IBeatmap`

  Dean Herbert · 2024-12-02 16:19:12 +09:00
  5b2558cec2
• Stop loudly logging backwards seek bug to sentry

  Several users have reported stutters when this happens. It's potentially
  from the error report overhead. We now know that this is a BASS level
  issue anyway, so having this logging is not helpful.

  Dean Herbert · 2024-11-30 21:01:22 +09:00
  1e2e364cd3
• Merge branch 'master'
  Huo Yaoyuan · 2024-11-30 01:07:08 +08:00
  fa3c95c296
• Centralise supported file extensions to one helper class

  As proposed in
  https://github.com/ppy/osu-server-beatmap-submission/pull/5#discussion_r1861680837.

  Bartłomiej Dach · 2024-11-29 08:42:45 +01:00
  110e4fbb30
• Apply minor performance rules
  Huo Yaoyuan · 2024-11-28 20:41:44 +08:00
  f5a7716509
• Add basic xmldoc to results class
  Dean Herbert · 2024-11-26 12:16:26 +09:00
  d6cf1db0f5
• Rename NextProcessableIndex to EventCount in line with actual functionality
  Dean Herbert · 2024-11-26 12:10:34 +09:00
  d903d381d5
• Only update unstable rate counter when an applicable hitobject is reached
  Dean Herbert · 2024-11-25 21:13:18 +09:00
  bbe8f2ec44
• Use class instead of record for lower allocations
  Dean Herbert · 2024-11-25 21:13:18 +09:00
  ea68d4b33a
• Add incremental processing
  Dean Herbert · 2024-11-25 21:13:17 +09:00
  5668258182
• Address unstable rate calculations as a list for marginal gains
  Dean Herbert · 2024-11-25 19:44:11 +09:00
  33d725e889
• Make empty hitwindows readonly static and slightly improve comparison performance
  Dean Herbert · 2024-11-25 19:17:32 +09:00
  605fe71f46
• Merge branch 'master' into beatmap-info-purge
  Dean Herbert · 2024-11-22 18:47:32 +09:00
  086a34f5c0
• Made reading of ReadCurrentDistanceSnap public
  Darius Wattimena · 2024-11-18 23:49:40 +01:00
  16158710f9
• Do not show timing distribution graph in offset control if there's not enough timed hits

  Intended to address concerns raised in
  https://github.com/ppy/osu/pull/30620#issuecomment-2475744164.

  Bartłomiej Dach · 2024-11-14 13:17:03 +01:00
  bd1d3cad49