46 Commits

• Disallow selected mods from being valid for freestyle as required mods due to them not being consistently compatible with other mods across rulesets

  Closes https://github.com/ppy/osu/issues/33444.
  
  The issue here is that for a set of required mods to make sense in the
  context of a freestyle playlist item, it must be consistently either
  valid or invalid *as a combination* across all four default rulesets,
  because freestyle also permits changing ruleset. There are two
  pertinent cases here:
  
  - Flashlight and Hidden are compatible in osu!, taiko, and catch, but
    not compatible in mania. In this case I've disallowed both mods
    because of symmetry, basically - I don't see one "better mod" to
    disallow here.
  
  - Accuracy Challenge and Easy are incompatible in osu!, catch, and mania
    (because the mod gives extra lives) there, but *compatible* in taiko,
    where it does not. In this case I've disallowed Accuracy Challenge
    only, because I find its value in being forced on a freestyle room
    to be much smaller than Easy's.
  
  In the large scale of things I don't see this being very important
  because my view is that 99% of the use case of required mods in
  freestyle is going to be changing the track speed. So I don't think
  anyone is going to care about this going away - but we can reassess if
  I'm proven wrong.

  Bartłomiej Dach · 2025-06-05 15:00:54 +02:00
  05496111d6
• Adjust property name
  Dan Balasescu · 2025-04-14 19:34:33 +09:00
  35ee4b6f24
• Allow specifying mod compatibility with freestyle
  Dan Balasescu · 2025-04-04 16:49:23 +09:00
  ef0cf5143d
• Add progressive cover to mania HD and FI mods
  Dan Balasescu · 2024-02-06 23:47:20 +09:00
  5bc7befbd4
• Annotate mods that give pp
  Bartłomiej Dach · 2024-01-31 14:59:35 +01:00
  f89923aeae
• Make ScoreProcessor.Rank read-only
  Dean Herbert · 2024-01-04 17:13:24 +09:00
  705f25e4b9
• Remove the nullable disable annotation.

  Also, mark as nullable for some properties.

  andy840119 · 2022-07-19 20:39:41 +08:00
  1f9f2b413e
• Automated #nullable processing
  Dan Balasescu · 2022-06-17 16:37:17 +09:00
  f8830c6850
• Replace and obsolete Ranked flag with IsUserPlayable
  Dean Herbert · 2021-06-09 14:17:03 +09:00
  d0e9f8ef90
• Duplicate implementions
  PercyDan54 · 2021-05-15 11:55:50 +08:00
  166974506e
• Revert "Remove empty override"

  This reverts commit a86a4bab91.

  PercyDan54 · 2021-05-15 11:45:14 +08:00
  6e5c4ed7c6
• Remove empty override
  PercyDan54 · 2021-05-14 21:55:32 +08:00
  a86a4bab91
• Cleanup code in ModHidden
  PercyDan54 · 2021-05-14 21:29:13 +08:00
  67dfeeb1b7
• Add removal dates
  smoogipoo · 2020-11-05 17:04:11 +09:00
  9d5b1ec28c
• Make methods abstract
  smoogipoo · 2020-11-05 16:03:10 +09:00
  cc518feca7
• Implement ModWithVisibilityAdjustment
  smoogipoo · 2020-11-05 15:40:25 +09:00
  628b8be15d
• Fix incorrect first object logic
  Dean Herbert · 2020-10-09 06:41:53 +09:00
  6649cb2204
• Fix first hitobject in osu! hidden mod not getting correct fade applied
  Dean Herbert · 2020-10-09 03:07:01 +09:00
  2d0275ba95
• Fix spinners being considered the "first object" for increased visibility in hidden
  Dean Herbert · 2020-04-16 14:11:38 +09:00
  9dda7da489
• nullable-ize Mod.Icon
  mcendu · 2020-01-14 21:22:00 +08:00
  5d160376c0
• Apply more cases/fix some existing ones
  smoogipoo · 2019-05-07 13:23:09 +09:00
  13b9b04bb8
• fix comment
  iiSaLMaN · 2019-04-30 18:44:31 +03:00
  e0abd0b2c1
• Remove unnecessary comment
  iiSaLMaN · 2019-04-30 18:44:06 +03:00
  665558c297
• Add AdjustRank and use it in Hidden Mod
  KingLuigi4932 · 2019-04-25 13:56:57 +03:00
  c6b3197dd0
• Remove bindable

  Bad usage

  iiSaLMaN · 2019-04-22 06:12:41 +03:00
  26f0b2a4fe
• Fix issue
  iiSaLMaN · 2019-04-21 18:05:52 +03:00
  c5bf01cc5c
• Make AdjustRank Bindable
  iiSaLMaN · 2019-04-21 17:48:50 +03:00
  77614189c9
• Ranks must be adjusted in Hidden Mod
  iiSaLMaN · 2019-04-21 15:58:40 +03:00
  4e07975e7c
• Update icon usage to match framework changes
  Dean Herbert · 2019-03-27 19:29:27 +09:00
  de80fc0eac
• Fix remaining issues
  Dean Herbert · 2019-02-28 13:31:40 +09:00
  26d53d06a9
• Adjust namespaces
  smoogipoo · 2019-02-21 19:05:52 +09:00
  d8c55bc729
• Update with framework bindable changes
  smoogipoo · 2019-02-21 18:56:34 +09:00
  bca347427f
• Update licence header (and remove year)
  Dean Herbert · 2019-01-24 17:43:03 +09:00
  8617aaa2a7
• Add IMod and change ShortenedName to Acronym
  Dean Herbert · 2018-11-30 17:16:00 +09:00
  d97a15a504
• Reverse order of exposed objects in HitObjectContainer

  Closes #2740.

  Dean Herbert · 2018-06-06 15:03:47 +09:00
  3567823759
• Improve readability of code
  Dean Herbert · 2018-06-06 14:04:20 +09:00
  a5679f7bf5
• resolving the lost code problem
  Vidalee · 2018-05-22 22:39:55 +02:00
  7a31986812
• code sanity
  Vidalee · 2018-05-22 21:35:17 +02:00
  08e423ac5b
• why this line was ommited
  Vidalee · 2018-05-22 21:29:41 +02:00
  50e2871c89
• Appvtests (#1)

  * Resolving AppVeyor's errors

  Vidalee · 2018-05-08 14:33:26 +02:00
  16bcd6c3ed
• Made the changes requested
  Vidalee · 2018-05-06 12:38:25 +02:00
  393c01ba90
• Normalize all the line endings
  Dean Herbert · 2018-04-13 18:26:38 +09:00
  32a74f95a5
• Update licence headers
  Dean Herbert · 2018-01-05 20:21:19 +09:00
  37d393bca0
• Parse the mods of a leaderboard's score
  MrTheMake · 2017-08-13 17:41:13 +02:00
  4c2d7bf343
• Added ModType for each mode
  EVAST9919 · 2017-05-02 21:36:55 +03:00
  00a8dbbacf
• Add DoubleTime, HalfTime and Nightcore support.
  Dean Herbert · 2017-04-21 17:33:37 +09:00
  3f832731c9