256 Commits

• Show effect of beatmap attributes on gameplay metrics in osu!
  Bartłomiej Dach · 2025-08-01 11:07:48 +02:00
  655733c06d
• Allow showing additional metrics when hovering over beatmap attributes
  Bartłomiej Dach · 2025-08-01 11:06:40 +02:00
  c68cbc5360
• Fix code quality
  Bartłomiej Dach · 2025-07-30 15:00:55 +02:00
  640fe5752d
• Rename property to reduce confusion

  Caused an actual bug in one of the replaced usages.

  Bartłomiej Dach · 2025-07-30 14:06:38 +02:00
  cd2c5075df
• Add new ruleset method responsible for displaying beatmap attributes consistently everywhere

  The intention is to use this in every place that wishes to display
  beatmap attributes (and also remove a bunch of local hack-arounds for
  mania, etc.)

  Bartłomiej Dach · 2025-07-30 13:41:19 +02:00
  e2a454ae00
• Disable incorrect cancellation token inspection
  Dean Herbert · 2025-04-07 20:12:49 +09:00
  2dc38b5f09
• Move BeatmapVersion from BeatmapInfo to IBeatmap

  Closes https://github.com/ppy/osu/issues/32420.
  
  The failure cause here is that in editor the beatmap version for the
  beatmap affected (or... any beatmap, really), is 0 (ZERO). That is
  probably a regression from https://github.com/ppy/osu/pull/32315, but
  like... can we universally agree that calling that change "a regression"
  in any capacity is dumb? Like what was that code *doing* playing dumb
  reference games and copying stuff into an arbitrary instance that could
  get or not get used later on? And now you have a 50/50 chance of
  accessing the *correct* model's field, depending on whether you go via
  `BeatmapInfo` or `Beatmap.BeatmapInfo`?
  
  Moving the field to `IBeatmap`, i.e. what is by now - by consensus,
  since https://github.com/ppy/osu/pull/28473 - supposed to be the "decoded
  and materialised" beatmap, fixes this issue.
  
  I probably should have done this as part of
  https://github.com/ppy/osu/pull/28473 but it slipped my mind. Probably
  for the better too because this change has rather large chances of
  breaking stuff so maybe better to examine it in isolation (via diffcalc
  runs or whatever).
  
  For added humour points, you'd say that the field on `BeatmapInfo` was
  not `[Ignore]`d, so this is a realm schema change, right? No. As far as
  I can tell, it's not. I opened realm studio and `BeatmapVersion` *is not
  a listed column` on `Beatmap` models.
  
  I'm also not gonna get into the fact that I think `EditorBeatmap` doing
  dumb games with juggling two `BeatmapInfo` references since
  https://github.com/ppy/osu/pull/15075 is bad, because I don't think I
  have the mental capacity to hotfix this by going down that train of
  thought.

  Bartłomiej Dach · 2025-03-17 15:04:48 +01:00
  91f3be5fea
• Cancel difficulty calculation after 10 seconds by default
  Dan Balasescu · 2025-03-04 11:22:47 +09:00
  550ff85550
• Calculate hit windows in performance calculator instead of databased difficulty attributes (#31735)

  * Calculate hit windows in performance calculator instead of databased difficulty attributes
  
  * Apply mods to beatmap difficulty in osu! performance calculator
  
  * Remove `GreatHitWindow` difficulty attribute for osu!mania
  
  * Remove use of approach rate and overall difficulty attributes for osu!
  
  * Remove use of hit window difficulty attributes in osu!taiko
  
  * Remove use of approach rate attribute in osu!catch
  
  * Remove unused attribute IDs
  
  * Code quality
  
  * Fix `computeDeviationUpperBound` being called before `greatHitWindow` is set

  James Wilson · 2025-02-07 19:21:12 +09:00
  9f90ebb2f7
• Move error function from osu.Game.Utils to osu.Game.Rulesets.Difficulty.Utils (#31520)

  * Move error function implementation to osu.Game.Rulesets.Difficulty.Utils
  
  * Rename ErrorFunction.cs to DifficultyCalculationUtils_ErrorFunction.cs

  Natelytle · 2025-01-17 19:37:34 +00:00
  5b4ba9225d
• Punish speed PP for scores with high deviation (#30907)
  Givikap120 · 2025-01-09 13:27:54 +00:00
  b21c6457b1
• Simplify angle bonus formula (#31449)

  * Simplify angle bonus formula
  
  * Simplify further
  
  * Simplify acute too
  
  * Tests

  StanR · 2025-01-08 10:03:22 +00:00
  392bb5718c
• Rewrite of the Rhythm Skill within osu!taiko (#31284)

  * implement bell curve into diffcalcutils
  
  * remove unneeded attributes
  
  * implement new rhythm skill
  
  * change dho variables
  
  * update dho rhythm
  
  * interval interface
  
  * implement rhythmevaluator
  
  * evenhitobjects
  
  * evenpatterns
  
  * evenrhythm
  
  * change attribute ordering
  
  * initial balancing
  
  * change naming to Same instead of Even
  
  * remove attribute bump for display
  
  * Fix diffcalc tests
  
  ---------
  
  Co-authored-by: StanR <hi@stanr.info>

  Jay Lawton · 2024-12-27 16:30:30 +03:00
  824497d82c
• Change slider drop penalty to use actual number of difficult sliders, fix slider drop penalty being too lenient (#31055)

  * Change slider drop penalty to use actual number of difficult sliders, fix slider nerf being too lenient
  
  * Move cubing to performance calculation
  
  * Add separate list for slider strains
  
  * Rename difficulty atttribute
  
  * Rename attribute in perfcalc
  
  * Check if AimDifficultSliderCount is more than 0, code quality fixes
  
  * Add `AimDifficultSliderCount` to the list of databased attributes
  
  * Code quality
  
  ---------
  
  Co-authored-by: James Wilson <tsunyoku@gmail.com>

  StanR · 2024-12-21 23:45:29 +00:00
  6808a5a77c
• Simplify osu! high-bpm acute angle jumps bonus (#30902)

  * Simplify osu! high-bpm acute angle jumps bonus
  
  * Add aim wiggle bonus
  
  * Add hitwindow-based aim velocity decrease
  
  * Revert "Add hitwindow-based aim velocity decrease"
  
  This reverts commit bcebe9662c.
  
  * Move wiggle multiplier to a const, slightly decrease acute bonus multiplier
  
  * Make sure the previous object in the wiggle bonus is also part of the wiggle
  
  * Scale the wiggle bonus multiplayer down
  
  * Increase the acute angle jump bonus multiplier
  
  * Make wiggle bonus only apply on >150 bpm streams, make repetitive angle penalty
  
  * Reduce wiggle bonus multiplier to not break velocity>difficulty relation
  
  * Adjust wiggle falloff function to fix stability issues
  
  * Adjust wiggle consts
  
  * Update tests

  StanR · 2024-12-20 23:32:51 +00:00
  f722f94f26
• Refactor TaikoDifficultyCalculator and add DifficultStrain attributes (#31191)

  * refactor + countdifficultstrain
  
  * norm in utils
  
  * adjust scaling shift
  
  * fix comment
  
  * revert all value changes
  
  * add the else back
  
  * remove cds comments

  Jay Lawton · 2024-12-19 11:32:59 +00:00
  4ca88ae2d6
• Move bookmarks out of BeatmapInfo

  Not sure why I didn't do that in https://github.com/ppy/osu/pull/28473...

  Bartłomiej Dach · 2024-12-03 14:17:14 +01:00
  808934581f
• Merge branch 'master' into beatmap-info-purge
  Dean Herbert · 2024-11-22 18:47:32 +09:00
  086a34f5c0
• More correct but not too important
  Nathen · 2024-11-14 01:50:05 -05:00
  d0e793a3b3
• Be doubly careful
  Nathen · 2024-11-14 01:47:24 -05:00
  2ea2e5f1db
• Fix NaN PP values when SR is 0
  Nathen · 2024-11-14 01:42:07 -05:00
  ce818f59e7
• Merge branch 'master' into bat-max-performance
  Dean Herbert · 2024-11-14 13:35:29 +09:00
  7670a81181
• Merge pull request #30536 from stanriders/add-diffcalc-helpers

  Add `DifficultyCalculationUtils`

  Dan Balasescu · 2024-11-13 17:49:40 +09:00
  60d45d44bb
• Fix code issues
  StanR · 2024-11-07 21:23:26 +05:00
  c9d3b6557d
• Add DifficultyCalculationUtils
  StanR · 2024-11-07 20:36:00 +05:00
  78c97d2cd7
• rename DifficultStrains for clarity
  Jay Lawton · 2024-11-07 21:56:42 +10:00
  7c3a3c4d10
• update methods
  Jay Lawton · 2024-11-07 21:12:04 +10:00
  2b6a473164
• introduce difficult strains globally
  Jay Lawton · 2024-11-07 19:53:53 +10:00
  a5e6da76cb
• Store attribute to the database
  Dan Balasescu · 2024-11-01 16:02:02 +09:00
  9766d51559
• Compute maximum performance along with difficulty
  Dan Balasescu · 2024-10-17 19:26:19 +09:00
  d195a69447
• Merge branch 'master' into taikostatacc
  Bartłomiej Dach · 2024-10-07 14:15:29 +02:00
  84d6467e48
• Merge branch 'master' into no-combo-scaling
  tsunyoku · 2024-10-03 16:37:20 +01:00
  f54a5a5b0e
• Update osu.Game/Rulesets/Difficulty/DifficultyAttributes.cs

  Co-authored-by: James Wilson <tsunyoku@gmail.com>

  apollo-dw · 2024-09-11 12:29:17 +01:00
  a7e1d35f64
• Merge branch 'master' into beatmap-info-purge
  Dean Herbert · 2024-07-23 12:09:32 +09:00
  d707e29ff7
• Enforce IBeatmap.Breaks to be sorted chronologically
  Salman Ahmed · 2024-07-08 16:06:38 +03:00
  b33e54d064
• Revert "Change breaks list to IReadOnlyList"

  This reverts commit 2c3b411bb5.

  Dan Balasescu · 2024-07-02 12:16:11 +09:00
  04da1209f7
• Change breaks list to IReadOnlyList
  Dean Herbert · 2024-07-02 11:59:24 +09:00
  2c3b411bb5
• Isolate bindable breaks list to EditorBeatmap
  Dean Herbert · 2024-07-02 11:31:55 +09:00
  005af280f2
• Fix ManiaModInvert permanently messing up the beatmap
  Dan Balasescu · 2024-07-01 15:02:00 +09:00
  f942595829
• Merge branch 'master' into pp_counter_fix
  Dan Balasescu · 2024-06-28 12:40:56 +09:00
  3b3f914cd2
• Make list of breaks bindable
  Bartłomiej Dach · 2024-06-19 07:44:03 +02:00
  6a6ccbc09f
• Updated the tests according to new logic

  and fixed one minor CI code quality thing

  Givikap120 · 2024-06-18 15:48:21 +03:00
  1ddfc8f011
• Changed timed difficulty attributes to be "per-HitObject" instead of "per-DifficultyHitObject"
  Givikap120 · 2024-06-18 15:41:41 +03:00
  ec2b8f3bc3
• Move CountdownOffset out of BeatmapInfo
  Bartłomiej Dach · 2024-06-12 14:15:00 +02:00
  dd50d6fa6e
• Move Countdown out of BeatmapInfo
  Bartłomiej Dach · 2024-06-12 14:15:00 +02:00
  d373f752d6
• Move TimelineZoom out of BeatmapInfo
  Bartłomiej Dach · 2024-06-12 14:15:00 +02:00
  7f2a6f6f5a
• Move GridSize out of BeatmapInfo
  Bartłomiej Dach · 2024-06-12 14:15:00 +02:00
  6685c5ab74
• Move DistanceSpacing out of BeatmapInfo
  Bartłomiej Dach · 2024-06-12 14:14:58 +02:00
  3634307d7c
• Move SamplesMatchPlaybackRate out of BeatmapInfo
  Bartłomiej Dach · 2024-06-12 13:32:23 +02:00
  c216283bf4
• Move EpilepsyWarning out of BeatmapInfo
  Bartłomiej Dach · 2024-06-12 13:28:41 +02:00
  f64a0624a5