152 Commits

• Fix some issues
  Dean Herbert · 2025-07-29 13:19:43 +09:00
  f8f37f53a7
• Revert "Remove duplicated string" and move string to CollectionsStrings
  Denis Titovets · 2025-07-15 16:33:58 +03:00
  57c3be4e0a
• Remove duplicated string
  Bartłomiej Dach · 2025-07-15 13:35:09 +02:00
  d0d76d38e6
• Make edits based on reviews
  Denis Titovets · 2025-07-13 23:59:59 +03:00
  b120608ec5
• Remove duplicate `LocalisableString's
  Denis Titovets · 2025-07-09 16:31:51 +03:00
  7c9c2061ad
• Fully localise SSV2
  Denis Titovets · 2025-07-09 15:07:07 +03:00
  1f052bb195
• Fix potential bad realm access to collection name
  Dean Herbert · 2025-02-11 20:05:48 +09:00
  b9c4e23595
• Use more neutral terminology to avoid contentious 'beatmap' term
  Bartłomiej Dach · 2025-02-11 09:17:11 +01:00
  d8b3c28c2e
• Remove completely unnecessary subscriptions per collection
  Bartłomiej Dach · 2025-02-11 09:13:08 +01:00
  884fa20b28
• Merge branch 'master' into collection-counts
  Bartłomiej Dach · 2025-02-11 08:54:24 +01:00
  18965fe0a2
• Fix not being able to scroll to new collection text box when list overflows
  Bartłomiej Dach · 2024-11-18 15:28:30 +01:00
  22b082d968
• Add search bar to collection management dialog
  Dean Herbert · 2024-11-18 16:32:56 +09:00
  5ce1f7679b
• Scroll to new collection in list when adding a new collection
  Dean Herbert · 2024-11-18 16:32:56 +09:00
  a570863854
• Add scrollbar to manage collections dialog
  Dean Herbert · 2024-11-18 16:32:56 +09:00
  e5778eb1fc
• Fix code inspection
  Bartłomiej Dach · 2024-11-14 11:58:57 +01:00
  f9489690cb
• Fix more tests reading in wrong order
  Dean Herbert · 2024-11-14 14:46:58 +09:00
  fea6a54432
• Avoid using newTexst as it doesn't work well with tests
  Dean Herbert · 2024-11-14 14:39:05 +09:00
  17b1888c59
• Avoid writing changes to realm when collection name wasn't actually changed
  Dean Herbert · 2024-11-14 14:39:05 +09:00
  ebe9a9f083
• Change collection management dialog to handle changes more correctly
  Dean Herbert · 2024-11-14 14:39:05 +09:00
  695f156f5f
• Fix delete dialogs having generic "Caution" header text

  Regressed in https://github.com/ppy/osu/pull/28363.

  Dean Herbert · 2024-10-07 16:46:53 +09:00
  11fc811e2f
• Apply corner radius at a higher level so hover click sounds account for it
  Joseph Madamba · 2024-08-01 18:45:47 -07:00
  1e38d1fa57
• Fix collection delete button not having hover click sounds
  Joseph Madamba · 2024-08-01 18:30:52 -07:00
  0fac8148ed
• Merge pull request #28762 from frenzibyte/change-chevron-display

  Change display of "expanded" chevrons in many UI components to use scale instead of rotation

  Dean Herbert · 2024-07-08 20:05:59 +09:00
  c0a1696538
• Fix sizing / padding of collection dropdown header
  Dean Herbert · 2024-07-08 19:32:28 +09:00
  910153c2e0
• Add transition to dropdown chevrons
  Salman Ahmed · 2024-07-08 08:48:52 +03:00
  58e236a247
• Make DuckDuration non-zero by default
  Dean Herbert · 2024-07-05 18:39:13 +09:00
  5907e0d1eb
• Adjust ducking API to use a parameters record
  Dean Herbert · 2024-07-05 15:04:40 +09:00
  554740af10
• Change Duck() to be IDisposable and prevent overlapping usages
  Jamie Taylor · 2024-07-04 14:23:35 +09:00
  d948193757
• Replace manual usages of AudioFilter with new ducking methods
  Jamie Taylor · 2024-06-22 01:57:14 +09:00
  0d11b2b91c
• Update framework
  Dean Herbert · 2024-05-23 01:21:12 +08:00
  fd9f8bd3e0
• Update focus specifications in line with framework changes
  Dean Herbert · 2024-05-22 21:32:49 +08:00
  66ceda1d67
• Merge branch 'master' into collection-counts
  Bartłomiej Dach · 2024-02-28 16:06:47 +01:00
  b99dc26f96
• Apply safeties for AudioFilter usage around drawables which go non-present
  Dean Herbert · 2024-02-26 21:22:25 +08:00
  c686dfd361
• Use new LINQ Order() instead of OrderBy() when possible
  Berkan Diler · 2024-02-08 18:01:00 +01:00
  6adf0ac01e
• Fix collection dropdown crashing when all collections are deleted at once
  Dean Herbert · 2024-01-15 17:10:30 +09:00
  0a522d260b
• Merge pull request #25821 from bdach/fix-collection-dropdown-crash

  Fix collections dropdown crashing during storage migration

  Dean Herbert · 2023-12-19 01:01:23 +09:00
  c466775f78
• Fix crash when creating collections named "All beatmaps" or "Manage collections..."

  Closes https://github.com/ppy/osu/issues/25834
  
  The name fallback that was there previously since
  https://github.com/ppy/osu/pull/11892 was half broken. This way should
  be a lot less prone to failure.

  Bartłomiej Dach · 2023-12-18 12:52:39 +01:00
  eeeb5aa3d4
• Fix collections dropdown crashing during storage migration

  Closes https://github.com/ppy/osu/issues/25815.
  
  `CollectionDropdown.collectionsChanged()` was assuming that if it
  received `null` changes, then it must mean that the change subscription
  is being initialised and the `filters` list will not contain any items.
  
  However, that is not the only circumstance wherein a realm subscription
  can fire with `null` changes; that can also happen after the main realm
  instance gets recycled via the notification registration flow:
  
  	https://github.com/ppy/osu/blob/2f28a92f0a03c8aed6fac2ec7fb41f7ed865f798/osu.Game/Database/RealmAccess.cs#L545-L549
  
  	https://github.com/ppy/osu/blob/2f28a92f0a03c8aed6fac2ec7fb41f7ed865f798/osu.Game/Database/RealmAccess.cs#L1228-L1251
  
  Therefore, to fix the crash, just ensure that the list is cleared every
  time.

  Bartłomiej Dach · 2023-12-18 09:11:00 +01:00
  ef230884a8
• Merge branch 'master' into more-dropdown-search
  Dean Herbert · 2023-12-14 18:44:57 +09:00
  c3d881caee
• Show search bar by default in language and collection dropdowns
  Dean Herbert · 2023-12-14 18:26:13 +09:00
  d77972a39b
• Improve handling of beatmap collection changes in CollectionDropdown

  Co-authored-by: Dean Herbert <pe@ppy.sh>

  Salman Ahmed · 2023-11-25 02:40:32 +03:00
  68fca00757
• Remove drag handles from manage collections dialog for now

  The realm implementation doesn't support this.

  Dean Herbert · 2023-10-16 15:51:18 +09:00
  36112302d6
• Add pop-in/pop-out sfx to more overlays
  Jamie Taylor · 2023-08-17 18:36:37 +09:00
  3d7ba0e18c
• Bring realm library up-to-date
  Dean Herbert · 2023-07-06 13:37:43 +09:00
  a98a36872e
• Increase the minimum size of the scroll bar

  Allows easier targetting when there is a lot of content in the scroll view
  
  As discussed in https://github.com/ppy/osu/discussions/24095#discussioncomment-6332398.

  Dean Herbert · 2023-07-02 00:04:56 +09:00
  5f880397a9
• Apply osu! side changes in line with FocusedOverlayContainer.PopIn abstract change

  See https://github.com/ppy/osu-framework/pull/5834

  Dean Herbert · 2023-06-18 20:57:32 +09:00
  eb31fdecee
• Ensure collection edit textbox commits on focus loss

  As discussed in https://github.com/ppy/osu/discussions/23739

  Dean Herbert · 2023-06-04 12:51:03 +09:00
  eb7586b517
• Remove redundant type specification
  Dean Herbert · 2023-04-03 15:28:01 +09:00
  256789193f
• Debounce updates to ensure event isn't fired too often after much collection management
  Dean Herbert · 2023-03-22 14:46:13 +09:00
  954be12692
• Show count of beatmaps in collections in manage dialog
  Dean Herbert · 2023-03-22 14:44:52 +09:00
  63e0768207