3395 Commits

• Move helper method to LegacyRulesetExtensions and stop applying rounding allowance to catch

  As discussed, it isn't used in stable like this. Was a mistake.

  Dean Herbert · 2023-10-20 18:57:14 +09:00
  3fb74cb5f9
• Fix insufficient leniency when querying sample points
  Bartłomiej Dach · 2023-10-20 10:26:16 +02:00
  c89081589c
• Use DifficultyRange helper method in one more place
  Dean Herbert · 2023-10-18 23:54:18 +09:00
  040d0970f2
• Centralise and repair circle size calculations game-wide
  Dean Herbert · 2023-10-18 19:50:42 +09:00
  3a5490892c
• Fix various other inspections
  Dean Herbert · 2023-10-17 17:48:51 +09:00
  e081fa48a2
• Fix beatmaps with no preview point set getting incorrect default

  Note that this will require a re-import to fix existing beatmaps
  becuse.. it's stored to realm. Probably not worth worrying about for
  now.

  Dean Herbert · 2023-10-10 19:13:16 +09:00
  2781846147
• Fix double interpolation being applied when applyOffsets=false
  Dean Herbert · 2023-10-05 13:20:52 +09:00
  f8455af0d0
• Merge branch 'master' into clock-fix-attempt-2
  Dean Herbert · 2023-10-04 16:57:49 +09:00
  5a17a86d1d
• Don't show replay import "missing beatmap" notifications during stable import

  Closes https://github.com/ppy/osu/issues/24926.

  Dean Herbert · 2023-09-27 17:04:43 +09:00
  2481c0b64b
• Update in line with framed clock changes
  Dean Herbert · 2023-09-22 22:02:18 +09:00
  d019cb5167
• Fix FramedBeatmapClock's source not being processed
  Dean Herbert · 2023-09-22 16:22:35 +09:00
  6629a47ed3
• Set source directly in FramedBeatmapClock ctor

  This isn't required, but avoids creating a temporary `StopwatchClock`
  and generally just makes debug easier with less state changes.

  Dean Herbert · 2023-09-22 16:22:35 +09:00
  bf08fbe196
• Add note about beatmap offset not being reapplied correctly on ChangeSource
  Dean Herbert · 2023-09-22 14:41:07 +09:00
  0200b63fd3
• Remove hopefully-unnecessary workaround

  It was causing issues with the new implementation.

  Dean Herbert · 2023-09-22 14:41:05 +09:00
  a451ab75dd
• Disable decoupling for OsuGameBase's beatmap implementation

  This avoids it ever mutating the underlying track (aka attempting to start
  it). Resolves the one caveat mentioned in
  aeef92fa710648d4a00edc523e13c17ac6104125.

  Dean Herbert · 2023-09-22 12:49:25 +09:00
  df08c4e1ad
• Remove unnecessary encapsulation workaround

  The new implementation of `DecouplingClock` will not mutate the
  underlying clock in any way (unless attempting to start it when
  approaching from a negative time value).
  
  This should be quite safe as a result.

  Dean Herbert · 2023-09-22 12:49:25 +09:00
  5f634f2812
• Simplify some pieces of FramedBeatmapClock
  Dean Herbert · 2023-09-22 12:49:25 +09:00
  21a2e27e5f
• Fix interpolation not being applied when applyOffsets is set
  Dean Herbert · 2023-09-22 12:49:25 +09:00
  04e6ec8715
• Update usage of DecoupleableInterpolatingFramedClock in FramedBeatmapClock
  Dean Herbert · 2023-09-22 12:49:25 +09:00
  117cd74af6
• Change FramedBeatmapClock to always be decoupled
  Dean Herbert · 2023-09-22 12:49:25 +09:00
  600651795b
• Update clocks in line with framework changes
  Dean Herbert · 2023-09-20 21:17:08 +09:00
  bf984388b3
• Merge pull request #24450 from cdwcgt/missing-beatmap

  Fetch missing beatmap when importing replay

  Dean Herbert · 2023-09-19 18:40:02 +09:00
  067c487b21
• Increase transition speed slightly
  Dean Herbert · 2023-09-19 18:02:08 +09:00
  05e05f8160
• Adjust beatmap card thumbnail dim state to match web better
  Bartłomiej Dach · 2023-09-19 10:28:08 +02:00
  62f97a8d83
• Adjust sizing slightly to remove need for CollapsibleButtonContainerSlim
  Dean Herbert · 2023-09-19 17:20:58 +09:00
  7f30354e61
• Tweak nano beatmap card UX further to meet expectations
  Bartłomiej Dach · 2023-09-19 08:36:32 +02:00
  8e199de78a
• Redo nano beatmap card design to fit needs better

  Wanting to use this inside notification, it turns out that the original
  design did not work very well at such narrow widths, and additionally
  the typical button setup borrowed from elsewhere resulted in teeny tiny
  action buttons.
  
  To that end, slim down the design (get rid of thumbnail, audio preview,
  make expandable right side slimmer), as well as change the entire panel
  so that it has only one action associated with it at all times, and
  clicking the panel in any place triggers that action.

  Bartłomiej Dach · 2023-09-18 14:56:06 +02:00
  5fcd736332
• Merge branch 'beatmap-card-nano' into missing-beatmap
  Bartłomiej Dach · 2023-09-18 14:56:06 +02:00
  06d1a2a316
• Implement nano beatmap card
  Bartłomiej Dach · 2023-09-18 11:30:14 +02:00
  5c2413c06b
• Fix dummy beatmap showing AR 5 on song select
  Joseph Madamba · 2023-09-15 20:26:17 -07:00
  c2685da94c
• Merge branch 'master' into no-legacy-difficulty-control-point
  Bartłomiej Dach · 2023-09-15 11:14:28 +02:00
  a6fab28461
• Rename ArchiveReader implementations to read better
  Dean Herbert · 2023-09-14 13:36:07 +09:00
  541cd972e1
• Delete outdated warning disables
  Bartłomiej Dach · 2023-09-07 18:47:01 +02:00
  2bb869732e
• Remove precision limitations of SliderVelocity
  Dean Herbert · 2023-09-07 17:41:58 +09:00
  dcbdc114ce
• Remove all usage of LegacyDifficultyControlPoint
  Dean Herbert · 2023-09-07 17:41:57 +09:00
  b34a36f6ce
• Rename SliderVelocity to SliderVelocityMultiplier to distinguish from Velocity
  Dean Herbert · 2023-09-06 19:01:08 +09:00
  1a37543d28
• Add animation support for beatmap status pills

  To be used in conjunction with https://github.com/ppy/osu/pull/22116

  Dean Herbert · 2023-09-06 15:04:25 +09:00
  034c887dcb
• use realm query
  cdwcgt · 2023-09-04 17:13:46 +09:00
  3decadaf51
• Merge branch 'master' into missing-beatmap
  cdwcgt · 2023-09-04 12:41:23 +09:00
  dfecddbf5d
• Merge branch 'master' into formats-nrt
  Bartłomiej Dach · 2023-08-21 08:17:34 +02:00
  c27f06c0a7
• Rename GetPath to GetFullPath to better match expectations
  Dean Herbert · 2023-08-18 17:56:43 +09:00
  5e0b89a1a8
• Move population of import time to the Populate method

  Feels like a better place to be doing this. I think we want to keep any
  kind of potentially expensive work in the `Populate` method.

  Dean Herbert · 2023-08-18 17:56:11 +09:00
  864f1bdb3e
• Remove dead metadata transfer code
  Dean Herbert · 2023-08-18 17:40:00 +09:00
  eb2460d180
• Set correct date added value when importing stable beatmapsets
  Krzysztof Gutkowski · 2023-08-17 00:49:48 +02:00
  59abb59ee8
• Apply NRT to osu.Game.Betamaps.Formats namespace
  Dean Herbert · 2023-08-16 19:37:24 +09:00
  49fc9655d2
• Repurpose Flat{File -> }WorkingBeatmap
  Bartłomiej Dach · 2023-08-12 00:49:42 +02:00
  37361cd683
• Add lenience to FramedBeatmapClock workaround
  Dean Herbert · 2023-08-02 18:49:24 +09:00
  75c1d5ad7f
• retrun DefaultBeatmap when beatmapset already delete pending

  reimplement https://github.com/ppy/osu/pull/22741

  cdwcgt · 2023-08-02 17:58:17 +09:00
  c07a1ec91e
• Merge branch 'master' into song-select-drain-length
  Bartłomiej Dach · 2023-07-25 22:40:45 +02:00
  57ccf82f34
• Merge branch 'master' into menu-star-fountains
  Bartłomiej Dach · 2023-07-25 21:58:13 +02:00
  3b9f250c1b