53 Commits

• Fix judgement position when not supplied a drawable hit object
  clayton · 2025-08-10 07:16:57 -07:00
  375da52a34
• Fix tick hits in non-legacy skins
  clayton · 2025-08-10 07:15:20 -07:00
  5fc5d0bd5f
• Don't rely on single-use properties
  Dan Balasescu · 2024-07-18 19:07:02 +09:00
  a7e110f669
• Fix incorrect slider judgement positions when classic mod is active

  Regressed in https://github.com/ppy/osu/pull/27977.
  
  Bit ad-hoc but don't see how to fix without just reverting the change.

  Bartłomiej Dach · 2024-06-25 10:07:58 +02:00
  2cb18820ea
• Only take initial judgement position from object instead of following

  Looks less bad with mods like depth active.
  
  Co-authored-by: Dean Herbert <pe@ppy.sh>

  Bartłomiej Dach · 2024-05-30 09:03:02 +02:00
  8916f08f86
• Use hopefully safer implementation of anchoring judgements to objects
  Bartłomiej Dach · 2024-05-29 11:11:43 +02:00
  a6c776dac8
• Fix formatting
  DavidBeh · 2024-04-24 12:40:23 +02:00
  8c2a4eb78a
• Made judgements follow DrawableOsuHitObjects. Enabled judgements for depth mod
  DavidBeh · 2024-04-24 00:23:45 +02:00
  16190a4ed7
• Fixed judgements with MG mod without causing side effects
  DavidBeh · 2024-04-23 23:24:51 +02:00
  3a914b9337
• Attempt to position DrawableOsuJudgement based on its DrawableOsuHitObject instead of DrawableOsuHitObject.HitObject
  DavidBeh · 2024-04-23 19:19:11 +02:00
  331f1f31b0
• Fix SkinnableLighting showing up as a user placeable component
  Dean Herbert · 2023-02-17 18:24:05 +09:00
  675e5b81f3
• Partial everything
  Dan Balasescu · 2022-11-27 00:00:27 +09:00
  7bc8908ca9
• Fix some lingering inspections
  Dean Herbert · 2022-11-09 17:46:24 +09:00
  ab458320c4
• Automated #nullable processing
  Dan Balasescu · 2022-06-17 16:37:17 +09:00
  f8830c6850
• Fix osu! judgements getting scaled twice over different durations
  Dean Herbert · 2021-09-02 16:31:43 +09:00
  b907c2f4f6
• Avoid expensive text spacing transforms for now
  Dean Herbert · 2021-08-26 13:15:27 +09:00
  8cfb3d456b
• Make sliders display judgements when not ignored
  smoogipoo · 2021-02-03 22:42:50 +09:00
  2f22dbe06b
• Add better test coverage of hit lighting (and ensure reset after animation reapplication)
  Dean Herbert · 2020-11-19 14:10:07 +09:00
  3024ae6d86
• Add comment for future todo task
  Dean Herbert · 2020-11-18 19:03:34 +09:00
  d017e725fb
• Fix hit lighting dictating lifetime even when not present in skin
  Dean Herbert · 2020-11-18 19:03:34 +09:00
  9d3de5bca0
• Handle DrawableJudgement lifetime more flexibly
  Dean Herbert · 2020-11-18 19:03:34 +09:00
  72a15ef2dc
• Remove fades from DrawableJudgement itself
  Dean Herbert · 2020-11-18 19:03:34 +09:00
  94886a09b2
• Move result type to ctor
  Dean Herbert · 2020-11-17 15:43:54 +09:00
  8247e6ce91
• Move all extended animation logic out of DrawableJudgement
  Dean Herbert · 2020-11-17 14:59:34 +09:00
  f465dd5a5e
• Remove unused DrawableOsuJudgement constructors
  Dean Herbert · 2020-11-17 14:13:51 +09:00
  82c3925a37
• Make Apply non-virtual
  Dean Herbert · 2020-11-17 14:05:13 +09:00
  9dfa4249e0
• Remove AccentColour binding from judgement lighting
  smoogipoo · 2020-11-05 14:49:15 +09:00
  9ac822beed
• Replace assignment references to HitResult.Miss with Judgement.MinResult
  Bartłomiej Dach · 2020-10-02 23:31:24 +02:00
  1f0620ffd4
• Replace comparison references to HitResult.Miss with IsHit
  Bartłomiej Dach · 2020-10-02 23:31:24 +02:00
  2b1ef16f89
• Bring back custom fade-out delay if hit lighting is on
  Bartłomiej Dach · 2020-07-27 19:21:01 +02:00
  7ad3101d08
• Determine whether to show lighting at prepare time
  Bartłomiej Dach · 2020-07-27 19:07:21 +02:00
  21ae33e284
• Add failing test cases
  Bartłomiej Dach · 2020-07-27 19:07:21 +02:00
  bbc7d69524
• Fix judgement animations not resetting on use
  smoogipoo · 2020-07-13 21:21:59 +09:00
  8a3cadc111
• Fix one more nullref
  Dean Herbert · 2020-07-10 22:48:34 +09:00
  dd025262d0
• Remove result nullable check
  Dean Herbert · 2020-07-10 22:39:35 +09:00
  0a61f80c8b
• Fix null reference if hit lighting is disabled
  Dean Herbert · 2020-07-10 22:37:29 +09:00
  13205319f3
• Make Apply virtual to further simplify application process
  Dean Herbert · 2020-07-10 18:35:20 +09:00
  f872343bab
• Use DrawablePool for DrawableJudgements
  Dean Herbert · 2020-07-04 16:45:50 +09:00
  ffec4298a7
• Add initial implementation of hit lighting

  Requires a supporting skin, like osu!classic for now.

  Dean Herbert · 2019-09-18 02:49:54 +09:00
  ba76f09c99
• Make all inheritors of drawablejudgement use new method
  David Zhao · 2019-03-12 19:52:44 +09:00
  527b77b07d
• Update licence header (and remove year)
  Dean Herbert · 2019-01-24 17:43:03 +09:00
  8617aaa2a7
• OpenTK -> osuTK
  smoogipoo · 2018-11-20 17:14:59 +09:00
  f27bd3ef3e
• Make Rulesets.Osu use the new judgement result structure
  smoogipoo · 2018-08-02 20:36:38 +09:00
  4548d2c87f
• Normalize all the line endings
  Dean Herbert · 2018-04-13 18:26:38 +09:00
  32a74f95a5
• Merge branch 'master' into more-skinning
  Dean Herbert · 2018-03-12 11:55:50 +09:00
  eb643b690a
• Remove judgements when deciding a new judgement for a HitObject

  Generally happens when rewinding.

  Dean Herbert · 2018-03-07 19:14:42 +09:00
  b62ed004f2
• Add skin support for judgements
  Dean Herbert · 2018-03-07 18:21:05 +09:00
  05eb678654
• Update licence headers
  Dean Herbert · 2018-01-05 20:21:19 +09:00
  37d393bca0
• move HitResult in Scoring namespace to replace HitCount
  Aergwyn · 2017-12-30 21:23:18 +01:00
  ccb69d16d9
• Remove all generic judgements.
  smoogipooo · 2017-09-06 18:05:51 +09:00
  0cc443e618