1059 Commits

• Merge pull request #34761 from frenzibyte/fix-flashlight

  Fix flashlight not always matching gameplay scaling

  Bartłomiej Dach · 2025-08-25 12:03:58 +02:00
  6e8246b539
• Adjust default flashlight size on osu! & osu!catch

  Because the flashlight is made to be scaled by playfield, there are
  constant scale factors applied somewhere in the
  `PlayfieldAdjustmentContainer` which needs to be reflected in the
  flashlight size to keep the size the same.
  
  The factor is specifically 1.6x, computed in {Osu,Catch}PlayfieldAdjustmentContainer.ScalingContainer`.
  
  More generally, I've deduced these factors by logging the difference
  between the `flashlightSize` before and after b78abe2f.

  Salman Alshamrani · 2025-08-21 19:03:43 +03:00
  7530ad1a7b
• Add and use new mod icon assets
  Bartłomiej Dach · 2025-08-21 09:00:44 +02:00
  92016a7d9b
• change access modifier of internal mods to public
  minisbett · 2025-08-16 13:44:01 +02:00
  d3910d80e5
• Merge branch 'master' into fix_strict_tracking_scoring
  Bartłomiej Dach · 2025-07-08 13:26:03 +02:00
  b9a4f0068e
• Fix mania Hard Rock & Easy mods not matching stable

  The implementation in `master` was presuming that Hard Rock and Easy
  worked the same way across all rulesets, but actually, in stable mania,
  the two mods have special treatment as per
  
  	https://github.com/peppy/osu-stable-reference/blob/996648fba06baf4e7d2e0b248959399444017895/osu!/GameplayElements/HitObjectManagerMania.cs#L147-L150
  
  The open question here would be what this means for existing scores set
  on lazer using this mod.

  Bartłomiej Dach · 2025-07-02 12:26:50 +02:00
  8e53f47e78
• Merge branch 'master' into fix_strict_tracking_scoring
  Dan Balasescu · 2025-07-02 18:14:15 +09:00
  4b7dcd0b3c
• Replace using static with inner class name
  Dan Balasescu · 2025-07-02 18:14:13 +09:00
  2016fc5ea1
• Fix Difficulty Adjust extended mod icon information not showing with extended limits active

  - Closes https://github.com/ppy/osu/issues/33522.
  - Alternative to / closes https://github.com/ppy/osu/pull/33561.

  Bartłomiej Dach · 2025-06-30 12:20:05 +02:00
  28caa03d21
• Remove no longer used method
  Dan Balasescu · 2025-06-25 18:31:35 +09:00
  d42fcabcf4
• Add failing test case
  Salman Alshamrani · 2025-06-18 19:19:54 +03:00
  9cb824df6f
• remove using not used
  Fayar35 · 2025-06-18 00:15:18 +02:00
  48e6f09b4d
• change StrictTrackingTailJudgement to regular TailJudgement but with LargeTickMiss in case of break
  Fayar35 · 2025-06-17 23:20:50 +02:00
  065fc446da
• Fix rider EAP new naming inspections
  Dean Herbert · 2025-05-25 20:39:55 +09:00
  5e3fd7a42a
• Fix Strict Tracking running miss-on-tracking-loss logic during rewind

  Probably closes https://github.com/ppy/osu/issues/29945.

  Bartłomiej Dach · 2025-05-20 14:17:16 +02:00
  3a136a4c81
• Don't bother with localised implementation of AdjustedSettingsCount

  I was avoiding using reflection to save on overheads, but it's probably
  not worth it.

  Dean Herbert · 2025-04-30 12:58:40 +09:00
  babccca2bb
• Show singular difficulty adjust modifications inline in mod icons
  Dean Herbert · 2025-04-28 16:58:16 +09:00
  c16514274d
• Minor fix to the description text
  Shavixinio · 2025-04-22 19:49:34 +02:00
  3b2382ceb0
• Fix "spins per minute" shows up early #31173

  Make isSpinnableTime public in SpinnerRotationTracker and use it to set Tracking in OsuModSpunOut.
  
  Tracking was previously set to true, causing the "spins per minute" to appear immediately when the spinner appeared.

  Rudi Herouard · 2025-04-13 23:35:44 +02:00
  7cdbc2c20a
• Change SettingDescription to differentiate between settings and values
  Salman Alshamrani · 2025-03-23 13:43:26 -04:00
  6e635f124a
• Fix double-clicking difficulty adjust sliders not resetting the value to default correctly

  - Closes https://github.com/ppy/osu/issues/31888
  - Supersedes / closes https://github.com/ppy/osu/pull/32060

  Bartłomiej Dach · 2025-02-25 07:40:55 +01:00
  1f562ab47d
• Refactor slightly
  Dean Herbert · 2025-02-18 13:04:38 +09:00
  20dbe096e0
• Merge branch 'master' into sudden-death-feat
  Plextora · 2025-02-16 19:43:55 -05:00
  cb012123ab
• Change mirror mod direction setting tooltip to hopefully be less confusing

  See https://github.com/ppy/osu/issues/29720,
  https://discord.com/channels/188630481301012481/188630652340404224/1334294048541904906.
  
  This removes the tooltip due to being zero or negative information, and
  also changes the description of the setting to not contain the word
  "mirror", which will hopefully quash the "this is where I would place a
  mirror to my screen to achieve what I want" interpretation which seems
  to be a minority interpretation.
  
  The first time this was complained about I figured this was probably a
  one guy issue, but now it's happened twice, and I never want to see this
  conversation again.

  Bartłomiej Dach · 2025-01-30 08:59:33 +01:00
  bad2959d5b
• Reduce HitSampleInfo constants allocations
  Andrei Zavatski · 2025-01-07 00:36:58 +03:00
  e8dc09f5bc
• Change OsuModRelax hit leniency to be the same as in stable
  StanR · 2024-12-26 18:13:09 +05:00
  94d56d3584
• No more one line return for FailCondition
  Plextora · 2024-12-22 17:46:01 -05:00
  fd1cc34e3f
• Return base for default FailCondition
  Plextora · 2024-12-22 12:21:51 -05:00
  047c448741
• One line return for FailCondition
  Plextora · 2024-12-21 22:56:42 -05:00
  5c9278ee2f
• Rename option (again)
  Plextora · 2024-12-21 22:55:30 -05:00
  420c5577d3
• Rename to PFC mode
  Plextora · 2024-12-21 21:32:09 -05:00
  87697a72e3
• Fail on slider tail miss option in Sudden Death
  Plextora · 2024-12-21 21:17:03 -05:00
  fa5922337d
• Allow Autopilot and Grow/Deflate compatibility
  jhk2601 · 2024-11-14 14:12:21 -05:00
  ef9296f3ad
• Ensure mod incompatibility consistency across files
  jhk2601 · 2024-11-13 21:12:29 -05:00
  46f5990731
• Fix up code quality and isolate scale better
  Dean Herbert · 2024-11-13 14:52:24 +09:00
  af4a3785e9
• Merge branch 'master' into std_mod_bloom
  Dean Herbert · 2024-11-13 14:14:13 +09:00
  ac759bacb9
• Merge branch 'master' into barrel_roll_fix
  Bartłomiej Dach · 2024-10-21 12:33:37 +02:00
  8349226d9f
• Fixes cursor rotating along with playfield when using Barrel Roll in standard
  jhk2601 · 2024-10-17 14:38:13 -04:00
  7416106321
• Fixed improper handling of size calculation when the max multiplier was changed in mod settings
  jhk2601 · 2024-10-16 20:37:59 -04:00
  9e1af18ac6
• Formatting
  jhk2601 · 2024-10-15 16:27:05 -04:00
  bf970afddb
• Code quality touch-ups
  jhk2601 · 2024-10-15 15:37:05 -04:00
  f6566f9157
• Remove handling for zero as MaxSizeComboCount, set lower limit as 5
  jhk2601 · 2024-10-15 02:23:41 -04:00
  86a5760ef4
• Refactors handling of scale to a function
  jhk2601 · 2024-10-15 02:14:03 -04:00
  bd71da012a
• Fix strict tracking mod not populating path progress for ticks/repeats

  Closes https://github.com/ppy/osu/issues/30237.
  
  This is the root failure in the issue, and one that *only* presents when
  another conversion mod that repositions the objects is also active. That
  makes the `PathProgress` of the nesteds to be zero, therefore making
  them occupy the position of the slider head after any mutation to the
  path.

  Bartłomiej Dach · 2024-10-14 14:26:27 +02:00
  275b86cd3c
• minor changes
  jhk2601 · 2024-10-14 01:54:02 -04:00
  1a142ff944
• Smoother size changing using linear interpolation
  jhk2601 · 2024-10-11 21:52:13 -04:00
  4d367515dc
• Initial Implementation (working, unsafe handling of cursor position)
  jhk2601 · 2024-10-11 18:38:53 -04:00
  0794fc61a0
• Support increased visibility for first object with traceable mod
  Dan Balasescu · 2024-06-27 16:00:22 +09:00
  779d2e8172
• Merge pull request #28359 from smoogipoo/autopilot-resume-overlay

  Use delayed resume overlay for autopilot

  Dean Herbert · 2024-05-30 19:52:58 +09:00
  b46222db19
• Use delayed resume overlay for autopilot
  Dan Balasescu · 2024-05-30 19:17:18 +09:00
  f6a59bee9a