78 Commits

• Use FastCircle in demanding places in the editor
  Andrei Zavatski · 2024-08-30 17:45:26 +03:00
  f5a2b5ea03
• Reduce container nesting in PathControlPointPiece
  Andrei Zavatski · 2024-05-18 22:51:58 +03:00
  614cbdf0a4
• Use local bindable instead

  Binding events directly to an external bindable will cause that
  bindable to hold a permanent reference to the current object.
  
  We use `GetBoundCopy()` or otherwise a local bindable + `.BindTo()` to create a
  weak-referenced copy of the target bindable. When the local bindable's
  lifetime expires, so does the external bindable's reference to it.

  Dan Balasescu · 2024-04-01 15:31:35 +09:00
  099ad22a92
• Bind StackHeight changes to visual update methods
  Arthur Araujo · 2024-03-30 21:23:05 -03:00
  450e7016bc
• fix code quality
  OliBomby · 2024-01-13 23:17:38 +01:00
  243b7b6fda
• remove the need for caching points in segment
  OliBomby · 2024-01-13 21:41:33 +01:00
  da4d83f8ca
• Move logic for caching segments and updating path types to PathControlPointVisualiser
  OliBomby · 2024-01-13 14:47:40 +01:00
  f5d6d52d4c
• Fix control point hover text and context menu
  cs · 2023-11-15 07:45:09 +01:00
  520642975b
• Fix code style/quality issues
  cs · 2023-11-13 08:25:27 +01:00
  fa976a5aa0
• CI Fixup
  cs · 2023-11-11 15:02:06 +01:00
  54b8244a18
• Generalize Bezier curves to BSplines of Nth degree
  Thomas Müller-Höhne · 2023-11-11 13:32:53 +01:00
  926636cc03
• Move where class specs to next line
  Dean Herbert · 2023-01-26 17:12:41 +09:00
  7344d34d5b
• made PathControlPointVisualiser generic
  OliBomby · 2022-12-07 10:13:40 +01:00
  10b5900710
• Partial everything
  Dan Balasescu · 2022-11-27 00:00:27 +09:00
  7bc8908ca9
• Update osu.Game.Rulesets.Osu/Edit/Blueprints/Sliders/Components/PathControlPointPiece.cs

  Co-authored-by: apollo <83023433+apollo-dw@users.noreply.github.com>

  Dean Herbert · 2022-09-15 04:28:07 +09:00
  c203a030c1
• Fix slider rotation causing thousands of new drawables to be created
  Dean Herbert · 2022-09-15 00:51:08 +09:00
  87384db872
• Fix bindable event binds to HitObject directly
  Dean Herbert · 2022-09-12 17:35:56 +09:00
  89e128c0f3
• Automated #nullable processing
  Dan Balasescu · 2022-06-17 16:37:17 +09:00
  f8830c6850
• Fix most open compound words in identifiers being closed
  Joseph Madamba · 2021-12-27 20:26:28 -08:00
  7de43e3aba
• Fix right click deselecting clicked path piece with control held
  Bartłomiej Dach · 2021-12-22 08:55:26 +01:00
  e22745397d
• Fix selections including head not correctly dragging if not started from head
  Bartłomiej Dach · 2021-12-21 12:35:48 +01:00
  e715bff535
• Fix selecting control points without control not deselecting other selected points
  Bartłomiej Dach · 2021-12-20 22:41:24 +01:00
  5ef4e23335
• Fix releasing mouse after drag deselecting dragged point
  Bartłomiej Dach · 2021-12-20 22:41:23 +01:00
  bf8c87e9b7
• Implement drag operation for multiple path control points
  Bartłomiej Dach · 2021-12-20 21:29:57 +01:00
  d2417beeac
• Change control point piece selection logic to allow dragging multiple
  Bartłomiej Dach · 2021-12-20 21:18:38 +01:00
  a9408485cc
• Move slider path point drag handling to visualiser
  Bartłomiej Dach · 2021-12-20 20:56:06 +01:00
  b0ca82e1e5
• Apply batch fixing of built-in types using var
  Dean Herbert · 2021-10-27 13:04:41 +09:00
  6944151486
• Remove bindable usage in PathControlPoint

  This is quite a breaking change, but I think it is beneficial due to the large amount of usage of this class.
  
  I originally intended just to remove the allocations of the two delegates handling the `Changed` flow internally, but as nothing was really using the bindables for anything more than a general "point has changed" case, this felt like a better direction.

  Dean Herbert · 2021-08-26 12:33:53 +09:00
  6dcd9427ac
• Update usages of IHasTooltip in line with framework localisation changes
  Bartłomiej Dach · 2021-06-25 19:10:04 +02:00
  50c27d2635
• Handle control point drag revert
  Dean Herbert · 2021-04-16 15:45:24 +09:00
  2949a6bbdc
• Split out common logic into private method and add inline comment for future visitors
  Dean Herbert · 2021-04-13 15:35:57 +09:00
  fbc6fb8fc5
• Don't update path type once immediately
  Naxess · 2021-04-12 19:18:22 +02:00
  d9e3276d0e
• Correct 4+ point perfect curves to Bezier
  Naxess · 2021-04-08 12:33:43 +02:00
  9a675a2219
• Simplify slider path bindings

  Adds a slight performance overhead, but solves the memory leak and makes the code much easier to follow.

  Naxess · 2021-04-08 03:21:56 +02:00
  d6490899e2
• Convert pathTypes to local variable

  Not entirely sure what holds the reference to pathTypes now (the binding to`slider.Path.ControlPoints` maybe?), but this does seem to work still.

  Naxess · 2021-04-08 01:43:06 +02:00
  d1d56c636a
• Track path type changes for PointsInSegment
  Naxess · 2021-04-07 17:19:12 +02:00
  b8ab1c7682
• Check current point instead of start point

  Since each control point will call this when the path updates, the previous would correct the start segment 3 times instead of just once.
  
  This fixes that.

  Naxess · 2021-03-31 20:25:46 +02:00
  5022a78e80
• Move updatePathTypes to PathControlPointPiece

  Here we produce a local bound copy of the path version, and bind it to update the path type.
  
  This way, if the path version updates (i.e. any control point changes type or position), we check that all control points have a well-defined path.
  
  Additionally, if the control point piece is disposed of, the GB should also swoop up the subscription because of the local bound copy.

  Naxess · 2021-03-31 20:09:56 +02:00
  75b8f2535f
• Simplify path type maintenance when dragging
  Naxess · 2021-03-24 02:57:47 +01:00
  0bcd38e661
• Update PointsInSegment when adding/removing points

  There was a bug where if you created a slider, moved the last point, and then added a point such that it became a PerfectCurve, it would fail to recover after becoming a Bezier.
  
  This fixes that.

  Naxess · 2021-03-24 02:56:32 +01:00
  5ee280f941
• Maintain path type when dragging/placing
  Naxess · 2021-03-22 15:59:06 +01:00
  067178e537
• Add tooltips for slider path nodes which aren't inheriting
  Dean Herbert · 2021-03-19 16:58:08 +09:00
  27c38db14d
• Give each type of slider path type a unique colour to help visually distinguish them
  Dean Herbert · 2021-03-19 14:00:26 +09:00
  5f31304d05
• Merge pull request #11024 from peppy/fix-slider-point-drag-offset

  Fix slider control point dragging not correctly accounting for drag deadzone

  Dan Balasescu · 2020-12-02 11:10:06 +09:00
  be3fed3072
• Scale slider control point display in line with circle size
  Dean Herbert · 2020-12-01 14:17:36 +09:00
  b256c54619
• Fix slider control point dragging not correctly accounting for drag deadzone
  Dean Herbert · 2020-12-01 13:46:30 +09:00
  c8c1848bb8
• Fix slider path control point blueprint not working correctly
  Dean Herbert · 2020-05-22 18:57:28 +09:00
  af30d1201f
• Create SnapResult class to hold various snapping results
  Dean Herbert · 2020-05-20 21:00:47 +09:00
  c46bfc2532
• Change snapping to be screen space coordinate based
  Dean Herbert · 2020-05-20 21:00:29 +09:00
  3354d48a38
• Make placements happen on mouse down
  smoogipoo · 2020-04-23 12:17:11 +09:00
  8d5732aabd