osu-lazer

Fix typos

Bartłomiej Dach · 2025-09-01 12:01:36 +02:00

e2d661736e

Fix movement via slider while popover closes

NiyazBiyaz · 2025-09-01 13:57:14 +05:00

677c008b4d

Move guard to scale/rotationInfo

NiyazBiyaz · 2025-09-01 13:55:29 +05:00

12430ce464

Add OperationInProgress checking

NiyazBiyaz · 2025-08-31 17:17:17 +05:00

b02093505d

initial pass on updated verifier context usage across most checks

Hivie · 2025-08-11 14:57:14 +01:00

fd6cf680b9

Reword comment to be more coherent

Bartłomiej Dach · 2025-08-06 15:04:29 +02:00

f1f7784272

Fix grid placement aggressively changing tool selection

Salman Alshamrani · 2025-08-05 15:20:04 +03:00

6001d6418b

use TimeSpan for defining thresholds

Hivie · 2025-07-21 12:32:45 +01:00

86369ab403

Add verify check for lowest diff drain time requirement

Hivie · 2025-07-13 02:00:50 +01:00

ccf6d9c173

Merge pull request #33248 from chris-ehmann/fix-distance-snapping-to-stacks

Use stacked position when determining distance snap

Bartłomiej Dach · 2025-05-27 10:49:54 +02:00

c7304fca48

Establish public constant for stacking lenience

Bartłomiej Dach · 2025-05-27 09:31:14 +02:00

f28674502f

Change actualDistance to use StackedEndPosition to match StackedPosition

Co-authored-by: Bartłomiej Dach <dach.bartlomiej@gmail.com>

Chris · 2025-05-26 11:30:04 -07:00

e92205b3eb

Make CheckConcurrentObject ruleset specific

Derrick Timmermans · 2025-05-25 14:19:23 +02:00

0065696248

Change back to using Vector2.Distance instead of length, keep order of before-after consistent

Chris Ehmann · 2025-05-23 22:33:04 -07:00

a4e78a34ac

Change OsuDistanceSnapProvider to use StackedPosition when determining distance between notes

Chris Ehmann · 2025-05-23 12:36:16 -07:00

441c941039

Merge pull request #33115 from bdach/fix-snapping-to-loading-grid

Fix distance snap grid being used before it's ready for use

Dan Balasescu · 2025-05-20 12:46:39 +09:00

e97c757084

Fix crashes when attempting to adjust length of slider whose maximum path length is less than the current beat snap

Closes https://github.com/ppy/osu/issues/32289.

There are two possible choices here: either pulling the lower bound of
the clamp down to `HitObject.Path.CalculatedDistance`, or pulling the
higher bound up to `minDistance`, if it happens to be larger than the
path's calculated distance.

Both options are a bit weird; pulling down can result in unsnapped
sliders when attempting to drag a slider's end when on a lower beat
divisor than was used to place the slider, and pulling up can result in
weird sliders wherein they get extended beyond their path's definition
with a weird linear section at the end without an anchor that is tangent
to the slider shape's end. I decided the first one was less weird, but
I'm open to discuss further.

Bartłomiej Dach · 2025-05-14 13:34:12 +02:00

9b2f25cb93

Fix distance snap grid being used before it's ready for use

Closes https://github.com/ppy/osu/issues/32136.

`DistanceSnapGrid.MaxIntervals` is written to in

	https://github.com/ppy/osu/blob/a360f153f73255d6f78148da17edf2c348af4e94/osu.Game/Screens/Edit/Compose/Components/DistanceSnapGrid.cs#L107-L110

which gets run the first time on `LoadComplete()`:

	https://github.com/ppy/osu/blob/a360f153f73255d6f78148da17edf2c348af4e94/osu.Game/Screens/Edit/Compose/Components/DistanceSnapGrid.cs#L96-L97

meaning it is not valid to attempt to use the grid to snap before it's
loaded, which does actually appear to occur sometimes before this
change.

Bartłomiej Dach · 2025-05-13 11:00:41 +02:00

a09d5468c7

Discard distance snapping result if it results in objects being placed out of playfield bounds

Mainly an issue with "limit distance snap to current time". Reported in
https://discord.com/channels/90072389919997952/1259818301517725707/1369037235797753999.

This slightly changes behaviour of distance snap when the mouse is near
the edges of the screen (will turn off snap rather than clamp to edge as
previously), but I think that's probably fine.

Bartłomiej Dach · 2025-05-07 14:23:35 +02:00

9c40344c9e

Merge pull request #32732 from peppy/vertex-selection-increase

Increase range of vertex selection in polygon generation popover

Bartłomiej Dach · 2025-04-08 09:07:49 +02:00

b1b8601105

Increase range of vertex selection in polygon generation popover

Addresses https://github.com/ppy/osu/discussions/32703.

Dean Herbert · 2025-04-08 15:26:41 +09:00

e990099cd9

Fix editor setup screen sliders not having correct keyboard steps

Closes https://github.com/ppy/osu/issues/32691.

Fixes some extra cases of failure that aren't pointed out in the issue.

Dean Herbert · 2025-04-08 14:45:43 +09:00

f2088496c5

Add explanation of why the logic is in such a bad place

Dean Herbert · 2025-03-12 16:56:16 +09:00

c2de43f677

Fix new combo being toggled when selection is made

Dean Herbert · 2025-03-12 16:52:51 +09:00

6a7a834151

Merge branch 'master' into editor-right-click-as-people-expect

Dean Herbert · 2025-03-12 14:51:28 +09:00

083979e299

Fix edge case allowing almost-zero-length sliders to be placed during distance snapping

Dean Herbert · 2025-03-11 16:17:44 +09:00

23891b1994

Allow grid spacing setting up to 256 pixels

Addresses https://github.com/ppy/osu/discussions/29713.

I think there's valid uses of this apart from just hiding (ie values
between 128 and 256) so let's just get this in.

Dean Herbert · 2025-03-10 14:45:36 +09:00

bbd2c33934

Fix precise movement popover crashing if selection bounding box exceeds playfield size

Closes https://github.com/ppy/osu/issues/32252.

Bartłomiej Dach · 2025-03-07 09:38:14 +01:00

6d22502739

Merge pull request #32158 from bdach/scaling-crash

Fix possible crash when scaling objects in editor

Dean Herbert · 2025-03-04 13:40:41 +09:00

3fe92fb83c

Mark MathHelper.Clamp() as banned API

See previous commit for partial rationale.

There's an argument to be made about the `NaN`-spreading semantics being
desirable because at least something will loudly fail in that case, but
I'm not so sure about that these days. It feels like either way if
`NaN`s are produced, then things are outside of any control, and chances
are the game can probably continue without crashing. And, this move
reduces our dependence on osuTK, which has already been living on
borrowed time for years now and is only awaiting someone brave to go
excise it.

Bartłomiej Dach · 2025-02-28 13:48:22 +01:00

35b0ff80bb

Fix possible crash when scaling objects in editor

The specific fail case here is when `s.{X,Y}` is 0, and
`s{Lower,Upper}Bound` is `Infinity`. Because IEEE math is IEEE math,
`0 * Infinity` is `NaN`.

`MathHelper.Clamp()` is written the following way:

	https://github.com/ppy/osuTK/blob/af742f1afd01828efc7bc9fe77536b54aab8b419/src/osuTK/Math/MathHelper.cs#L284-L306

`Math.{Min,Max}` are both documented as reporting `NaN` when any of
their operands are `NaN`:

	https://learn.microsoft.com/en-us/dotnet/api/system.math.min?view=net-8.0#system-math-min(system-single-system-single)
	https://learn.microsoft.com/en-us/dotnet/api/system.math.max?view=net-8.0#system-math-max(system-single-system-single)

which means that if a `NaN` happens to sneak into the bounds, it will
start spreading outwards in an uncontrolled manner, and likely crash
things.

In contrast, the standard library provided `Math.Clamp()` is written
like so:

	https://github.com/dotnet/runtime/blob/577c36cee56480dec4d4610b35605b5d5836888b/src/libraries/System.Private.CoreLib/src/System/Math.cs#L711-L729

With this implementation, if either bound is `NaN`, it will essentially
not be checked (because any and all comparisons involving `NaN` return
false). This prevents the spread of `NaN`s, all the way to positions
of hitobjects, and thus fixes the crash.

Bartłomiej Dach · 2025-02-28 13:34:00 +01:00

ffef6ae185

Fix sliders not being selectable if the body is hidden but the head is still visible

Closes https://github.com/ppy/osu/issues/31998.

Previously: https://github.com/ppy/osu/commit/1648f2efa306f587714178f113e69d8ad8c4ac02,
https://github.com/ppy/osu/pull/31923.

Oh input handling, how I love ya.

Bartłomiej Dach · 2025-02-27 15:00:29 +01:00

5b318edbfb

Add back right-click-for-new-combo and right-click-delete when in compose mode

Requested too many times to count.

I'm not sure what to do about the code quality of this. It's a bit weird
that there's no way to check the current composition tool from a higher
level.

Also it was discussed IRL that there should be some kind of hinting that
existing notes will be deleted when they are hovered, but I'm not sure
how well this will work in normal mapping flows, since it will display
even in cases that users aren't intending to delete an object. Still
willing to explore this direction though (it's just non-trivial to
implement so I haven't yet).

Dean Herbert · 2025-02-26 17:52:33 +09:00

2738c1a807

Fix "use current distance snap" button incorrectly factoring in last object with velocity

Closes https://github.com/ppy/osu/issues/32003.

Bartłomiej Dach · 2025-02-21 12:52:59 +01:00

de78518fea

Fix selected sliders sometimes not being clickable in editor

Closes https://github.com/ppy/osu/issues/31918.
Regressed with
https://github.com/ppy/osu/commit/1648f2efa306f587714178f113e69d8ad8c4ac02
for obvious reasons.

Dean Herbert · 2025-02-18 13:41:30 +09:00

77e40140e5

Fix nudge operations incurring FP error from coordinate space conversions

Closes https://github.com/ppy/osu/issues/31915.

Reproduction of aforementioned issue requires 1280x720 resolution, which
should also be a good way to confirm that this does anything.

To me this is also equal-parts-bugfix, equal-parts-code-quality PR,
because tell me: what on earth was this code ever doing at
`ComposeBlueprintContainer` level? Nudging by one playfield-space-unit
doesn't even *make sense* in something like taiko or mania.

Bartłomiej Dach · 2025-02-17 15:21:07 +01:00

f37a56c307

Fix code quality

Bartłomiej Dach · 2025-02-03 15:18:03 +01:00

2d6f64e891

Refactor IDistanceSnapProvider to accept slider velocity objects as a reference

Method signatures are also changed to be a lot more explicit as to what
inputs they expect.

Bartłomiej Dach · 2025-02-03 14:00:57 +01:00

a1185df2eb

Avoid moving already placed objects temporally when "limit distance snap to current time" is active

Bartłomiej Dach · 2025-01-31 09:51:13 +01:00

8718483c70

Fix distance snap time part ceasing to work when grid snap is also active

As pointed out in
https://github.com/ppy/osu/pull/31655#discussion_r1935536934.

Bartłomiej Dach · 2025-01-30 14:42:44 +01:00

261a7e537b

Refactor further to avoid weird non-virtual common method

Bartłomiej Dach · 2025-01-24 13:14:31 +01:00

daec91f61d

Fix behavioural change in interaction between grid & distance snap

Bartłomiej Dach · 2025-01-24 13:14:26 +01:00

b04144df54

Simplify code

Bartłomiej Dach · 2025-01-24 13:14:06 +01:00

589035c534

Fix tests

Bartłomiej Dach · 2025-01-24 11:59:07 +01:00

269ade178e

Remove dependence of placement blueprints on IPositionSnapProvider

Bartłomiej Dach · 2025-01-24 11:59:07 +01:00

a6987f5c95

Remove dependence of blueprint containers on IPositionSnapProvider

Bartłomiej Dach · 2025-01-24 11:59:05 +01:00

15b6e28ebe

Merge pull request #31547 from bdach/editor/precise-move

Add precise movement tool to osu! editor

Dean Herbert · 2025-01-20 19:29:22 +09:00

cf032e5e7f

Always select text when an editor slider-textbox is focused

Dean Herbert · 2025-01-20 16:17:39 +09:00

dcdb8d13a9

Remove redundant ToArray() calls in Osu/ManiaHitObjectComposer

Berkan Diler · 2025-01-19 23:27:44 +01:00

b6ce72b6d9

Implement precise movement tool

As mentioned in one of the points in
https://github.com/ppy/osu/discussions/31263.

Bartłomiej Dach · 2025-01-17 14:28:57 +01:00

ebca2e4b4f

1168 Commits