308 Commits

• Fix osu!mania legacy skin WidthForNoteHeightScale not being used (#35050)

  * Add osu!mania legacy skin widthForNoteHeightScale
  
  * Ensure WidthForNoteHeightScale correctly defaults to MinimumColumnWidth

  qinvvv · 2025-09-19 10:53:25 +09:00
  b91ff8a5c5
• Fix hold notes being missed after rewinding gameplay

  Closes https://github.com/ppy/osu/issues/27589.
  
  Follows osu! spinner precedent in storing the holding state to the
  judgement result rather than attempting to keep it in the DHO (which is
  prone to getting dropped on pool re-use).

  Bartłomiej Dach · 2025-05-19 12:23:47 +02:00
  59490054db
• Merge branch 'master' into gameplay-leaderboard-skinnable
  Bartłomiej Dach · 2025-05-07 10:45:51 +02:00
  5b61761bbd
• Make column spacing lookups easy to use
  Salman Alshamrani · 2025-04-30 03:59:41 +03:00
  d63f9533b1
• Convert gameplay leaderboard to skinnable component

  This PR converts the leaderboard into a full-fledged skinnable component
  that can be manipulated by users at will.
  
  Notably, this finally allows https://github.com/ppy/osu/issues/20422 to
  be fixed - although it's a very mixed bag, for several reasons:
  
  - Because of taiko players' refusal to see reason^W^W^W^Winsistence on
    keeping stable behaviours related to aspect ratio treatment, I have to
    assume the worst case scenario, which means than on typical
    resolutions like 16:9 (or even worse, 4:3), the leaderboard will
    likely not occupy as much vertical space as it probably could.
  
  - Additionally, there's the problem of where to put the spectator list.
    I settled on putting it to the right of the leaderboard, but that's
    kind of janky, because the leaderboard sometimes collapses and
    sometimes fully hides, leading to a very awkward space left behind. If
    we had the capability to anchor elements to other elements, maybe this
    could be resolved, but for now, I'm not sure what to do. I think if
    some users are bothered by it they can move it where they want it. Or
    delete it.

  Bartłomiej Dach · 2025-04-24 13:10:30 +02:00
  59b826c321
• Improve handling for top-anchored judgement positions in osu!mania
  Salman Alshamrani · 2025-03-12 03:05:10 -04:00
  5a5246a407
• Add support for legacy osu!mania barline height and colour spec
  Dean Herbert · 2025-02-28 15:13:13 +09:00
  cb29459a1e
• Add basic setup for mania legacy barline implementation
  Dean Herbert · 2025-02-28 14:43:00 +09:00
  3e8dafa3c5
• Flip the Y offset of skin judgement pieces on flipped scroll direction
  Salman Alshamrani · 2025-02-10 01:52:50 -05:00
  1e06c5cc4a
• Merge branch 'master' into mobile-fix-mania
  Dean Herbert · 2025-01-24 17:03:00 +09:00
  56a611b47e
• Merge spectator list classes into one skinnable
  Bartłomiej Dach · 2025-01-17 11:23:14 +01:00
  3c4bfc0a01
• Add skinnable spectator list to default skins
  Bartłomiej Dach · 2025-01-15 14:29:53 +01:00
  99c7e164dc
• Make mania judgements relative to the hit target position

  This improves display in portrait screen, where the stage is scaled up.

  Salman Alshamrani · 2024-12-31 12:25:58 -05:00
  1e08b3dbda
• Merge branch 'master'
  Huo Yaoyuan · 2024-11-30 01:07:08 +08:00
  fa3c95c296
• Enable selected rules for usage
  Huo Yaoyuan · 2024-11-28 22:33:03 +08:00
  fced254594
• Use TryGetValue wherever possible

  Rider says so.

  Dean Herbert · 2024-11-22 19:11:16 +09:00
  c844d65a81
• Fix stage line alignment in mania not matching stable
  Salman Alshamrani · 2024-11-12 04:07:27 -05:00
  3268008d21
• Decouple legacy mania combo counter from abstract eldritch entity
  Bartłomiej Dach · 2024-09-11 11:44:57 +02:00
  d8a745ec04
• Component -> Lookup
  Dean Herbert · 2024-08-23 14:48:50 +09:00
  48cfd77ee8
• Remove remaining early base lookup calls which were missed
  Dean Herbert · 2024-08-22 20:13:28 +09:00
  46d55d5e61
• Remove requirement of base calls to ensure user skin container layouts are retrieved
  Dean Herbert · 2024-08-22 19:14:30 +09:00
  1435fe24ae
• Rename Target lookup to Component
  Dean Herbert · 2024-08-22 19:00:28 +09:00
  b57b8168a6
• Move GlobalSkinnableContainers to global scope
  Dean Herbert · 2024-08-22 18:46:07 +09:00
  9a21174582
• Rename GameplaySkinComponentLookup -> SkinComponentLookup
  Dean Herbert · 2024-08-22 18:46:03 +09:00
  36b4013fa6
• Rename SkinComponentsContainerLookup to GlobalSkinnableContainerLookup
  Dean Herbert · 2024-08-22 18:39:36 +09:00
  f37cab0c6e
• Fix mania combo counter positioning break on centre anchor
  Salman Ahmed · 2024-08-20 12:39:51 +09:00
  4d74625bc7
• Try make code look better
  Salman Ahmed · 2024-08-15 17:03:08 +09:00
  7427237873
• Update code order to match everything else
  Salman Ahmed · 2024-08-15 16:57:29 +09:00
  358572ebb3
• Fix beatmap skin on mania breaking HUD apart
  Salman Ahmed · 2024-08-15 16:55:05 +09:00
  a421231aad
• Actually bring back position-flipping logic and disable "closest" anchor
  Salman Ahmed · 2024-08-15 15:50:32 +09:00
  66adddbfb8
• Remove x symbol from argon mania combo counter
  Salman Ahmed · 2024-08-15 15:08:35 +09:00
  3a4546d62d
• Remove position-flipping logic from mania combo counters for now

  We need a general method to do this amicably, such as an HUD target that flips the position of its children when the direction is flipped. Something to consider later.

  Salman Ahmed · 2024-08-15 15:02:18 +09:00
  ff1ab2bb0e
• Fix incorrect anchor handling in ArgonManiaComboCounter
  Dean Herbert · 2024-08-14 15:12:23 +09:00
  7c142bcedf
• Simplify argon mania combo counter implementation by sharing with base counter
  Dean Herbert · 2024-08-09 15:46:57 +09:00
  161734af95
• Remove unnecessary UsesFixedAnchor specifications
  Dean Herbert · 2024-08-09 15:39:01 +09:00
  3f20f05801
• Remove SupportsClosestAnchor for the time being

  This may have had a good reason to be added, but I can't find that
  reason, so let's keep things simple for the time being.

  Dean Herbert · 2024-08-09 15:30:21 +09:00
  7666e8b932
• Update in line with new changes
  Dean Herbert · 2024-08-09 14:55:01 +09:00
  80c814008f
• Merge branch 'master' into mania-combo-counter
  Dean Herbert · 2024-08-09 00:19:17 +09:00
  e645651ef4
• Fix legacy skin hold note bodies not appearing when scrolling upwards

  - Closes https://github.com/ppy/osu/issues/28567.
  - Regressed in https://github.com/ppy/osu/pull/28466.
  
  Bit of a facepalm moment innit...

  Bartłomiej Dach · 2024-06-25 10:35:36 +02:00
  1eac0c622a
• Fix nullability insepction
  Dean Herbert · 2024-06-18 15:13:52 +08:00
  e6187ebec0
• Adjust calls to DrawableExtensions.With<T>()
  Bartłomiej Dach · 2024-06-18 07:41:20 +02:00
  366ba26cb6
• Fix missing texture on extremely long hold notes
  Dan Balasescu · 2024-06-13 15:19:41 +09:00
  1ff20cc13d
• Fix legacy mania note body animation not resetting sometimes

  Hopefully closes https://github.com/ppy/osu/issues/28284.
  
  As far as I can tell this is a somewhat difficult one to reproduce
  because it relies on a specific set of circumstances (at least the
  reproduction case that I found does). The reset to frame 0 would
  previously be called explicitly when `isHitting` changed:
  
      https://github.com/ppy/osu/blob/182ca145c78432f4b832c8ea407e107dfeaaa8ad/osu.Game.Rulesets.Mania/Skinning/Legacy/LegacyBodyPiece.cs#L144
  
  However, it can be the case that `bodyAnimation` is not loaded at the
  point of this call. This is significant because
  `SkinnableTextureAnimation` contains this logic:
  
      https://github.com/ppy/osu/blob/182ca145c78432f4b832c8ea407e107dfeaaa8ad/osu.Game/Skinning/LegacySkinExtensions.cs#L192-L211
  
  which cannot be moved any earlier (because any earlier the `Clock` may
  no longer be correct), and also causes the animation to be seeked
  forward while it is stopped.
  
  I can't figure out a decent way to layer this otherwise (by scheduling
  or whatever), so this commit is just applying the nuclear option of just
  seeking back to frame 0 on every update frame in which the body piece is
  not being hit.

  Bartłomiej Dach · 2024-05-28 15:29:15 +02:00
  bf0040447c
• Clamp only on horizontal sides
  Salman Ahmed · 2024-03-06 18:40:20 +03:00
  672f645cba
• Add comments
  Salman Ahmed · 2024-03-01 22:57:13 +03:00
  f1b66da469
• Fix osu!mania key images potentially showing gaps between columns
  Salman Ahmed · 2024-03-01 22:49:12 +03:00
  e0c73eb362
• Fix selected legacy skins crashing on zero-length hold notes

  Closes https://github.com/ppy/osu/issues/27134.

  Bartłomiej Dach · 2024-02-12 08:33:08 +01:00
  36005a5449
• Rename JudgementPiece to TextJudgementPiece
  Dean Herbert · 2024-01-25 19:31:57 +09:00
  dda96d7106
• Fix failing tests
  Salman Ahmed · 2023-12-30 07:41:55 +03:00
  02f5ea200e
• Add very basic argon mania combo counter implementation
  Salman Ahmed · 2023-12-30 05:29:44 +03:00
  408287e086