51 Commits

• Fix incorrect translation of note freezing logic
  Bartłomiej Dach · 2025-05-20 08:58:11 +02:00
  bd703b60f9
• Fix hold notes being missed after rewinding gameplay

  Closes https://github.com/ppy/osu/issues/27589.
  
  Follows osu! spinner precedent in storing the holding state to the
  judgement result rather than attempting to keep it in the DHO (which is
  prone to getting dropped on pool re-use).

  Bartłomiej Dach · 2025-05-19 12:23:47 +02:00
  59490054db
• Remove remaining usages of LargeTickHit in mania
  Bartłomiej Dach · 2023-10-12 11:16:51 +02:00
  a42e75452e
• Actually use the judgement
  Dan Balasescu · 2023-10-09 11:49:54 +09:00
  f0da7f016d
• Add mania hold note body + combo break judgement
  Dan Balasescu · 2023-10-09 09:47:00 +09:00
  9415fe4446
• Remove HoldNoteTickJudgement
  Dan Balasescu · 2023-10-09 09:31:45 +09:00
  b2d9c95441
• Automated pass
  Dean Herbert · 2023-06-24 01:00:03 +09:00
  0ab0c52ad5
• Automated #nullable processing
  Dan Balasescu · 2022-06-17 16:37:17 +09:00
  f8830c6850
• Make new health increase values mania-specific
  Bartłomiej Dach · 2020-10-03 12:16:22 +02:00
  309714081f
• Use new hit results in mania
  smoogipoo · 2020-09-29 16:33:38 +09:00
  b1877b649b
• Fix some judgements potentially giving wrong score
  smoogipoo · 2020-08-18 19:51:16 +09:00
  da07354f05
• Increase PERFECT from 320 to 350 score
  smoogipoo · 2020-07-28 17:59:52 +09:00
  375dad0878
• Fix 1M score being possible with only GREATs in mania
  smoogipoo · 2020-06-22 19:52:23 +09:00
  4d30761ce3
• Make hold note ticks affect combo score rather than bonus
  smoogipoo · 2020-06-21 17:42:17 +09:00
  19eb6fad7f
• Fix hitobjects with unknown lifetimes by enforcing non-null judgement

  We've seen multiple cases where DrawableHitObject are stuck in the lifetime management container
  due to not implementing a judgement (meaning they are never "hit" or "missed"). To avoid this going forward
  CreateJudgement() must be implemented and return a non-null judgement.
  
  This fixes BananaShower and JuiceStreams in osu!catch.
  
  This also makes HitObject abstract and cleans up convert HitObject implementations.

  Dean Herbert · 2020-02-23 13:49:06 +09:00
  ffc7eaa3f2
• Adjust mania HP increase values
  smoogipoo · 2020-01-07 15:24:33 +09:00
  dfa6575f75
• Apply more cases/fix some existing ones
  smoogipoo · 2019-05-07 13:23:09 +09:00
  13b9b04bb8
• Merge remote-tracking branch 'origin/master' into fix-new-inspections

  # Conflicts:
  #	osu.Game.Rulesets.Catch/Judgements/CatchDropletJudgement.cs
  #	osu.Game.Rulesets.Catch/Judgements/CatchJudgement.cs
  #	osu.Game.Rulesets.Mania/Scoring/ManiaScoreProcessor.cs
  #	osu.Game.Rulesets.Osu/Replays/OsuAutoGenerator.cs
  #	osu.Game.Rulesets.Osu/UI/Cursor/CursorTrail.cs
  #	osu.Game.Tests/Visual/SongSelect/TestCaseBeatmapScoresContainer.cs
  #	osu.Game/Graphics/OsuFont.cs
  #	osu.Game/Online/API/Requests/Responses/APILegacyScoreInfo.cs
  #	osu.Game/Overlays/Profile/Header/BadgeContainer.cs
  #	osu.Game/Overlays/Profile/ProfileHeader.cs
  #	osu.Game/Screens/Select/PlaySongSelect.cs
  #	osu.Game/Skinning/LegacySkinDecoder.cs

  smoogipoo · 2019-05-07 13:20:17 +09:00
  d7c09e7dbd
• Implement hp increase for mania
  smoogipoo · 2019-04-22 17:04:18 +09:00
  4c5f41e40f
• Apply more missed cases
  Dean Herbert · 2019-04-01 12:44:46 +09:00
  c39c37a18d
• Update licence header (and remove year)
  Dean Herbert · 2019-01-24 17:43:03 +09:00
  8617aaa2a7
• Make Rulesets.Mania use the new judgement result structure
  smoogipoo · 2018-08-02 20:36:54 +09:00
  807794d512
• Change default IsBonus definition and remove unnecessary overrides
  Dean Herbert · 2018-06-29 17:07:08 +09:00
  c0b65a6a73
• Split AffectsCombo into IsBonus
  Crusensis · 2018-06-09 18:14:33 -07:00
  fbc0cd6f5f
• Fix hold notes never dying
  smoogipoo · 2018-05-16 19:43:01 +09:00
  2fc1939d65
• Normalize all the line endings
  Dean Herbert · 2018-04-13 18:26:38 +09:00
  32a74f95a5
• Move mania's HitWindows to osu.Game
  smoogipoo · 2018-02-02 17:52:55 +09:00
  a0c1662fb7
• Update licence headers
  Dean Herbert · 2018-01-05 20:21:19 +09:00
  37d393bca0
• move HitResult in Scoring namespace to replace HitCount
  Aergwyn · 2017-12-30 21:23:18 +01:00
  ccb69d16d9
• Remove AffectsAccuracy for now
  smoogipooo · 2017-09-13 15:44:03 +09:00
  05ac23f99a
• Remove NumericAccuracyResult from ManiaJudgement
  smoogipooo · 2017-09-12 22:33:39 +09:00
  756d7527da
• Add AffectsAccuracy to Judgement
  smoogipooo · 2017-09-12 19:39:44 +09:00
  3af8345068
• Apply CI fixes
  Dean Herbert · 2017-09-12 18:36:19 +09:00
  86de4fa2e2
• Merge remote-tracking branch 'upstream/master' into judgement-revamp
  Dean Herbert · 2017-09-12 17:46:21 +09:00
  1194e46ef1
• Add judgement text displays to osu!mania
  smoogipooo · 2017-09-11 17:56:02 +09:00
  df0a31bf2a
• Combine Judgement.HitResults into one.
  Dean Herbert · 2017-09-06 17:01:48 +09:00
  84c22df3f5
• Reshuffle namespaces
  Dean Herbert · 2017-07-26 13:22:46 +09:00
  fce580d717
• Fix hold note ticks changing combo.
  smoogipooo · 2017-05-26 19:56:35 +09:00
  9ec6e0b692
• Add hold note tick judgement.
  smoogipooo · 2017-05-26 19:29:47 +09:00
  02f582a3f8
• Add hold note tail judgement.
  smoogipooo · 2017-05-26 19:28:14 +09:00
  4c67c13410
• Implement base mania judgement score.
  smoogipooo · 2017-05-26 19:22:17 +09:00
  43a7923199
• Implement basic hold note + tick input.
  smoogipooo · 2017-05-24 20:45:01 +09:00
  dcf879687d
• Update HitWindows.cs
  Dan Balasescu · 2017-05-22 16:34:38 +09:00
  6f00f7f0d0
• Add helper method to easily compare time offset to hit windows.
  smoogipooo · 2017-05-22 16:28:44 +09:00
  62c7e97a5f
• Forgot license header.
  smoogipooo · 2017-05-22 16:15:52 +09:00
  0f3cf18345
• Add xmldoc.
  smoogipooo · 2017-05-22 16:09:32 +09:00
  9a578e036e
• Add ManiaHitResult to ManiaJudgement.
  smoogipooo · 2017-05-22 14:10:53 +09:00
  d0ddd62f84
• Add xmldoc to HitWindows.cs.
  smoogipooo · 2017-05-10 17:29:54 +09:00
  3b533de8ac
• Cleanups.
  smoogipooo · 2017-05-09 20:55:20 +09:00
  5b323ad483
• Add hit windows to Note/HoldNote.
  smoogipooo · 2017-05-03 13:51:44 +09:00
  d11e5d0060