183 Commits

• Fix grammar in comment
  Bartłomiej Dach · 2025-08-05 10:48:17 +02:00
  50daae399b
• Fix special cases of mania beatmaps not playing sliding samples

  Apparently mania sliders are a thing. See https://github.com/ppy/osu/pull/34500#issuecomment-3150610188

  Salman Alshamrani · 2025-08-05 10:25:39 +03:00
  03dae97ff3
• Only play hold note sliding samples when beatmap is converted
  Salman Alshamrani · 2025-08-04 12:27:55 +03:00
  4171c3a241
• NRT refactorings + rename generators to match usage

  In particular, "EndTimeObject" is no longer correct - it's strictly used
  for spinners and not holds.

  Dan Balasescu · 2024-12-06 17:16:04 +09:00
  e703d9e814
• Rename LegacyPatternGenerator to stop naming conflicts
  Dan Balasescu · 2024-12-06 16:40:29 +09:00
  e8728abc00
• Simplify implementation
  Dan Balasescu · 2024-12-06 16:40:29 +09:00
  e65f8ba7a0
• Split out + rename PassThroughPatternGenerator

  Better symbolises the intent of this generator which is to convert
  hitobjects in their most simple forms - anything with an end time
  converts to a hold or otherwise converts to a normal note.

  Dan Balasescu · 2024-12-06 16:40:29 +09:00
  8e1bd98386
• Update HasFlag usages
  Dean Herbert · 2024-07-03 00:19:04 +09:00
  5350945340
• Refactor pattern generation to not require ManiaBeatmap
  Dan Balasescu · 2024-03-28 22:32:27 +09:00
  64399e9dd9
• Re-fix mania conversion following new discoveries
  Dan Balasescu · 2023-12-08 16:33:10 +09:00
  0fe2e1e8d6
• Fix FP precision issue when converting mania beatmaps
  Dan Balasescu · 2023-12-07 12:26:02 +09:00
  d6cb8b70bb
• Use IHasPath instead of IHasDistance for mania/taiko
  Dan Balasescu · 2023-11-29 17:30:21 +09:00
  1c3bcbd548
• Fix mania and taiko slider conversion distance
  Dan Balasescu · 2023-11-28 21:14:56 +09:00
  16577829e2
• Make not extension method
  Dean Herbert · 2023-09-15 18:13:04 +09:00
  56cc2b62f0
• Move to extension method and throw on non-legacy ruleset
  Dean Herbert · 2023-09-15 17:38:34 +09:00
  0031da76ff
• Make rounding error even less precise

  Basically matching the old code more closely to avoid too much precision
  from doing math in a slightly different way.

  Dean Herbert · 2023-09-12 18:41:09 +09:00
  4ecc4632aa
• Remove braces
  Bartłomiej Dach · 2023-09-07 18:47:03 +02:00
  e71fef4b6a
• Remove all usage of LegacyDifficultyControlPoint
  Dean Herbert · 2023-09-07 17:41:57 +09:00
  b34a36f6ce
• Rename SliderVelocity to SliderVelocityMultiplier to distinguish from Velocity
  Dean Herbert · 2023-09-06 19:01:08 +09:00
  1a37543d28
• Automated pass
  Dean Herbert · 2023-06-24 01:00:03 +09:00
  0ab0c52ad5
• removing using
  OliBomby · 2023-04-26 13:22:13 +02:00
  39d9f0c3f5
• Remove IContext & add IHasGenerateTicks
  OliBomby · 2023-04-26 13:10:57 +02:00
  6c70948681
• clean up code stuff
  OliBomby · 2023-04-25 19:06:29 +02:00
  e4b64bdc3e
• Add LegacyContext
  OliBomby · 2023-04-25 12:12:46 +02:00
  ea1e6e9798
• made the SampleControlPoint and DifficultyControlPoint obsolete
  OliBomby · 2023-04-25 11:34:09 +02:00
  a4c6850ab2
• Use new ArgumentNullException.ThrowIfNull throw-helper API
  Berkan Diler · 2022-12-22 21:27:59 +01:00
  08d2fbeb8e
• Automated #nullable processing
  Dan Balasescu · 2022-06-17 16:37:17 +09:00
  f8830c6850
• Move FastRandom to LegacyRandom in osu.Game project
  Dean Herbert · 2022-04-28 17:47:32 +09:00
  93db6c6bb0
• Merge pull request #15255 from goodtrailer/node-samples-ilist

  Change IHasRepeats.NodeSamples to IList from List

  Dean Herbert · 2021-10-28 14:24:26 +09:00
  5c7623e68e
• Apply batch fixing of built-in types using var
  Dean Herbert · 2021-10-27 13:04:41 +09:00
  6944151486
• Change IHasRepeats.NodeSamples to IList from List
  goodtrailer · 2021-10-23 01:59:07 -07:00
  4440b9ca11
• Merge branch 'master' into no-more-difficulty-control-points-info
  smoogipoo · 2021-10-08 18:41:17 +09:00
  bc37cb6f43
• Copy BaseDifficulty to Beatmap<T> and move all write operations across
  Dean Herbert · 2021-10-06 15:10:45 +09:00
  b339c149d8
• Convert usages of BeatmapDifficulty to IBeatmapDifficultyInfo
  Dean Herbert · 2021-10-01 16:55:50 +09:00
  a92d499d7a
• Merge branch 'master' into no-more-difficulty-control-points-info
  Dean Herbert · 2021-09-28 13:53:56 +09:00
  46bafb6252
• Use true comparison rather than null coalesce fallback

  Co-authored-by: Bartłomiej Dach <dach.bartlomiej@gmail.com>

  Dean Herbert · 2021-09-21 14:08:54 +09:00
  93e33fa94d
• Avoid allocating list storage in Pattern until first usage

  Patterns can often be constructed only to never be used.

  Dean Herbert · 2021-09-20 16:02:03 +09:00
  98f1c1cc29
• Avoid LINQ overhead in PatternGenerator.isValid
  Dean Herbert · 2021-09-20 15:09:27 +09:00
  03291e3897
• Reduce overhead of ColumnHasObject calls by storing column usage separately
  Dean Herbert · 2021-09-20 15:09:27 +09:00
  0d58530dbe
• Move approach rate to EffectControlPoint
  Dean Herbert · 2021-09-03 16:58:16 +09:00
  a3d9ab1e2e
• Update usages of DifficultyPointAt
  Dean Herbert · 2021-09-03 16:58:16 +09:00
  071c56e90b
• Remove empty <returns> xmldoc
  Dean Herbert · 2021-04-12 17:46:14 +09:00
  b5954a55ad
• Fix spacing
  smoogipoo · 2021-02-25 21:38:21 +09:00
  cf4c88c647
• Update HasFlag usages to HasFlagFast
  smoogipoo · 2021-02-25 15:38:56 +09:00
  dff1d80f39
• Add comment about stable calculation
  smoogipoo · 2020-10-12 15:27:33 +09:00
  ac4290dfb6
• Use integer calculations to replicate stable's slider conversion
  smoogipoo · 2020-10-09 21:22:20 +09:00
  08f3481b59
• Fix incorrect probability calculation for hitobject conversion
  smoogipoo · 2020-10-09 21:20:00 +09:00
  5f19081db6
• Fix spinner conversion not considering stacking + forced initial column
  smoogipoo · 2020-10-09 21:13:04 +09:00
  9d09503ace
• Avoid float precision error in mania conversion
  smoogipoo · 2020-09-07 16:30:05 +09:00
  ecc9c2957f
• Replace iterated addition with rounding
  Bartłomiej Dach · 2020-06-30 20:16:19 +02:00
  39cfbb67ad