170 Commits

• Apply code feedback and also resize catcher trails when any is shown
  Darius Wattimena · 2024-10-24 23:17:47 +02:00
  5e642cbce7
• Fix osu!catch trail spacing not matching osu!stable expectations

  Closes https://github.com/ppy/osu/issues/28997.

  Dean Herbert · 2024-08-19 15:01:16 +09:00
  ca92c116b5
• Adjust calls to GetContainingInputManager()
  Bartłomiej Dach · 2024-06-18 07:41:19 +02:00
  659505f711
• Use IsRewinding in a few more places
  Bartłomiej Dach · 2023-07-08 13:32:24 +02:00
  9dae806734
• Move judgement result revert logic to Playfield

  Previously, some judgement results were not reverted
  when the source DHO is not alive (e.g. frames skipped in editor).
  Now, all results are reverted in the exact reverse order.

  ekrctb · 2023-01-19 19:57:13 +09:00
  812a4b412a
• Remove #nullable disable from Catch.UI
  ekrctb · 2023-01-15 17:29:35 +09:00
  b88091262d
• Partial everything
  Dan Balasescu · 2022-11-27 00:00:27 +09:00
  7bc8908ca9
• Fix incorrect case in CatcherArea parameter
  Dean Herbert · 2022-07-06 14:28:50 +09:00
  c95eb2d2c1
• Automated #nullable processing
  Dan Balasescu · 2022-06-17 16:37:17 +09:00
  f8830c6850
• Moved clear plate logic to Catcher class
  Darius Wattimena · 2021-11-18 20:03:41 +01:00
  95891bc655
• Fixed an issue where banana showers don't clear the plate when missing the last banana
  Darius Wattimena · 2021-11-14 20:43:31 +01:00
  2c4f1817d3
• Update with keybinding changes
  smoogipoo · 2021-09-16 18:26:12 +09:00
  f9d5abff8a
• Match casing in enum value
  smoogipoo · 2021-08-02 15:08:42 +09:00
  3e56388ba8
• Fix comment
  ekrctb · 2021-07-30 15:44:09 +09:00
  4e2f928d65
• Prevent catcher trail generation while rewinding
  ekrctb · 2021-07-29 17:32:38 +09:00
  a204ef39dd
• Manage catcher trails by lifetime entries
  ekrctb · 2021-07-29 17:12:01 +09:00
  81f23e1111
• Replace "end glow" terminology with "hyper-dash after-image"

  Because the is "end glow" is when a hyper-dash is *started*, the name was confusing.
  The "after-image" was already used in the code as a synonym of "end glow" inconsistently.

  ekrctb · 2021-07-28 19:11:22 +09:00
  a960a28d06
• Avoid internal property by using ChildrenOfType
  ekrctb · 2021-07-28 18:13:43 +09:00
  0bf04ece34
• Avoid usage of LINQ in last dash trail computation
  ekrctb · 2021-07-27 19:11:08 +09:00
  846f539428
• Move catcher trail generation logic to CatcherArea
  ekrctb · 2021-07-27 19:07:37 +09:00
  da69867fd4
• Move catcher base size constant to Catcher.
  ekrctb · 2021-07-21 16:43:24 +09:00
  d9f9ad35be
• Add some doc comment to CatcherArea
  ekrctb · 2021-07-21 16:40:35 +09:00
  30777795ce
• Rename CatcherArea.MovableCatcher to Catcher
  ekrctb · 2021-07-21 16:28:31 +09:00
  94678064ff
• Create Catcher in CatchPlayfield
  ekrctb · 2021-07-19 19:44:40 +09:00
  97059a9f50
• Resolve DroppedObjectContainer via DI
  ekrctb · 2021-06-24 16:09:13 +09:00
  ae09c23e4e
• Add DroppedObjectContainer class
  ekrctb · 2021-06-24 15:51:54 +09:00
  16d5893535
• Move catcher movement logic of Catcher to CatcherArea
  ekrctb · 2021-06-11 15:39:06 +09:00
  7f7c2c73e0
• more specific type droppedObjectContainer
  ekrctb · 2020-12-09 10:35:01 +09:00
  ccca7e0b25
• Move catcher state changing logic to OnNewResult method
  ekrctb · 2020-12-08 14:28:30 +09:00
  0213f77b4b
• Fix depth of dropped objects
  ekrctb · 2020-12-04 10:21:54 +09:00
  e82ca66d3e
• Move more logic to Catcher from CatcherArea
  ekrctb · 2020-12-03 16:44:36 +09:00
  5a5c956ced
• Refactor fruit dropping code

  - The repeated `Remove` call was quadratic complexity.
    Now it is linear time.

  ekrctb · 2020-12-03 16:44:36 +09:00
  2eb2c934cc
• Use more specific type for caught object
  ekrctb · 2020-12-03 16:44:36 +09:00
  8d32cca5d6
• Remove unused method
  ekrctb · 2020-12-03 16:44:36 +09:00
  a231a4aa6d
• Don't delay caught fruit loading

  It is not needed anymore because
  some code in DCHO is moved from `load` to constructor.

  ekrctb · 2020-12-03 16:44:36 +09:00
  af45e8d97b
• Convert switch expression to switch statement
  ekrctb · 2020-12-01 09:50:52 +09:00
  d1076778fd
• Don't use CreateDrawableRepresentation in CatcherArea
  ekrctb · 2020-11-30 19:02:49 +09:00
  05aaa377e7
• Remove redundant StaysOnPlate
  ekrctb · 2020-11-25 07:59:45 +09:00
  3c3229ac4b
• Move members to PalpableCatchHitObject
  ekrctb · 2020-11-24 19:57:37 +09:00
  ab7251d742
• Use new hit results in catch
  smoogipoo · 2020-09-29 16:33:38 +09:00
  4ca9a69de2
• Encapsulate combo display better
  Bartłomiej Dach · 2020-09-12 22:40:34 +02:00
  fcf3a1d13c
• Move osu!catch combo counter display to inside CatcherArea
  Salman Ahmed · 2020-09-01 20:17:21 +03:00
  ba8a4eb6f0
• Reintroduce PalpableCatchHitObject at data level
  Bartłomiej Dach · 2020-08-20 19:06:26 +02:00
  28534c1599
• Fix osu!catch dropping fruit appearing above the plate instead of behind
  Dean Herbert · 2020-07-15 20:58:09 +09:00
  2624862e32
• Standardize osu!catch coordinate system

  There were two coordinate systems used:
  - 0..512 (used in osu!stable)
  - 0..1 (relative coordinate)
  
  This commit replaces the usage of
  the relative coordinate system to
  the coordinate system of 0..512.

  ekrctb · 2020-07-02 00:21:45 +09:00
  3278a1d7d8
• Mark Catcher.additiveTarget to never be null

  And provide empty containers instead.

  Salman Ahmed · 2020-04-22 05:04:07 +03:00
  95de2c6f7f
• Simplify process of adding catcher trails
  Salman Ahmed · 2020-04-21 11:44:39 +03:00
  ee62739b08
• Change AdditiveTarget into a set method
  Salman Ahmed · 2020-04-04 19:33:52 +03:00
  19f39fe632
• Fix additive target accidentally clears all of the added containers

  It sets the AdditiveTarget on the object initializer but then the catcher is set to Child which wipes up all of the existing children (containers added by Catcher through AdditiveTarget setter)

  Salman Ahmed · 2020-03-26 09:14:44 +03:00
  fecafc2e48
• Split out CatcherArea nested classes and reorder methods
  Dean Herbert · 2020-03-13 12:59:30 +09:00
  1733519c3a