44832 Commits

This Branch

This Branch

All Branches

• Merge pull request #14988 from peppy/remove-gameplay-mod-bindable-storage

  Remove local overridden storage of `Mods` in `Player`

  Dan Balasescu · 2021-10-07 17:36:23 +09:00
  0e0779e45b
• Merge pull request #14989 from peppy/osu-game-test-scene-improvements

  Improve performance of `OsuGameTestScene` based tests

  Dan Balasescu · 2021-10-07 17:30:50 +09:00
  061697b4cd
• Group applicable comment above new addition
  Dean Herbert · 2021-10-07 16:50:05 +09:00
  d0001f760d
• Fix hidden test failures
  Dean Herbert · 2021-10-07 16:26:24 +09:00
  c41271ea78
• Fix TestOverlayClosing occasionally failing due to running too fast
  Dean Herbert · 2021-10-07 15:55:29 +09:00
  0bd5136a29
• Always use circles intro for OsuGame tests

  The triangles intro tracks video time, which is not adjusted based on
  the game's playback rate (ie. it runs in realtime even for headless
  tests).
  
  Maybe we want to make the triangles video adjust its rate along with
  tests?

  Dean Herbert · 2021-10-07 15:55:29 +09:00
  290c9755e2
• Avoid showing the disclaimer in game tests

  No real performance gain, but this is handy to bypass when actually
  using one of these tests to test something.

  Dean Herbert · 2021-10-07 15:55:15 +09:00
  a57b080f10
• Fix test failure due to reference of Player.Mods
  Dean Herbert · 2021-10-07 15:00:47 +09:00
  697f53c445
• Remove local overridden storage of Mods in Player

  Not required and only causing headaches. Accessing mods should now be
  done via `GameplayState`.
  
  Closes #14912.

  Dean Herbert · 2021-10-07 14:53:39 +09:00
  5f129ae33c
• Merge pull request #14986 from peppy/fix-wind-mods

  Fix rate mods not working if pp counter is displayed

  Dean Herbert · 2021-10-06 22:29:44 +09:00
  2021.1006.1 acaef26af7
• Use cloned mods in one more place
  Dean Herbert · 2021-10-06 21:30:30 +09:00
  9705c7b546
• Fix rate mods not working if pp counter is displayed
  Dean Herbert · 2021-10-06 21:26:30 +09:00
  433e7cd403
• Merge pull request #14982 from smoogipoo/fix-score-panel-test

  Fix intermittent score panel test failure

  Dean Herbert · 2021-10-06 17:56:18 +09:00
  622e81f47a
• Fix intermittent score panel test failure
  smoogipoo · 2021-10-06 16:46:27 +09:00
  456cfd62bf
• Merge pull request #14981 from peppy/fix-leaderboard-incorrect-load

  Fix leaderboard potentially displaying the wrong scores

  Dan Balasescu · 2021-10-06 16:40:26 +09:00
  0d1243a0b5
• Fix leaderboard potentially displaying the wrong scores

  Closes #14762.
  
  This class is ugly. I think the whole process should be clened up once
  we have correctly-scheduled `SynchronizationContext`s. There's not much
  saving it as long as all these interdispersed `Schedule`s around
  required.

  Dean Herbert · 2021-10-06 16:07:29 +09:00
  3803f2f462
• Merge pull request #14978 from peppy/fix-editor-file-selector-textbox-drags

  Fix dragging on an editor file selection text box causing repeated popover display

  Dan Balasescu · 2021-10-06 13:52:08 +09:00
  e6aa05a4a4
• Merge pull request #14977 from peppy/fix-working-beatmap-cache-invalidation

  Fix changes not being reflected immediately after exiting the editor

  Dan Balasescu · 2021-10-06 13:51:21 +09:00
  80c8612630
• Merge pull request #14918 from peppy/beatmap-difficulty-more-interface-usage

  Convert usages of `BeatmapDifficulty` to `IBeatmapDifficultyInfo`

  Dan Balasescu · 2021-10-06 13:17:16 +09:00
  5eb4210f78
• Fix dragging on an editor file selection text box causing repeated popover display

  Local fix and no tests as this is a pretty weird usage of `TextBox`.
  We'll probably want to change it to not use a textbox eventually.
  
  Closes #14969.

  Dean Herbert · 2021-10-06 13:15:05 +09:00
  d9849bcf49
• Fix PushAndConfirm potentially failing if new screen quickly pushes a child screen
  Dean Herbert · 2021-10-06 12:55:04 +09:00
  90fdaf18c0
• Fix BeatmapModelManager not receiving WorkingBeatmapCache
  Dean Herbert · 2021-10-06 12:55:04 +09:00
  8ffaa491e7
• Add missing methods to interfaces
  Dean Herbert · 2021-10-06 12:55:04 +09:00
  007b33cd88
• Add test coverage of creating, saving and loading a new beatmap
  Dean Herbert · 2021-10-06 12:55:04 +09:00
  6e797ddcac
• Remove incorrect csproj change

  Co-authored-by: Dan Balasescu <smoogipoo@smgi.me>

  Dean Herbert · 2021-10-06 12:22:32 +09:00
  ffbb7a9b1a
• Merge branch 'master' into beatmap-difficulty-more-interface-usage
  Dan Balasescu · 2021-10-06 12:18:51 +09:00
  e837a3511d
• Merge pull request #14917 from peppy/new-interfaces

  Add new read-only interfaces for all remaining model types

  Dan Balasescu · 2021-10-06 12:18:31 +09:00
  13bea7833e
• Merge branch 'master' into new-interfaces
  Dan Balasescu · 2021-10-06 11:38:17 +09:00
  4bbff2ebf7
• Merge pull request #14954 from peppy/rename-result-response

  Rename `APIRequest.Result` to `Response`

  Dan Balasescu · 2021-10-06 10:52:33 +09:00
  9491e5a547
• Merge pull request #14959 from peppy/add-screen-test-debug

  Add various logging output in an atttempt to figure multiplayer test failure

  Dan Balasescu · 2021-10-06 10:11:50 +09:00
  007e5f174c
• Merge pull request #14957 from peppy/fix-song-select-test-failure

  Fix `TestDifficultyIconSelectingForDifferentRuleset` potentially failing due to async load

  Dan Balasescu · 2021-10-06 10:10:57 +09:00
  4e13af6524
• Merge pull request #14958 from peppy/fix-delete-local-score-test-failure

  Fix delete local score test not waiting for "fetch" to complete

  Dan Balasescu · 2021-10-06 10:09:26 +09:00
  23f9b7a740
• Merge pull request #14968 from peppy/fix-replay-download

  Fix downloading replays not working as expected

  Dean Herbert · 2021-10-06 06:19:32 +09:00
  2021.1006.0 8dad20aa60
• Mark BeatmapSet as nullable for the time being
  Dean Herbert · 2021-10-06 05:54:37 +09:00
  4f59fc15a5
• Remove unnecessary access modifier in interface

  Co-authored-by: Dan Balasescu <smoogipoo@smgi.me>

  Dean Herbert · 2021-10-06 05:52:28 +09:00
  4d5696959b
• Add assert coverage of non-downloadable states
  Dean Herbert · 2021-10-06 05:49:18 +09:00
  d6f25e07cc
• Remove pointless (and incorrect) click step
  Dean Herbert · 2021-10-06 05:49:04 +09:00
  31c0c7a888
• Fix incorrect load state check

  Co-authored-by: Bartłomiej Dach <dach.bartlomiej@gmail.com>

  Dean Herbert · 2021-10-06 05:31:07 +09:00
  1a784b788d
• Remove unused using statement

  Co-authored-by: Bartłomiej Dach <dach.bartlomiej@gmail.com>

  Dean Herbert · 2021-10-06 05:30:49 +09:00
  1f6a31355c
• Fix incorrect DI retrieval in ReplayDownloadButton
  Dean Herbert · 2021-10-06 05:29:00 +09:00
  5a4474e1b2
• Add more comprehensive (and failing) test coverage of replay download button
  Dean Herbert · 2021-10-06 05:29:00 +09:00
  777763a550
• Merge pull request #14967 from bdach/fix-accidental-json-property-rename

  Fix "most played beatmap" request breakage after property rename

  Dean Herbert · 2021-10-06 05:00:12 +09:00
  c23acb8f05
• Merge pull request #14966 from bdach/fix-backwards-chat-overlay-load-check

  Fix backwards containment check in chat channel load callback

  Dean Herbert · 2021-10-06 04:58:54 +09:00
  f9b7b41011
• Fix "most played beatmap" request breakage after property rename
  Bartłomiej Dach · 2021-10-05 21:17:19 +02:00
  baa8baaa1e
• Fix backwards containment check in chat channel load callback
  Bartłomiej Dach · 2021-10-05 20:53:06 +02:00
  a5b07ce4fe
• Add test coverage for loading process on channel join
  Bartłomiej Dach · 2021-10-05 20:52:40 +02:00
  12da27cde7
• Merge pull request #14919 from smoogipoo/realtime-pp-display

  Implement real-time PP counter

  Dean Herbert · 2021-10-05 20:50:03 +09:00
  2021.1005.0 6f7b8293af
• Handle judgement reverts with actual display updates
  Dean Herbert · 2021-10-05 19:08:30 +09:00
  98fef6ece2
• Merge pull request #14907 from peppy/remove-local-realm-thread-switch-handling

  Remove local handling of realm when switching thread modes

  Dean Herbert · 2021-10-05 19:00:19 +09:00
  5c62d3b6cb
• Add various logging output in an atttempt to figure multiplayer test failure
  Dean Herbert · 2021-10-05 18:53:20 +09:00
  e6efdae7c9