35785 Commits

This Branch

This Branch

All Branches

• Remove unused dispose logic
  Dean Herbert · 2021-01-05 17:42:19 +09:00
  0b1ee2e267
• Refactor LoadingLayer to avoid applying effects to external drawables

  In theory this seemed like a good idea (and an optimisation in some
  cases, due to lower fill rate), but in practice this leads to weird edge
  cases.
  
  This aims to do away with the operations on external drawables by
  applying a dim to the area behind the `LoadingLayer` when required.
  I went over each usage and ensured they look as good or better than
  previously.
  
  The specific bad usage here was the restoration of the colour on dispose
  (if the `LoadingLayer` was disposed in a still-visible state).
  
  I'm aware that the `BeatmapListingOverlay` will now dim completely during
  load. I think this is fine for the time being.

  Dean Herbert · 2021-01-05 17:31:45 +09:00
  54982dcdd7
• Merge pull request #11418 from peppy/fix-storyboard-skip-starttime-regression
  Bartłomiej Dach · 2021-01-04 20:08:59 +01:00
  a86a7b08df
• Remove unused using
  Dean Herbert · 2021-01-04 15:40:22 +09:00
  9e0c490141
• Fix Storyboard's FirstEventTime not finding the true earliest event
  Dean Herbert · 2021-01-04 15:16:01 +09:00
  20d04d6933
• Add failing test for storyboard start time ordering
  Dean Herbert · 2021-01-04 15:15:23 +09:00
  cb7df0fe11
• Merge pull request #11413 from peppy/fix-mod-settings-transfer-issues

  Fix difficulty adjust settings not being transferred correctly in multiplayer/playlists

  Dean Herbert · 2021-01-03 22:38:41 +09:00
  cd7a5ca23a
• Clarify & cleanup comments some
  Bartłomiej Dach · 2021-01-03 13:44:29 +01:00
  9e4a925ab1
• Rename parameters for readability
  Bartłomiej Dach · 2021-01-03 13:25:44 +01:00
  a3e29b9154
• Copy values using Bind to also copy defaults
  Dean Herbert · 2021-01-03 20:45:03 +09:00
  2501707d7d
• Update osu.Game/Online/API/APIMod.cs

  Co-authored-by: Salman Ahmed <slmanarendo1950@gmail.com>

  Dean Herbert · 2021-01-03 17:04:16 +09:00
  6ad1b7767e
• Switch back to FirstOrDefault to allow for weird testing logic to pass
  Dean Herbert · 2021-01-03 16:46:24 +09:00
  99fa0e25dc
• Add internal pathway for ensuring correct application of bindable mods
  Dean Herbert · 2021-01-03 15:48:28 +09:00
  29dbb1cc0d
• Simplify some default value checks (we are sure the return is an IBindable)
  Dean Herbert · 2021-01-03 15:47:15 +09:00
  23e216fa0b
• Use SingleOrDefault for added safety when looking up mod acronyms
  Dean Herbert · 2021-01-03 15:38:30 +09:00
  1a44338124
• Merge pull request #11380 from bdach/unobserved-exceptions-pt-2

  Catch multiplayer client-related unobserved exceptions better

  Dean Herbert · 2021-01-02 23:36:49 +09:00
  8511112e28
• Merge pull request #11344 from Susko3/master

  Fix file and share associations on Android

  Dean Herbert · 2021-01-02 22:44:12 +09:00
  f8fe22df8f
• Merge pull request #11401 from peppy/fix-signalr-reconnect

  Allow signalr to retry connecting when connection is closed without an exception

  Dean Herbert · 2021-01-02 21:50:29 +09:00
  33d8d60717
• Merge branch 'master' into fix-signalr-reconnect
  Bartłomiej Dach · 2021-01-02 13:18:02 +01:00
  9ab1091281
• Merge pull request #11404 from bdach/bump-inspectcode
  Bartłomiej Dach · 2021-01-02 13:17:34 +01:00
  8d8e6d7bba
• Replace using static with explicit nested reference

  This seems to be an inspectcode bug, as the code is correct and
  compiles, but let's just work around it for now.

  Bartłomiej Dach · 2021-01-02 12:25:59 +01:00
  924af58f5b
• Disable "merge sequential patterns" suggestions

  As they were considered to be detrimental to code readability.

  Bartłomiej Dach · 2021-01-02 12:21:53 +01:00
  18ac97ca56
• Bump InspectCode tool to 2020.3.2
  Bartłomiej Dach · 2021-01-02 11:53:06 +01:00
  66bd847b45
• Allow signalr to retry connecting when connection is closed without an exception
  Dean Herbert · 2021-01-02 16:47:00 +09:00
  72a6ca7755
• Merge pull request #11399 from bdach/dependency-updates

  Update dependencies

  Dean Herbert · 2021-01-02 14:27:52 +09:00
  a96478e799
• Keep SignalR at last working version on iOS
  Bartłomiej Dach · 2021-01-02 00:11:24 +01:00
  fa73d0172e
• Merge branch 'dependabot/nuget/Microsoft.CodeAnalysis.BannedApiAnalyzers-3.3.2' into dependency-updates
  Bartłomiej Dach · 2021-01-02 00:10:52 +01:00
  cecb05f83e
• Merge branch 'dependabot/nuget/Microsoft.AspNetCore.SignalR.Client-3.1.10' into dependency-updates
  Bartłomiej Dach · 2021-01-01 21:25:10 +01:00
  30cebe7579
• Merge branch 'dependabot/nuget/Microsoft.NET.Test.Sdk-16.8.3' into dependency-updates
  Bartłomiej Dach · 2021-01-01 21:23:38 +01:00
  c3b59a84bc
• Merge branch 'dependabot/nuget/Microsoft.AspNetCore.SignalR.Protocols.NewtonsoftJson-3.1.10' into dependency-updates
  Bartłomiej Dach · 2021-01-01 21:22:38 +01:00
  22264f2ffe
• Bump Microsoft.CodeAnalysis.BannedApiAnalyzers from 3.3.1 to 3.3.2

  Bumps [Microsoft.CodeAnalysis.BannedApiAnalyzers](https://github.com/dotnet/roslyn-analyzers) from 3.3.1 to 3.3.2.
  - [Release notes](https://github.com/dotnet/roslyn-analyzers/releases)
  - [Changelog](https://github.com/dotnet/roslyn-analyzers/blob/master/PostReleaseActivities.md)
  - [Commits](https://github.com/dotnet/roslyn-analyzers/compare/v3.3.1...v3.3.2)
  
  Signed-off-by: dependabot-preview[bot] <support@dependabot.com>

  dependabot-preview[bot] · 2021-01-01 17:55:04 +00:00
  6cd838fd4b
• Bump Microsoft.AspNetCore.SignalR.Client from 3.1.9 to 3.1.10

  Bumps [Microsoft.AspNetCore.SignalR.Client](https://github.com/aspnet/AspNetCore) from 3.1.9 to 3.1.10.
  - [Release notes](https://github.com/aspnet/AspNetCore/releases)
  - [Commits](https://github.com/aspnet/AspNetCore/compare/v3.1.9...v3.1.10)
  
  Signed-off-by: dependabot-preview[bot] <support@dependabot.com>

  dependabot-preview[bot] · 2021-01-01 17:54:11 +00:00
  652b0ccd8f
• Bump Microsoft.NET.Test.Sdk from 16.8.0 to 16.8.3

  Bumps [Microsoft.NET.Test.Sdk](https://github.com/microsoft/vstest) from 16.8.0 to 16.8.3.
  - [Release notes](https://github.com/microsoft/vstest/releases)
  - [Commits](https://github.com/microsoft/vstest/compare/v16.8.0...v16.8.3)
  
  Signed-off-by: dependabot-preview[bot] <support@dependabot.com>

  dependabot-preview[bot] · 2021-01-01 17:53:41 +00:00
  0fd2e368c1
• Bump Microsoft.AspNetCore.SignalR.Protocols.NewtonsoftJson

  Bumps [Microsoft.AspNetCore.SignalR.Protocols.NewtonsoftJson](https://github.com/aspnet/AspNetCore) from 3.1.9 to 3.1.10.
  - [Release notes](https://github.com/aspnet/AspNetCore/releases)
  - [Commits](https://github.com/aspnet/AspNetCore/compare/v3.1.9...v3.1.10)
  
  Signed-off-by: dependabot-preview[bot] <support@dependabot.com>

  dependabot-preview[bot] · 2021-01-01 17:53:29 +00:00
  7441cfd94e
• Merge pull request #11382 from mcendu/move-health-meter
  Dean Herbert · 2020-12-31 22:39:49 +09:00
  faed776112
• Merge branch 'master' into master
  Susko3 · 2020-12-31 14:36:16 +01:00
  79755e1826
• Merge branch 'master' into move-health-meter
  Bartłomiej Dach · 2020-12-31 13:59:37 +01:00
  1e02f450a6
• move SkinnableHealthDisplay

  Similar components are in osu.Game.Screens.Play.HUD while this is not

  mcendu · 2020-12-31 20:23:13 +08:00
  17abe90c27
• Catch multiplayer client-related unobserved exceptions better

  Silencing an exception from a task continuation requires accessing
  `task.Exception` in any way, which was not done previously if
  `logOnError` was false.
  
  To resolve without having to worry whether the compiler will optimise
  away a useless access or now, just always log, but switch the logging
  level. The unimportant errors will be logged as debug and therefore
  essentially silenced on release builds (but could still be potentially
  useful in debugging).

  Bartłomiej Dach · 2020-12-31 11:39:42 +01:00
  2d279350ad
• Merge pull request #11379 from peppy/fix-perform-from-menu-nullref

  Fix PerformFromMenuRunner failing if CurrentScreen is null

  Dean Herbert · 2020-12-31 19:10:21 +09:00
  ec75efe124
• Merge branch 'master' into fix-perform-from-menu-nullref
  Bartłomiej Dach · 2020-12-31 10:33:05 +01:00
  1b1447eb35
• Inline complete method as well

  For better guarantees that `finalAction` is actually called on the same
  screen that `checkCanComplete()` was (uses result of one
  `getCurrentScreen()` call throughout instead of calling multiple times).

  Bartłomiej Dach · 2020-12-31 10:27:42 +01:00
  00c6703c51
• Fix PerformFromMenuRunner failing if CurrentScreen is null
  Dean Herbert · 2020-12-31 16:36:20 +09:00
  f9196ae976
• Merge pull request #11346 from bdach/fix-changelog-regression

  Fix changelog header staying dimmed after build show

  Dean Herbert · 2020-12-31 16:15:25 +09:00
  6ebb267c66
• Merge branch 'master' into master
  Susko3 · 2020-12-30 23:36:39 +01:00
  8e7877a2a7
• Merge pull request #1 from Susko3/fix-android-file-associations

  Remove duplicate application/octet-stream

  Susko3 · 2020-12-30 23:35:36 +01:00
  9b40334830
• Remove duplicate application/octet-stream
  Susko3 · 2020-12-30 23:35:07 +01:00
  eb64e6bf4d
• Merge pull request #11373 from peppy/move-out-thread-safety

  Move thread safety / locking logic from MultiplayerRoom

  Dean Herbert · 2020-12-30 23:27:36 +09:00
  a45f9b63b9
• Move thread safety / locking logic from MultiplayerRoom
  Dean Herbert · 2020-12-30 20:24:50 +09:00
  497d644a19
• Merge branch 'master' into fix-changelog-regression
  Dean Herbert · 2020-12-30 01:34:18 +09:00
  6596e3c5e8