97 Commits

• Fix incorrect indent
  Bartłomiej Dach · 2023-04-05 19:47:25 +02:00
  e5d57a65c9
• Merge branch 'master' into gameplay/key-counter-abstraction
  Dean Herbert · 2023-04-03 15:33:35 +09:00
  b0c09df259
• Rename Add/AddRange methods as they are no longer conflicting with Container
  Dean Herbert · 2023-03-15 18:02:41 +09:00
  5f9b13a775
• refactor: make KCD a CompositeDrawable
  tsrk · 2023-03-08 00:47:16 +00:00
  44297a7d0a
• Move KeyCounter components to HUD namespace
  Dean Herbert · 2023-03-07 16:41:39 +09:00
  28520414aa
• refactor(KeyCounterDisplay): apply suggestions

  I also took the freedom to add type checking, as we can't limit the
  usage of `Add()` since it's a Container. The exception thrown also
  advises of using the suggested `AddTrigger()` instead.

  tsrk · 2023-02-22 14:58:27 +00:00
  1beec71037
• refactor: rename trigger classes

  Makes it better to understand their purpose

  tsrk · 2023-02-15 21:46:13 +00:00
  076eb81b21
• refactor: rename Trigger class to InputTrigger
  tsrk · 2023-02-15 21:41:36 +00:00
  157bba7830
• Combine and attempt to simplify the score import / preparation process further
  Dean Herbert · 2023-02-14 16:55:35 +09:00
  7aaaf7fca2
• refactor: separate things in KeyCounter

  To implement different different sources of input for KeyCounter, it
  is now possible to create a Trigger class (to inherit) instead of
  inheriting KeyCounter. This eases the creation of more input sources
  (like for tests) while allowing to implement different UI variants.
  
  That way, if another variant of the key counter needs to implemented
  (for whathever reason), this can be done by only inheriting KeyCounter
  and changing how things are arranged visually.

  tsrk · 2023-02-13 01:24:27 +00:00
  74a58fb674
• Partial everything
  Dan Balasescu · 2022-11-27 00:00:27 +09:00
  7bc8908ca9
• Remove non-smoke key bindings on "Relax" mod instead
  Salman Ahmed · 2022-10-09 17:14:16 +03:00
  2d4f390372
• Change FrameStableClock to inherit IGameplayClock
  Dean Herbert · 2022-09-08 18:24:18 +09:00
  6729bb3e1a
• Code cleanup (CPS)
  Ryuki · 2022-08-24 17:13:23 +02:00
  5cddc7ed1f
• Tidy up attach logic
  Dean Herbert · 2022-08-24 19:36:01 +09:00
  f3847b90fd
• Rename all "KeysPerSecond" usages to "ClicksPerSecond"
  Ryuki · 2022-08-14 20:12:11 +02:00
  2aa3a1b50d
• Make ActionListener and KeysPerSecondCalculator not rely on events to add timestamps
  Ryuki · 2022-08-14 19:31:14 +02:00
  9dc806506e
• Make KeysPerSecondCalculator dependency in HUDOverlay nullable
  Ryuki · 2022-08-11 11:58:30 +02:00
  9b252b1d81
• Remove KPS acronym usage
  Ryuki · 2022-08-11 10:01:39 +02:00
  3c6461b9e4
• Use DI to provide dependencies for KPS Calculator and improve input

  gathering
  
  KPS Calculator now uses DI to retrieve the clocks. Using `HUDOverlay` it
  is now cached for `KeysPerSecondCounter`s to resolve it. This also
  allows to make an "Attach" flow like `KeyCounter`.

  Ryuki · 2022-08-08 21:54:06 +02:00
  b52a07c16a
• Update parameter discards
  Dean Herbert · 2022-06-24 21:26:19 +09:00
  31a447fda0
• Automated #nullable processing
  Dan Balasescu · 2022-06-17 16:37:17 +09:00
  f8830c6850
• Remove Ruleset parameter from ResetFromReplayFrame()
  Dan Balasescu · 2022-05-31 17:16:23 +09:00
  132c94c1b5
• Merge branch 'master' into spectator-consistency-frames
  Dan Balasescu · 2022-02-01 14:35:30 +09:00
  0641264a11
• Reset ScoreProcessor from statistics replay frames
  Dan Balasescu · 2022-01-31 21:32:56 +09:00
  4fb565e15f
• Retrieve KeyBindingContainer via DI rather than traversal lookup
  Dean Herbert · 2022-01-31 17:05:04 +09:00
  0e764538e0
• Merge branch 'master' into master
  Dean Herbert · 2022-01-31 16:30:08 +09:00
  a84fd2e20c
• Fix mouse button disable not disabling touch input mappings
  Dean Herbert · 2022-01-05 18:29:32 +09:00
  88602ec1b4
• Make KeyBindingContainer public
  pikokr · 2021-12-28 22:43:07 +09:00
  dec1f31749
• Disable key repeat for all ruleset handling cases
  Dean Herbert · 2021-11-18 13:13:36 +09:00
  cdb2a92f86
• Update with keybinding changes
  smoogipoo · 2021-09-16 18:26:12 +09:00
  f9d5abff8a
• Merge branch 'master' into realm-key-binding-store
  Dean Herbert · 2021-06-10 13:58:08 +09:00
  9044a20120
• Detach gameplay score from replay recorder before importing

  Closes #13320.

  Dean Herbert · 2021-06-04 02:00:02 +09:00
  d444fed46f
• Merge branch 'master' into realm-key-binding-store
  Dean Herbert · 2021-05-25 17:18:33 +09:00
  a249bb9e69
• Ignore certain banned InputKeys for gameplay purposes
  Dean Herbert · 2021-05-24 18:40:40 +09:00
  57640810b5
• Remove manual handling of IsActive in RulesetInputManager

  Now it is supported in framework

  ekrctb · 2021-04-16 14:13:41 +09:00
  936bde28a3
• Merge conditionals for readability
  Dean Herbert · 2021-04-15 14:19:59 +09:00
  ba325de595
• Avoid empty list allocation
  ekrctb · 2021-04-12 18:49:38 +09:00
  6d18b3db00
• Throw when getting a frame of an empty replay
  ekrctb · 2021-04-12 11:17:56 +09:00
  d6d8ea5b6b
• Remove unused using statement
  Dean Herbert · 2021-02-23 14:56:03 +09:00
  ec4b770cba
• When disable mouse buttons during gameplay is selected, disable more globally

  Until now the disable setting would only apply to left/right buttons,
  and only in gameplay. This change will cause any global actions bound to
  mouse buttons to also not work during gameplay.
  
  Closes #11879.

  Dean Herbert · 2021-02-23 14:37:46 +09:00
  672fd3f9d2
• Fix key counter actions displaying out of order
  Bartłomiej Dach · 2020-10-18 19:21:36 +02:00
  5b96f01564
• Update RulesetInputManager to use new method
  Dean Herbert · 2020-07-01 18:54:11 +09:00
  49aa839872
• Implement in player
  Dean Herbert · 2020-03-23 20:06:18 +09:00
  617149fb27
• Move replay recorder to final location
  Dean Herbert · 2020-03-23 20:04:15 +09:00
  6d48068061
• Basic test scene setup
  Dean Herbert · 2020-03-23 17:33:02 +09:00
  232c255986
• Apply OnRelease method signature refactorings
  smoogipoo · 2020-01-22 13:22:34 +09:00
  7b2f58eb30
• Fix key counters appearing negative on intense beatmaps

  When `FrameStabilityContainer` decides it needs multiple updates on the same frame, it ends up with an elapsed time of zero. This was interacting badly with the condition used in `RulesetInputManager` to govern playback direction.
  
  I have changed this to use `Rate` as exposed by the frame stable clock.
  
  - Closes #6198.

  Dean Herbert · 2019-10-03 15:01:54 +08:00
  b28689c774
• Handle key counter rewinding in a better way

  Use ElapsedFrameTime rather than storing state data

  Dean Herbert · 2019-09-12 15:42:14 +09:00
  0cdf125c1e
• Apply more missed cases
  Dean Herbert · 2019-04-01 12:44:46 +09:00
  c39c37a18d