36357 Commits

This Branch

This Branch

All Branches

• Reuse existing method
  smoogipoo · 2021-02-02 18:42:02 +09:00
  052cf1abae
• Merge branch 'add-mod-utils' into mod-consistency-function
  smoogipoo · 2021-02-02 18:41:35 +09:00
  5881b8be96
• Prevent multiple enumeration
  smoogipoo · 2021-02-02 18:37:11 +09:00
  12f52316cd
• Make more tests use the custom mod classes

  For safety purposes... In implementing the previous tests, I found that
  using mod.Object.GetType() can lead to bad assertions since the same
  ModProxy class is used for all mocked classes.

  smoogipoo · 2021-02-02 18:33:14 +09:00
  9955e02898
• Fix incorrect handling of multi-mod incompatibilities
  smoogipoo · 2021-02-02 18:31:08 +09:00
  1df412a03c
• Simplify implementation of CheckCompatibleSet
  smoogipoo · 2021-02-02 18:18:57 +09:00
  d0655c21c6
• Fix incorrect implementation
  smoogipoo · 2021-02-02 18:01:38 +09:00
  8232d9d2fe
• Add failing tests
  smoogipoo · 2021-02-02 18:01:33 +09:00
  7c29386717
• Fix typo in xmldoc
  Dean Herbert · 2021-02-02 14:14:31 +09:00
  1c645601d4
• Add basic test coverage of CheckValidForGameplay function
  Dean Herbert · 2021-02-02 14:13:50 +09:00
  80d88024d6
• Ensure mods are always in a valid state at a game level
  Dean Herbert · 2021-02-01 20:20:19 +09:00
  425dc8a210
• Add function to check for (and return) invalid mods
  Dean Herbert · 2021-02-01 20:20:10 +09:00
  ead8262257
• Add ModUtils class for validating mod usages
  smoogipoo · 2021-02-01 19:37:24 +09:00
  b9832c1b2d
• Merge pull request #11561 from Mysfit/fix-storyboard-samples

  Fix storyboard samples continuing to play when the beatmap is paused or intro is skipped

  Dean Herbert · 2021-02-01 17:48:08 +09:00
  328bd191d4
• Add more comprehensive commenting and simplify base call logic

  We can call the base method regardless for better safety. Worst case
  it's just going to run `Stop()` twice anyway.

  Dean Herbert · 2021-02-01 16:43:54 +09:00
  05982f42ab
• Merge pull request #11636 from bdach/fix-time-ramp-calculation

  Fix incorrect speed change calculation in time ramp mods

  Dean Herbert · 2021-02-01 16:32:44 +09:00
  25614c7923
• Merge pull request #11626 from peppy/fix-spinner-spm-negative

  Ensure spinners only handle input during their hittable time

  Dean Herbert · 2021-02-01 16:27:22 +09:00
  0dd1208579
• Handle no-duration single-object edge case
  Bartłomiej Dach · 2021-01-31 21:09:41 +01:00
  a0de1cbfd0
• Fix speed change calculation in time ramp mods
  Bartłomiej Dach · 2021-01-31 20:34:56 +01:00
  547b3d8bed
• Add failing test cases
  Bartłomiej Dach · 2021-01-31 20:34:22 +01:00
  81b052b866
• Merge pull request #11635 from bdach/storyboard-loop-type-decoding

  Fix invalid numeric values for storyboard animation type parsing incorrectly

  Dean Herbert · 2021-02-01 00:50:22 +09:00
  adc57dd94b
• Coerce undefined animation loop types to Forever
  Bartłomiej Dach · 2021-01-31 15:43:58 +01:00
  b9a49d5589
• Add failing test case
  Bartłomiej Dach · 2021-01-31 15:43:58 +01:00
  d7e5a21213
• Merge pull request #11500 from peppy/fix-skin-dropdown-update-crash
  Bartłomiej Dach · 2021-01-30 13:34:00 +01:00
  fec3bd898e
• Merge branch 'master' into fix-skin-dropdown-update-crash
  Bartłomiej Dach · 2021-01-30 13:01:52 +01:00
  6a1387191a
• Reset SPM counter state on DHO application
  Bartłomiej Dach · 2021-01-29 20:32:45 +01:00
  ae08ef2543
• Merge pull request #11625 from peppy/fix-beatmap-cache-lookup-null-failure

  Fix SQLite exception thrown is a beatmap lookup is attempted without an OnlineBeatmapID present

  Bartłomiej Dach · 2021-01-29 18:58:00 +01:00
  44e88f09e5
• Don't directly update HandleUserInput (as it is used by mods)
  Dean Herbert · 2021-01-30 02:35:11 +09:00
  d521bfc251
• Fix unused using
  Dean Herbert · 2021-01-29 20:22:25 +09:00
  5a306dfc2b
• Ensure spinners only handle input during their hittable time

  While this was already being enforced inside of `CheckForResult`, the
  internal tracking values of rotation were still being incremented as
  long as the `DrawableSpinner` was present. This resulted in incorrect
  SPM values being displayed if a user was to start spinning before the
  object's `StartTime`.
  
  Kind of annoying to write a test for (there's no setup for spinners yet)
  but am willing to do so if that is deemed necessary.
  
  Closes https://github.com/ppy/osu/issues/11600.

  Dean Herbert · 2021-01-29 19:55:55 +09:00
  f25809d35f
• Fix SQLite exception thrown is a beatmap lookup is attempted without an OnlineBeatmapID present

  It turns out the SQLite API isn't smart enough to handle nullables
  directly, so we need to help it out a bit.
  
  Stops the following from being thrown:
  
  ```
  System.InvalidOperationException: Value must be set.
     at Microsoft.Data.Sqlite.SqliteParameter.Bind(sqlite3_stmt stmt) = 3
  at
     at Microsoft.Data.Sqlite.SqliteParameterCollection.Bind(sqlite3_stmt
  stmt) = 3 at
     at Microsoft.Data.Sqlite.SqliteCommand.ExecuteReader(CommandBehavior
  behavior)
     at Microsoft.Data.Sqlite.SqliteCommand.ExecuteReader()
     at
  osu.Game.Beatmaps.BeatmapManager.BeatmapOnlineLookupQueue.checkLocalCache(BeatmapSetInfo
  set, BeatmapInfo beatmap) in
  /Users/dean/Projects/osu/osu.Game/Beatmaps/BeatmapManager_BeatmapOnlineLookupQueue.cs:line
  166 = 166
  ```

  Dean Herbert · 2021-01-29 19:53:57 +09:00
  16f3d1815f
• Merge pull request #11622 from peppy/remove-unobserved-exception-handling

  Remove all usage of CatchUnobservedExceptions

  Dan Balasescu · 2021-01-29 19:31:07 +09:00
  cd8ef5373d
• Merge pull request #11623 from Firmatorenio/apply-sv-to-taiko-diffadjust

  Add scroll speed adjustment to taiko's DifficultyAdjust mod

  Dean Herbert · 2021-01-29 19:25:17 +09:00
  d52376cc17
• Ensure the item is present before trying to select it
  Dean Herbert · 2021-01-29 19:17:12 +09:00
  18e6afbec0
• Merge branch 'master' into fix-skin-dropdown-update-crash
  Dean Herbert · 2021-01-29 19:16:20 +09:00
  1ce383fc20
• rename SliderVelocity to ScrollSpeed
  Firmatorenio · 2021-01-29 15:04:55 +06:00
  37ef5c7072
• Remove all usage of CatchUnobservedExceptions

  This should no longer be required with the recent framework side change
  that stops a game from crashing on unobserved exceptions
  (https://github.com/ppy/osu-framework/pull/4171).

  Dean Herbert · 2021-01-29 16:32:29 +09:00
  a61444690e
• add SV multiplier adjustment to TaikoModDifficultyAdjust
  Firmatorenio · 2021-01-29 11:48:51 +06:00
  449f883be1
• Merge pull request #11618 from vltspr/catch-auto-fix

  Fix Catch autoplay rewinding on instantaneous hits

  Dan Balasescu · 2021-01-29 12:17:46 +09:00
  4c4770bf4b
• Formatting
  Corentin PALLARD · 2021-01-29 03:03:23 +01:00
  d168de0ae3
• Fix the ctb auto mod speedup in some occasions
  Corentin PALLARD · 2021-01-29 02:53:26 +01:00
  da4c207a73
• Merge pull request #11615 from peppy/ios-signalr-use-json
  Bartłomiej Dach · 2021-01-29 00:04:16 +01:00
  1d76cfe585
• Merge branch 'master' into ios-signalr-use-json
  Bartłomiej Dach · 2021-01-28 23:28:49 +01:00
  0f1d72e073
• Merge pull request #11616 from peppy/fix-ios-beatmap-cache-lookups

  Avoid using Dapper to fix iOS compatibility of beatmap lookup cache

  Bartłomiej Dach · 2021-01-28 23:17:54 +01:00
  c592c80a07
• Fix typos in comments
  Bartłomiej Dach · 2021-01-28 22:36:07 +01:00
  386f9f7842
• Merge branch 'master' into fix-ios-beatmap-cache-lookups
  Bartłomiej Dach · 2021-01-28 22:33:58 +01:00
  8afd1bce21
• Merge pull request #11613 from bdach/order-attribute-move

  Remove game-local enum `[Order]` attribute

  Dean Herbert · 2021-01-29 00:41:43 +09:00
  2021.129.0 34f8e4b672
• Merge pull request #11611 from frenzibyte/fix-package-downgrade

  Fix dotnet run/publish with runtime specified not working again

  Dean Herbert · 2021-01-29 00:18:27 +09:00
  87e23d22cf
• Update framework
  Dean Herbert · 2021-01-28 23:55:03 +09:00
  a616688a47
• Avoid using Dapper to fix iOS compatibility of beatmap lookup cache
  Dean Herbert · 2021-01-28 16:53:56 +09:00
  c3d4044017