939 Commits

• Disallow use of scoping button when at freestyle song select
  Dean Herbert · 2026-02-19 01:47:03 +09:00
  1153d17153
• Privatise setter
  Bartłomiej Dach · 2026-02-18 14:42:04 +01:00
  e15cb08b44
• Migrate playlist freestyle select screen to use SongSelectV2
  Dean Herbert · 2026-02-18 20:30:14 +09:00
  93d1a61dc2
• Restore previous beatmap when leaving scoped mode (#36582)

  Resolves #36288.
  
  If the current selection is still available after leaving scoped mode,
  it's left as is. If it's not, the selection from before entering scoped
  mode is restored.
  
  
  https://github.com/user-attachments/assets/b1ac3de1-7c7f-4949-82a9-1dd0459f3f61
  
  ---------
  
  Co-authored-by: Bartłomiej Dach <dach.bartlomiej@gmail.com>

  Krzysztof Gutkowski · 2026-02-17 00:40:29 +09:00
  8e26cf4e1b
• Fix local beatmap metadata not being cleared when previously selected beatmap is online (#36632)

  - Closes https://github.com/ppy/osu/issues/36584
  
  The last two commits could be either fixes to the issue above, but in a
  code quality perspective, the scheduler in `setLink()` seems unnecessary
  as the other set methods don't have it (other than making it run last)
  and the other commit is self explanatory.

  Joseph Madamba · 2026-02-09 09:55:36 +09:00
  0a4497db3c
• Change difficulty range slider colors to match star rating more closely (#36564)

  my attempt at #36452: changes difficulty range slider in song select V2
  to use the new star difficulty text gradient colors from #36292.
  
  closes #36405
  
  
  https://github.com/user-attachments/assets/134ace54-a8f8-4024-a32e-f1604c868232
  
  to match star rating more closely for sr <= 7.5 (where i don't think the
  colors are so intense that they break harmony with the rest of the
  design), i removed the Lighten by 0.4f on color update
  
  also improved the transition from 7.9 to 8.0 which is quite abrupt in
  the current version
  
  https://github.com/ppy/osu/pull/33425#issuecomment-2951914385 is
  relevant here

  Michael Middlezong · 2026-02-06 19:15:57 +09:00
  5231cfa1c7
• Localise some strings on SSV2 (#36591)
  Denis Titovets · 2026-02-06 19:12:07 +09:00
  40b331654e
• Remove leaking knowledge of freestyle in normal song select component
  Dean Herbert · 2026-01-28 16:37:39 +09:00
  ca7b850c8c
• Limit maximum size of mod tooltip to avoid it going offscreen
  Dean Herbert · 2026-01-28 16:08:02 +09:00
  b9d5606fd4
• Combine implementation of mods text drawable

  I don't want to have to update things in multiple places with different
  code in each place.
  
  This also closes https://github.com/ppy/osu/issues/36412.

  Dean Herbert · 2026-01-28 16:02:14 +09:00
  c8c91cedfa
• Fix panel expansion not being set on initial song select load (#36456)

  Closes #36445.
  
  Fixes a regression from #36404
  
  ---------
  
  Co-authored-by: Dean Herbert <pe@ppy.sh>

  Eeli Ogata · 2026-01-27 14:32:51 +01:00
  2c56419fe9
• Apply new inspections from 2026.1EAP1

  Nothing really egregious here so not bothering with PR review. One dodgy
  bug which has been
  [reported](https://youtrack.jetbrains.com/issue/RIDER-135036/Incorrect-recursive-on-all-execution-paths-inspection)
  and temporarily ignored.

  Dean Herbert · 2026-01-26 15:12:52 +09:00
  f1f4a0001b
• Fix score tooltips being displayed when hovering freemods status bar on PlaylistsSSV2 (#36413)

  - similar to https://github.com/ppy/osu/pull/36332

  Denis Titovets · 2026-01-24 00:10:04 +09:00
  84ec4bb866
• Simplify logic further and fix regressing case
  Dean Herbert · 2026-01-22 14:59:42 +09:00
  6354286452
• Merge branch 'master' into fix-carousel-thing
  Dean Herbert · 2026-01-22 01:55:28 +09:00
  5d651628bc
• Fix carousel items becoming incorrectly selected due to bindable leakage (#36414)

  As discussed in discord. Fixed from multiple angles.
  
  ---------
  
  Co-authored-by: Bartłomiej Dach <dach.bartlomiej@gmail.com>

  Dean Herbert · 2026-01-22 01:06:40 +09:00
  10dc1314f6
• Refactor HandleFilterCompleted to (hopefully) be easier to parse

  This is not required to fix the issue, but it is required for my brain
  to follow the method to some degress.

  Dean Herbert · 2026-01-20 21:12:49 +09:00
  46b2d5374e
• Handle expand set logic locally rather than calling HandleItemSelected

  This avoids the implicit group expansion happening that the added code
  was attempting to fix.

  Dean Herbert · 2026-01-20 21:12:49 +09:00
  8860eec9f9
• Revert "Do not forcibly re-expand carousel groups on refilters if the user manually collapsed them"

  This reverts commit bc4d5d07d7.

  Dean Herbert · 2026-01-20 21:12:49 +09:00
  8c86ff36a2
• Revert "Fix current beatmap set being incorrectly expanded after collapsing group with current selection"

  This reverts commit 9ba9966078.

  Dean Herbert · 2026-01-20 21:12:48 +09:00
  fdf9092f41
• Fix osu! logo appearing in at new playlist song select screen after opening mod select (#36385)

  Closes https://github.com/ppy/osu/issues/36363.

  Dean Herbert · 2026-01-19 16:55:39 +09:00
  c0b644c905
• Fix score tooltips being displayed when hovering mod status bar (#36332)

  - addresses https://github.com/ppy/osu/discussions/34079
  - supersedes and closes https://github.com/ppy/osu/pull/34090

  Denis Titovets · 2026-01-17 23:15:46 +09:00
  eee88a3955
• Ensure diffcalc runs after mods get replaced during a ruleset change (#36359)
  Krzysztof Gutkowski · 2026-01-16 16:38:00 +01:00
  952fd0d493
• Use new star rating text gradient for the difficulty name, "mapped by" text and difficulty bars (#36345)

  Fixes: #36312
  
  I think that's exactly what needed to be done to fix this issue.
  
  |master|this PR|
  |:---:|:---:|
  |<img width="943" height="272" alt="изображение"
  src="https://github.com/user-attachments/assets/e6fb57bd-8393-4476-ac73-a8b559365e6d"
  />|<img width="950" height="270" alt="изображение"
  src="https://github.com/user-attachments/assets/e09de911-0068-4a8b-9abb-f2aa04a87886"
  />|
  |<img width="943" height="274" alt="изображение"
  src="https://github.com/user-attachments/assets/637a86f5-ad26-441d-8fa2-bdf113bb636d"
  />|<img width="936" height="272" alt="изображение"
  src="https://github.com/user-attachments/assets/d72f52a1-6c17-4156-a4eb-cca36e74f644"
  />|
  |<img width="940" height="271" alt="изображение"
  src="https://github.com/user-attachments/assets/cf6a5f18-34c8-4f51-867a-ba1fc30b64a5"
  />|<img width="941" height="270" alt="изображение"
  src="https://github.com/user-attachments/assets/e21cda45-1a69-4623-b9a7-add3eb7c7013"
  />
  |<img width="946" height="275" alt="изображение"
  src="https://github.com/user-attachments/assets/e29647bb-c4aa-4d03-a46d-3bbcd43181b6"
  />|<img width="932" height="271" alt="изображение"
  src="https://github.com/user-attachments/assets/1f777db2-d0f9-4c2a-91fa-e005b9704c9a"
  />
  
  ---------
  
  Co-authored-by: Dean Herbert <pe@ppy.sh>

  De4n · 2026-01-15 16:00:27 +09:00
  3302e2e180
• Merge branch 'master' into new-playlists-song-select
  Dean Herbert · 2026-01-13 17:04:42 +09:00
  363b7cf3cb
• Fix mod footer button with unranked badge not resizing on localisation changes (#33810)

  - Closes https://github.com/ppy/osu/issues/33789

  Salman Alshamrani · 2026-01-13 16:13:00 +09:00
  0ba4e9e2a4
• Merge branch 'master' into hide-cursor-during-background-reveal
  UltraDrakon · 2026-01-12 18:30:35 +01:00
  5899800293
• Fix underline size at song select details panel not matching after changing language (#36303)

  Fixes #36274 
  
  **Change:**
  Registered a `BindValueChanged` callback on each TabItem’s
  `Text.Current` to ensure the underline indicator (strip) updates
  whenever the displayed tab text changes and calling `updateDisplay`
  accordingly to update the underline.
  
  **Result:**
  
  
  https://github.com/user-attachments/assets/6fb95a46-c768-46ec-a68a-a5e394e08a78
  
  ---------
  
  Signed-off-by: Linus Genz <linuslinuxgenz@gmail.com>
  Co-authored-by: Dean Herbert <pe@ppy.sh>

  Linus Genz · 2026-01-12 23:40:13 +09:00
  a81a77c60f
• Add star rating text gradient (#36292)

  Implements https://github.com/ppy/osu-web/pull/12363
  
  There's one less colour in the spectrum than in the [web
  code](https://github.com/ppy/osu-web/pull/12363/changes#diff-a9bdefd7233ca98f7f89cd76213aba5d869ae0424c8e79d1e322abd3e43462fbR31)
  because the spectrum was actually defined incorrectly and has [one less
  domain entry than it
  should](https://github.com/ppy/osu-web/pull/12363/changes#diff-a9bdefd7233ca98f7f89cd76213aba5d869ae0424c8e79d1e322abd3e43462fbR29).
  I've chose to not add it because of consistency with the web and because
  it looked pretty ugly (it was pretty much unreadable)
  
  <img width="1361" height="814" alt="image"
  src="https://github.com/user-attachments/assets/5f9d7a93-3e28-4b8c-952c-0abd6f8c2cc3"
  />
  <img width="805" height="647" alt="image"
  src="https://github.com/user-attachments/assets/b060cba7-3beb-4bb5-8d50-6210e8417715"
  />

  StanR · 2026-01-11 00:30:48 +09:00
  3e7f0f4c61
• Simplify logic
  Dean Herbert · 2026-01-09 18:01:35 +09:00
  1c1a3fbe8d
• Fix beatmap scope dismiss bar showing on top of filter control dropdowns

  closes https://github.com/ppy/osu/issues/36259

  Bartłomiej Dach · 2026-01-07 11:13:33 +01:00
  9b26b83d55
• Hide cursor during background reveal in song select

  - Implement IProvideCursor in SongSelect to hide cursor when background is revealed
  - Cursor reappears on mouse movement and hides again after 1 second of inactivity
  - Fix MenuCursorContainer to preserve drag rotation state during hide/show cycles

  UltraDrakon · 2026-01-06 14:51:07 +01:00
  8cbcb0e74f
• Fix title overlap

  Uses the same method of displaying the mod selection as the old song
  select (as an overlay of the entire game).

  Dan Balasescu · 2026-01-05 17:44:49 +09:00
  8b49572c44
• Fix play button starting wrong beatmap before selection loads (#36104)

  * Fix play button starting wrong beatmap before selection loads
  
  When clicking the osu! cookie (play button) before a newly selected beatmap finishes loading, the previous beatmap would be played instead of the currently selected one. 
  
  This was caused by the cookie reading from the global beatmap state which is debounced by 150ms, while the Enter key correctly used the carousel's current selection.
  
  The fix makes the cookie use the same beatmap source as Enter - the carousel's current selection - which is always up-to-date regardless of debounce timing.
  
  Closes #36074
  
  * Use ensureGlobalBeatmapValid() for logo and Enter key actions
  
  * Add test for beatmap selection timing bug
  
  Tests the fix for issue #36074 where clicking the play button immediately after selecting a different difficulty would start the wrong beatmap due to the 150ms selection debounce.

  Jul · 2026-01-05 14:54:25 +09:00
  ff820f730e
• Revert no longer necessary change

  Additionally to fix the options button, I could either cache the
  interface in PlaylistsSongSelectV2 or make the interface cache itself. I
  went with the latter option.

  Dan Balasescu · 2026-01-05 14:10:26 +09:00
  ebf9c19ad3
• Merge branch 'master' into new-playlists-song-select
  Dean Herbert · 2026-01-01 00:29:02 +09:00
  e1ce1e3188
• Merge pull request #36175 from bdach/show-all-difficulties-set-panel

  Add ability to view other beatmaps in set when difficulties are grouped by set

  Dean Herbert · 2025-12-31 23:36:40 +09:00
  464cc23393
• Remove dim effect from disabled spread displays on song select panels
  Bartłomiej Dach · 2025-12-31 10:05:59 +01:00
  a6545bea68
• Allow clicking anywhere on the scoped beatmap set indicator to dismiss it
  Bartłomiej Dach · 2025-12-30 13:40:27 +01:00
  24a0de1020
• Bring back ruleset grouping & overflow handling to spread display
  Bartłomiej Dach · 2025-12-30 12:39:50 +01:00
  e2ed5208fe
• Add support for showing which beatmaps in a set are currently filtered out
  Bartłomiej Dach · 2025-12-30 12:39:32 +01:00
  e07b828f30
• Add minimal spread display control for beatmap set panels
  Bartłomiej Dach · 2025-12-30 12:39:18 +01:00
  e2a245b049
• Merge branch 'master' into new-playlists-song-select
  Dean Herbert · 2025-12-25 20:26:35 +09:00
  36de88f399
• Address review concerns
  Bartłomiej Dach · 2025-12-19 13:59:26 +01:00
  4cce6aa123
• Fix license header
  Bartłomiej Dach · 2025-12-17 13:20:51 +01:00
  c120f0ebab
• Add ability to view other beatmaps in set when difficulties are split apart

  First part of https://github.com/ppy/osu/issues/36039, see also
  https://github.com/ppy/osu/discussions/33784.
  
  The goal is to add this back to the set panels too, but that one is more
  complicated than this if you can believe it (because it requires being
  able to tell which other difficulties of the set are filtered out to
  fade them out). I also foresee the display logic to vary significantly
  there.
  
  Of note, for this to work in beatmaps-split-apart mode, this requires a
  change of behaviour in the filtering logic. Old song select when given a
  "selected beatmap set" would *include* that in results regardless of the
  filter, but that doesn't work for beatmaps-split-apart for reasons that
  are hopefully obvious, so this changes the behaviour to *entirely
  bypass* the filter and just show the set. Unsure how angry will people
  be with that.
  
  Also of note, when in the scoped mode, altering any filter criteria will
  dismiss the scope.

  Bartłomiej Dach · 2025-12-17 12:28:20 +01:00
  5bf6a75b50
• Merge branch 'master' into new-playlists-song-select
  Dan Balasescu · 2025-12-17 13:33:34 +09:00
  67e0348fa8
• Slightly delay song select leaderboard's loading placeholder to avoid flashing during local score retrieval

  Closes #35893.

  Dean Herbert · 2025-12-11 18:54:38 +09:00
  6ce8b0a4bc
• Fix changing beatmap during hold-to-reveal-background delay turning off blur (#35867)

  Closes https://github.com/ppy/osu/issues/35864.

  Bartłomiej Dach · 2025-12-04 19:23:32 +09:00
  0b3ec3f1e1
• Add context menu shortcut to watch local replays from song select (#35823)

  Addresses https://github.com/ppy/osu/discussions/35811 I guess.
  
  Will only work for local leaderboards for now but maybe good enough for
  what is essentially a 5 minute job?
  
  Can be made to work with online leaderboards too I guess if need be.

  Bartłomiej Dach · 2025-11-27 21:10:46 +09:00
  037743e002