h1or4dme8/osu-lazer
1
0
Fork 0
mirror of https://github.com/ppy/osu.git synced 2026-05-18 12:40:18 +08:00
Code Issues Releases Wiki Activity

Ensure diffcalc runs after mods get replaced during a ruleset change (#36359)

Browse Source
This commit is contained in:
Krzysztof Gutkowski
2026-01-16 16:38:00 +01:00
committed by GitHub
Unverified
parent 06b89919be
commit 952fd0d493
1 changed files with 7 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files
osu.Game/Screens/SelectV2/BeatmapTitleWedge.DifficultyDisplay.cs
+7 -2
View File
@@ -206,8 +206,13 @@ namespace osu.Game.Screens.SelectV2
{
base.LoadComplete();
beatmap.BindValueChanged(_ => updateDisplay());
ruleset.BindValueChanged(_ => updateDisplay());
// it is not uncommon for the beatmap and the ruleset to change in conjunction during a single update frame.
// in that process, it is possible for the global bindable triad (beatmap / ruleset / mods) to briefly be partially invalid in combination (e.g. mods invalid for given ruleset).
// `updateDisplay()` will initiate a difficulty calculation, and if it is allowed to run in that invalid intermediate state, it will loudly fail.
// therefore, all changes that may initiate a difficulty calculation are debounced until the next frame to ensure the global bindable state is fully consistent -
// and it's what you'd want to do anyway for performance reasons.
beatmap.BindValueChanged(_ => Scheduler.AddOnce(updateDisplay));
ruleset.BindValueChanged(_ => Scheduler.AddOnce(updateDisplay));
mods.BindValueChanged(m =>
{