1
0
mirror of https://github.com/ppy/osu.git synced 2025-01-30 00:03:08 +08:00
Commit Graph

71239 Commits

Author SHA1 Message Date
Dean Herbert
c810e41ac3
Fix breakage from reordering co-reliant variable sets (and guard against it) 2025-01-24 22:15:22 +09:00
Dean Herbert
a04b03d29c
Consume GameplayStartTime for more lenient offset adjustments 2025-01-24 22:15:22 +09:00
Dean Herbert
011e43bcdc
Expose GameplayStartTime in IGameplayClock 2025-01-24 22:15:20 +09:00
Dean Herbert
5d78b45427
Fix average button not correctly becoming disabled where it previously would 2025-01-24 20:18:36 +09:00
Dean Herbert
e75916555c
Move line to correct location 2025-01-24 20:18:36 +09:00
Dean Herbert
df815bf41b
Bypass offset disallowed status when handling realm callbacks
Hopefully don't need to overthink this one.
2025-01-24 20:18:36 +09:00
Dean Herbert
6a74f9f902
Add safeties against attempting to apply previous play while offset adjust is not allowed
This should theoretically not be possible, but while we are sharing this
control's implementation between gameplay and non-gameplay usages, let's
ensure nothing weird can occur.
2025-01-24 20:18:35 +09:00
Bartłomiej Dach
7aceb2e349
Fix crash from new combo colour selector when there are no combo colours present
Closes https://github.com/ppy/osu/issues/31615.
2025-01-24 16:45:59 +09:00
Salman Alshamrani
ea9cc4d44d
Hide Discord RPC error messages away from user attention 2025-01-24 14:37:28 +09:00
Bartłomiej Dach
5e607c94b1
Roll back windows build image to 2019 on android build job
Per workaround suggested in
https://github.com/actions/runner-images/issues/11402#issuecomment-2596473501.

Applying this now as my hopes for a swift resolution without changes on
our side are slim to none (read thread linked above in full to learn
why).
2025-01-24 14:37:25 +09:00
Dean Herbert
40a3b53c41
Remove obsolete fucks 2025-01-20 03:18:22 +09:00
Dean Herbert
fa452bcce1
Fix right mouse not working at song select for some things 2025-01-20 03:11:07 +09:00
Dean Herbert
0b9c41c94e
Fix broken text boxes in editor 2025-01-20 02:45:13 +09:00
Dean Herbert
e753e3ee2f
Update framework (except android) 2025-01-18 00:40:32 +09:00
Bartłomiej Dach
ec1a473593
Merge pull request #31542 from peppy/beatmap-carousel-v2-curvature
Add curvature to new carousel implementation
2025-01-17 15:26:44 +01:00
Dean Herbert
43b54623d9
Add required padding on either side of panels so selection can remain centered 2025-01-17 18:08:20 +09:00
Dean Herbert
54f9cb7f68
Add overlapping spacing support 2025-01-17 18:07:54 +09:00
Dean Herbert
a1c5fad6d4
Add curvature to new carousel implementation 2025-01-17 18:07:54 +09:00
Dean Herbert
a8456ce9ac
Merge pull request #31513 from smoogipoo/remove-status-from-apiuser
Remove `Status` and `Activity` bindables from `APIUser`
2025-01-17 17:36:47 +09:00
Dan Balasescu
88829d5321
Merge pull request #31535 from peppy/beatmap-carousel-v2-right-click-scroll
Refactor absolute scrolling at song select
2025-01-17 17:02:14 +09:00
Dean Herbert
41c603b56f
Fix double-retrieval of user presence from dictionary in online display 2025-01-17 16:41:02 +09:00
Dean Herbert
311f08b962
Update TestMetadataClient to correctly set local user state in line with changes 2025-01-17 16:29:02 +09:00
Dean Herbert
3bb4b0c2b8
Rename fields from State to Presence when presence is involved 2025-01-17 16:25:48 +09:00
Bartłomiej Dach
7d026761fc
Merge pull request #31533 from peppy/fix-gameplay-offset-adjust-limitations
Fix gameplay offset adjustment limits not being enforced
2025-01-17 08:21:24 +01:00
Dan Balasescu
79fff136a9
Merge branch 'master' into beatmap-carousel-v2-right-click-scroll 2025-01-17 16:12:52 +09:00
Dan Balasescu
a51938f4e9
Separate the local user state 2025-01-17 15:59:34 +09:00
Dan Balasescu
5425d62186
Merge branch 'master' into remove-status-from-apiuser 2025-01-17 15:42:40 +09:00
Dan Balasescu
ae7e4bef86
Fix tests 2025-01-17 15:42:19 +09:00
Dean Herbert
224f39825f
Fix test potentially false-negative due to realm write delays 2025-01-17 14:16:38 +09:00
Dean Herbert
3272224a28
Merge pull request #31526 from bdach/spectator-list-visuals
Implement spectator list display
2025-01-17 10:26:02 +09:00
Bartłomiej Dach
81f54507dd
Fix potential index accounting mistake when creating spectator list with spectators already present
Noticed by accident, but if the `BindCollectionChanged()` callback fires
immediately in `LoadComplete()` when set up and there are spectators
present already, then `NewStartingIndex` in the related event is -1:

	b03f83de36/src/libraries/System.ObjectModel/src/System/Collections/Specialized/NotifyCollectionChangedEventArgs.cs (L84-L92)

which kinda breaks the math introducing off-by-ones and in result causes
11 items to be displayed together rather than 10.
2025-01-16 14:29:41 +01:00
Bartłomiej Dach
e3b780d0fb
Merge branch 'master' into spectator-list-visuals 2025-01-16 14:07:53 +01:00
Bartłomiej Dach
70c81b1b0c
Merge pull request #31534 from bdach/nvika-dotnet-8
Bump NVika tool to 4.0.0
2025-01-16 14:04:59 +01:00
Dean Herbert
a6057a9f54
Move absolute scroll support local to carousel and allow custom bindings 2025-01-16 20:47:59 +09:00
Bartłomiej Dach
48609d44e2
Bump NVika tool to 4.0.0
Code quality CI runs have suddenly started failing out of nowhere:

- Passing run: https://github.com/ppy/osu/actions/runs/12806242929/job/35704267944#step:10:1
- Failing run: https://github.com/ppy/osu/actions/runs/12807108792/job/35707131634#step:10:1

In classic github fashion, they began rolling out another runner change
wherein `ubuntu-latest` has started meaning `ubuntu-24.04` rather than
`ubuntu-22.04`. `ubuntu-24.04` no longer has .NET 6 bundled.

Therefore, upgrade NVika to 4.0.0 because that version is compatible
with .NET 8.
2025-01-16 12:30:27 +01:00
Dean Herbert
1c2621d88e
Add support to CarouselV2 for right mouse button scrolling 2025-01-16 20:27:38 +09:00
Dean Herbert
56b450c4a6
Remove setting for right-mouse scroll (make it always applicable) 2025-01-16 20:27:38 +09:00
Bartłomiej Dach
6b921fc4e4
Merge pull request #31471 from peppy/beatmap-carousel-v2
Add basic framework for carousel displays (aka `BeatmapCarouselV2`)
2025-01-16 12:21:53 +01:00
Dan Balasescu
8400726887
Move bindables to OsuConfigManager & SessionStatics 2025-01-16 19:33:42 +09:00
Dean Herbert
e47244989a
Adjust animations a bit
Removed autosize duration stuff because it looks weird when the list is
shown from scratch where users are already fully populated in it.
2025-01-16 19:23:54 +09:00
Dean Herbert
32906aefde
Add gradient on final spectator if more than list capacity are displayed 2025-01-16 19:05:19 +09:00
Dean Herbert
996798d2df
Avoid list width changing when spectator count changes 2025-01-16 19:02:14 +09:00
Dean Herbert
56dfe4a231
Adjust test to work better when running in sequence 2025-01-16 18:56:21 +09:00
Dean Herbert
cde8e7b82e
Fix idle/hover colour handling weirdness in OsuHoverContainer 2025-01-16 18:54:51 +09:00
Dean Herbert
1d240eb405
Fix gameplay limitations for adjusting offset not actually being applied 2025-01-16 18:05:59 +09:00
Dean Herbert
a4174a3644
Add failing test coverage showing offset adjust is not limited correctly 2025-01-16 18:05:58 +09:00
Dan Balasescu
c1f0c47586
Allow setting of DummyAPIAccess status 2025-01-16 17:06:54 +09:00
Dan Balasescu
b54d959263
Expose as IBindable from IAPIProvider, writes via config 2025-01-16 17:05:18 +09:00
Dan Balasescu
471180d947
Merge pull request #31519 from EVAST9919/trail-rotate
Add support for `CursorTrailRotate` skin command
2025-01-16 14:56:53 +09:00
Dan Balasescu
fe8389bc2b
Add test 2025-01-16 14:11:21 +09:00