1
0
mirror of https://github.com/ppy/osu.git synced 2025-01-14 03:25:11 +08:00
osu-lazer/osu.Game/Rulesets
Bartłomiej Dach d07530b241
Mark "Score V2" mod as not user-playable
The mod generally will only be present on scores imported from stable.
As such, it's probably ok to mark it as such.

The primary reason for this change is to address #24436 (Score V2 being
visible on beatmap overlay leaderboard mod selector).

There is one possibly-unintended consequence of this change, namely that
the results screen uses `UserPlayable` to determine as to whether
animations should be played back, with the intention of turning off the
animation playback for autoplay scores specifically. Therefore, turning
off this flag will mean that the results screen animations will not play
out for Score V2 scores - but I tend to consider this as either largely
unimportant, or something that should be fixed in some other way
(possibly by checking against the autoplay mod directly).

Other usages of `UserPlayable` are either innocuous, or straight-up good
safeties going forward in the context of Score V2 (guards against
selection in mod select overlays, against score submission with
the mod).
2023-08-29 11:52:11 +02:00
..
Configuration Remove redundant nullable suppression directives 2023-06-07 08:20:41 +03:00
Difficulty Fix incorrect truncation to int 2023-08-15 00:58:13 +09:00
Edit Move comment to more fitting place 2023-07-28 22:10:10 +02:00
Filter Remove the nullable disable annotation in the Ruleset.Filter namespace. 2022-07-03 21:00:54 +08:00
Judgements Manual fixes to reduce warnings to zero 2023-06-24 01:52:53 +09:00
Mods Mark "Score V2" mod as not user-playable 2023-08-29 11:52:11 +02:00
Objects Merge branch 'master' into judge-fix 2023-08-22 09:44:58 +02:00
Replays Remove the nullable disable annotation in the Rulesets.Replays namespace in the osu.game project. 2022-07-02 13:08:25 +08:00
Scoring Merge branch 'master' into fix-imperfect-simulation 2023-07-13 15:41:54 +09:00
Timing Standardise control point search logic in OverlappingScrollAlgorithm 2022-10-18 16:01:05 +09:00
UI Expose a new SSDQ from playfield for skinnable area bounds 2023-07-28 15:47:57 +09:00
AssemblyRulesetStore.cs Automated #nullable processing 2022-06-17 16:37:17 +09:00
ILegacyRuleset.cs ILegacyScoreProcessor -> ILegacyScoreSimulator 2023-07-04 17:32:54 +09:00
IRulesetConfigCache.cs Automated #nullable processing 2022-06-17 16:37:17 +09:00
IRulesetInfo.cs Automated #nullable processing 2022-06-17 16:37:17 +09:00
IRulesetStore.cs Automated #nullable processing 2022-06-17 16:37:17 +09:00
RealmRulesetStore.cs Remove "internal" identifier as unnecessary 2022-08-29 14:01:15 +09:00
Ruleset.cs Fix "key count" setting showing as "circle size" in osu!mania editor 2023-07-21 18:52:29 +09:00
RulesetConfigCache.cs Partial everything 2022-11-27 00:00:27 +09:00
RulesetInfo.cs Remove usages of [ExcludeFromDynamicCompile] 2023-05-08 18:12:56 +09:00
RulesetLoadException.cs Automated pass 2023-06-24 01:00:03 +09:00
RulesetSelector.cs Use property instead of ctor parameter 2023-01-12 23:26:29 +03:00
RulesetStore.cs Fix a couple of remaining issues 2023-06-24 09:58:36 +09:00