1
0
mirror of https://github.com/ppy/osu.git synced 2024-11-15 16:27:43 +08:00
osu-lazer/osu.Game/Tests/Visual
Bartłomiej Dach 776fabd77c
Only use MD5 when performing metadata lookups
Both online and offline using the cache.

The rationale behind this change is that in the current state of
affairs, `TestPartiallyMaliciousSet()` fails in a way that cannot be
reconciled without this sort of change.

The test exercises a scenario where the beatmap being imported has an
online ID in the `.osu` file, but its hash does not match the online
hash of the beatmap. This turns out to be a more frequent scenario than
envisioned because of users doing stupid things with manual file editing
rather than reporting issues properly.

The scenario is realistic only because the behaviour of the endpoint
responsible for looking up beatmaps is such that if multiple parameters
are given (e.g. all three of beatmap MD5, online ID, and filename), it
will try the three in succession:

	f6b341813b/app/Http/Controllers/BeatmapsController.php (L260-L266)

and the local metadata cache implementation reflected this
implementation.

Because online ID and filename are inherently unreliable in this
scenario due to being directly manipulable by clueless or malicious
users, neither should not be used as a fallback.
2024-10-30 08:12:30 +01:00
..
Gameplay Migrate mod select overlay footer content 2024-06-30 06:50:36 +03:00
Metadata Add failing test 2024-10-11 14:16:24 +02:00
Multiplayer More hardening of TestMultiplayerClient to attempt to fix test failures 2024-08-19 04:04:24 +09:00
OnlinePlay Only use MD5 when performing metadata lookups 2024-10-30 08:12:30 +01:00
Spectator Add test coverage of judgements not being synced when resuming a replay 2024-09-18 15:28:10 +09:00
DependencyProvidingContainer.cs Automated pass 2023-06-24 01:00:03 +09:00
EditorClockTestScene.cs Partial everything 2022-11-27 00:00:27 +09:00
EditorSavingTestScene.cs Add failing test case covering online ID reset on save 2023-05-01 18:17:35 +02:00
EditorTestScene.cs Adjust method naming and copy 2023-01-01 18:50:47 +01:00
LegacySkinPlayerTestScene.cs Rename SkinComponentsContainer to SkinnableContainer 2024-08-22 17:42:50 +09:00
ModFailConditionTestScene.cs Add mania/osu sudden death mod tests 2023-12-22 16:43:09 +09:00
ModTestScene.cs Add failing tests 2023-12-22 13:58:12 +09:00
OsuGameTestScene.cs Add failing tests for beatmap inconsistencies 2024-02-18 19:32:21 +08:00
OsuGridTestScene.cs Automated pass 2023-06-24 01:00:03 +09:00
OsuManualInputManagerTestScene.cs Remove global action container input queue workaround 2023-08-21 17:54:08 +02:00
OsuTestScene.cs Fix tests 2024-07-30 17:08:56 -07:00
PlacementBlueprintTestScene.cs Fix placement blueprints not receiving latest mouse position with touch input 2024-10-13 11:01:18 -04:00
PlayerTestScene.cs Add flag to allow backwards seeks in tests 2024-02-29 23:05:28 +08:00
RateAdjustedBeatmapTestScene.cs Add failing test coverage of skip no longer working in replay playback 2023-02-10 18:57:04 +09:00
ScreenTestScene.cs Add screen footer to ScreenTestScene 2024-07-11 15:30:07 +03:00
ScrollingTestContainer.cs Allow toggling SVs in the editor 2023-08-18 18:55:24 +09:00
SelectionBlueprintTestScene.cs Partial everything 2022-11-27 00:00:27 +09:00
SkinnableTestScene.cs Update R# + fix inspections 2024-02-02 21:00:28 +09:00
TestPlayer.cs Show selected submission failure messages even in solo 2024-02-15 10:55:08 +01:00
TestReplayPlayer.cs Automated pass 2023-06-24 01:00:03 +09:00
TestUserLookupCache.cs Apply NRT in MemoryCachingComponent test-only subclasses 2023-06-09 13:48:42 +02:00