mirror of
https://github.com/ppy/osu.git
synced 2024-09-22 02:07:34 +08:00
9e5b6b97ff
Fixes issue described in the following comment: https://github.com/ppy/osu/pull/25759#issuecomment-1855954637 That is just not how the tooltip system is supposed to be used. To name the individual sins: - Caching and returning a tooltip instance like the classes that used tooltips is incorrect. The lifetime of tooltip instances is managed by the tooltip container. `GetCustomTooltip()` is called by it exclusively. It should return a fresh instance every time. - Not putting actual data in `IHasCustomTooltip.TooltipContent` is wrong. - Having `Tooltip.SetContent()` be a no-op is *grossly and flagrantly* wrong. I'm not even sure which particular combination of the above transgressions caused the issue as it presented itself, but at this time I frankly do not care. |
||
|---|---|---|
| .. | ||
| Input | ||
| AddPresetButton.cs | ||
| AddPresetPopover.cs | ||
| AdjustedAttributesTooltip.cs | ||
| BeatmapAttributesDisplay.cs | ||
| DeleteModPresetDialog.cs | ||
| DeselectAllModsButton.cs | ||
| EditPresetPopover.cs | ||
| IncompatibilityDisplayingModPanel.cs | ||
| IncompatibilityDisplayingTooltip.cs | ||
| ModButtonTooltip.cs | ||
| ModColumn.cs | ||
| ModFooterInformationDisplay.cs | ||
| ModPanel.cs | ||
| ModPresetColumn.cs | ||
| ModPresetPanel.cs | ||
| ModPresetRow.cs | ||
| ModPresetTooltip.cs | ||
| ModSearchContainer.cs | ||
| ModSelectColumn.cs | ||
| ModSelectOverlay.cs | ||
| ModSelectPanel.cs | ||
| ModSettingsArea.cs | ||
| ModState.cs | ||
| ScoreMultiplierDisplay.cs | ||
| SelectAllModsButton.cs | ||
| ShearedOverlayContainer.cs | ||
| UserModSelectOverlay.cs | ||
| VerticalAttributeDisplay.cs | ||