1
0
mirror of https://github.com/ppy/osu.git synced 2025-01-31 12:13:00 +08:00
osu-lazer/osu.Game/Screens
Bartłomiej Dach 81f54507dd
Fix potential index accounting mistake when creating spectator list with spectators already present
Noticed by accident, but if the `BindCollectionChanged()` callback fires
immediately in `LoadComplete()` when set up and there are spectators
present already, then `NewStartingIndex` in the related event is -1:

	b03f83de36/src/libraries/System.ObjectModel/src/System/Collections/Specialized/NotifyCollectionChangedEventArgs.cs (L84-L92)

which kinda breaks the math introducing off-by-ones and in result causes
11 items to be displayed together rather than 10.
2025-01-16 14:29:41 +01:00
..
Backgrounds Remove unused method 2024-12-31 14:02:07 +01:00
Edit Merge pull request #31473 from bdach/colorhax 2025-01-14 20:52:15 +09:00
Footer Explicitly define Hue rather than implicitly provide it by enum value 2024-07-18 00:26:24 +03:00
Import Redesign directory & file selector (and update usages accordingly) 2024-09-24 14:54:48 +02:00
Menu Merge pull request #31418 from peppy/intro-file-integrity 2025-01-07 08:14:40 +01:00
OnlinePlay Fix star range display looking a bit bad when changing opacity 2025-01-07 16:42:06 +09:00
Play Fix potential index accounting mistake when creating spectator list with spectators already present 2025-01-16 14:29:41 +01:00
Ranking Update game ScrollContainer usage in line with framework changes 2025-01-11 01:42:59 +09:00
Select Update game ScrollContainer usage in line with framework changes 2025-01-11 01:42:59 +09:00
SelectV2 Move animation handling to Carousel implementation to better handle add/removes 2025-01-15 17:01:07 +09:00
Spectate Remove managed clocks from SpectatorSyncManager on gameplay completion / abort 2024-04-26 15:29:59 +08:00
Utility Adjust calls to GetContainingInputManager() 2024-06-18 07:41:19 +02:00
BackgroundScreen.cs Remove requirement of specifying animateOnnter in BackgroundScreen ctor 2024-08-07 19:07:44 +09:00
BackgroundScreenStack.cs Remove requirement of specifying animateOnnter in BackgroundScreen ctor 2024-08-07 19:07:44 +09:00
IHandlePresentBeatmap.cs Automated pass 2023-06-24 01:00:03 +09:00
IHasSubScreenStack.cs Automated pass 2023-06-24 01:00:03 +09:00
IOsuScreen.cs Fix comment 2024-11-27 06:07:10 -05:00
IPerformFromScreenRunner.cs Automated #nullable processing 2022-06-17 16:37:17 +09:00
Loader.cs Fix test faiulres when seasonal set to true due to non-circles intro 2024-12-20 16:02:43 +09:00
OsuScreen.cs Rename AllowBackButton to AllowUserExit and rewrite visibility flow structure 2024-11-26 16:52:39 -05:00
OsuScreenDependencies.cs Automated #nullable processing 2022-06-17 16:37:17 +09:00
OsuScreenStack.cs Move screen footer to OsuGame 2024-05-16 07:48:58 +03:00
ScorePresentType.cs Remove redundant nullable suppression directives 2023-06-07 08:20:41 +03:00
ScreenWhiteBox.cs Partial everything 2022-11-27 00:00:27 +09:00
StartupScreen.cs Rename AllowBackButton to AllowUserExit and rewrite visibility flow structure 2024-11-26 16:52:39 -05:00