Joseph Madamba 556be552c3 Fix song select dropdowns not being navigable with keyboard (#37158) ...

- Closes https://github.com/ppy/osu/issues/31684

Uses the global action variant of up and down for dropdown menus. It is
already used in multiplayer/playlist room/beatmap navigation and
gameplay menu overlays.

Comment wording is derived from:

https://github.com/ppy/osu/blob/fc817627e56b7db1c46e2f00fc9a3bd14af51211/osu.Game/Graphics/UserInterface/FocusedTextBox.cs#L73-L74

556be552c3 · 2026-04-01 20:59:47 +09:00

History

..

PageSelector

Automated pass

2023-06-24 01:00:03 +09:00

BackButton.cs

Tidy up ScreenFooter and back button action flow

2025-05-15 18:37:42 +09:00

Bar.cs

Automated pass

2023-06-24 01:00:03 +09:00

BarGraph.cs

Adjust with framework changes

2023-12-04 08:51:21 +09:00

BasicSearchTextBox.cs

Automated pass

2023-06-24 01:00:03 +09:00

BreadcrumbControl.cs

Update R# + fix inspections

2024-02-02 21:00:28 +09:00

CommaSeparatedScoreCounter.cs

Automated pass

2023-06-24 01:00:03 +09:00

DangerousRoundedButton.cs

Reduce abstractions of rounded button

2025-11-25 00:55:42 +09:00

DialogButton.cs

Change global shear definition to be a Vector2

2025-04-16 18:01:08 +09:00

DownloadButton.cs

Partial everything

2022-11-27 00:00:27 +09:00

DrawableOsuMenuItem.cs

Do not add checkbox padding to the left of menu items if no item actually needs it

2024-10-03 15:36:53 +02:00

DrawableStatefulMenuItem.cs

Keep any stateful dropdown menu open on click (#37021)

2026-03-21 22:18:02 +09:00

ExpandableSlider.cs

Use new sliders-with-text-input in editor toolboxes

2025-11-19 13:22:20 +01:00

ExpandingBar.cs

Automated pass

2023-06-24 01:00:03 +09:00

ExternalLinkButton.cs

Rename localised string to something slightly more correct

2025-03-18 00:12:13 +09:00

FocusedTextBox.cs

Adjust calls to GetContainingInputManager()

2024-06-18 07:41:19 +02:00

FPSCounter.cs

feat: added whitespace between "fps"/"ms" and it's value to prevent clipping

2026-01-06 13:10:34 +01:00

FPSCounterTooltip.cs

feat: added whitespaces between "fps"/"ms" and it's value in FPSCounterTooltip.cs

2026-01-06 13:37:10 +01:00

GradientLineTabControl.cs

Partial everything

2022-11-27 00:00:27 +09:00

GrayButton.cs

Partial everything

2022-11-27 00:00:27 +09:00

HistoryTextBox.cs

Fix default volume control keys not working when chat textbox is focused

2023-01-03 09:44:35 +08:00

Hotkey.cs

Tooling updates (#37031)

2026-03-19 00:05:52 +09:00

HotkeyDisplay.cs

Implement component for displaying hotkeys

2024-09-04 11:57:09 +02:00

HoverClickSounds.cs

Fix missed using statement

2026-03-09 08:22:16 +09:00

HoverSampleDebounceComponent.cs

Use equals instead and update other usage

2023-02-04 19:58:48 -08:00

HoverSampleSet.cs

Improve menu/context-menu sample playback

2024-11-29 06:54:48 +09:00

HoverSounds.cs

Update a few sample playback usages to use new helper method

2026-03-07 23:39:20 +09:00

IconButton.cs

Automated pass

2023-06-24 01:00:03 +09:00

LineGraph.cs

Partial everything

2022-11-27 00:00:27 +09:00

LoadingButton.cs

Automated pass

2023-06-24 01:00:03 +09:00

LoadingLayer.cs

Add ability for LoadingLayer to block all keyboard input

2026-02-18 20:01:38 +09:00

LoadingSpinner.cs

Fix LoadingLayer centering

2026-03-07 02:51:50 +09:00

MenuItemType.cs

Remove redundant nullable suppression directives

2023-06-07 08:20:41 +03:00

Nub.cs

Allow specifying a custom width for nubs in OsuCheckboxes

2023-07-14 14:24:55 +09:00

OsuAnimatedButton.cs

Remove unnecessary and incorrect colour application

2026-01-09 16:27:33 +09:00

OsuButton.cs

Revert moving hover sounds to content container

2023-02-02 23:43:08 -08:00

OsuCheckbox.cs

Fix checkboxes applying extra padding

2024-05-18 11:06:29 +03:00

OsuContextMenu.cs

Refactor OsuContextMenu to avoid code duplication

2025-02-05 16:34:15 +09:00

OsuDropdown.cs

Fix song select dropdowns not being navigable with keyboard (#37158)

2026-04-01 20:59:47 +09:00

OsuEnumDropdown.cs

Automated pass

2023-06-24 01:00:03 +09:00

OsuMenu.cs

Refactor OsuContextMenu to avoid code duplication

2025-02-05 16:34:15 +09:00

OsuMenuItem.cs

Add icon specification to OsuMenuItem

2025-05-23 15:46:52 +09:00

OsuMenuItemSpacer.cs

Allow context menus to have visible spacers

2023-11-21 14:24:10 +09:00

OsuMenuSamples.cs

Improve menu/context-menu sample playback

2024-11-29 06:54:48 +09:00

OsuNumberBox.cs

Merge branch 'text-input-properties' into scroll-container-double-precision

2025-01-14 09:51:48 +01:00

OsuPasswordTextBox.cs

Update textbox usage in line with framework changes

2025-01-14 16:29:56 +09:00

OsuSliderBar.cs

Make setter protected to fix build error

2025-12-23 06:31:26 -05:00

OsuTabControl.cs

Revert "Temporary rollback of framework / SDL3"

2024-05-22 16:29:39 +08:00

OsuTabControlCheckbox.cs

Fix incorrect initial state of checkbox

2023-05-03 09:27:23 +02:00

OsuTabDropdown.cs

Remove margin completely

2024-07-18 19:01:52 +09:00

OsuTextBox.cs

Fix some text boxes no longer having borders (#36526)

2026-01-29 19:11:10 +09:00

PageTabControl.cs

Revert "Temporary rollback of framework / SDL3"

2024-05-22 16:29:39 +08:00

PercentageCounter.cs

Change rolling counters to use quicker easing types

2024-01-17 18:18:53 +09:00

ProgressBar.cs

Debounce continuous track seeks to at most one every 500ms

2025-11-20 12:23:31 +01:00

RangeSlider.cs

Disallow focus on difficulty range slider

2025-02-14 00:03:30 +09:00

RollingCounter.cs

Change rolling counters to use quicker easing types

2024-01-17 18:18:53 +09:00

RoundedSliderBar.cs

Fix double-clicking difficulty adjust sliders not resetting the value to default correctly

2025-02-25 07:40:55 +01:00

ScoreCounter.cs

Reduce allocation overhead in ScoreCounter

2024-01-24 23:45:07 +03:00

SearchTextBox.cs

Fix pressing Enter on song select with IME active advancing to gameplay instead of confirming choice (#35619)

2025-11-06 16:06:52 +09:00

SectionHeader.cs

Switch online play screens to new header (#37074)

2026-03-25 16:36:18 +09:00

SeekLimitedSearchTextBox.cs

Automated pass

2023-06-24 01:00:03 +09:00

SegmentedGraph.cs

Adjust with framework changes

2023-12-04 08:51:21 +09:00

SelectionState.cs

Remove redundant nullable suppression directives

2023-06-07 08:20:41 +03:00

ShearedButton.cs

Refactor ShearedButton to allow easier relative sizing (#36802)

2026-03-06 02:09:05 +09:00

ShearedFilterTextBox.cs

Update filter control's status text with beatmap displayed count

2025-05-09 15:05:41 +09:00

ShearedNub.cs

Fix ShearedSliderBar left/right boxes not resized correctly

2025-04-18 07:36:55 -04:00

ShearedOverlayHeader.cs

Partial everything

2022-11-27 00:00:27 +09:00

ShearedRangeSlider.cs

Add localisation support to difficulty range slider

2025-06-14 15:05:05 +03:00

ShearedSearchTextBox.cs

Add ShearedSearchTextBox variant with "N matches" note

2025-04-30 17:42:09 +09:00

ShearedSliderBar.cs

Fix masking bleed

2025-04-30 16:00:00 +09:00

ShearedToggleButton.cs

Refactor ShearedButton to allow easier relative sizing (#36802)

2026-03-06 02:09:05 +09:00

ShowMoreButton.cs

Partial everything

2022-11-27 00:00:27 +09:00

SlimEnumDropdown.cs

Automated pass

2023-06-24 01:00:03 +09:00

StarCounter.cs

Fix star counter decrease animation being delayed when current is over displayed star count

2024-02-16 22:47:38 -08:00

StatefulMenuItem.cs

Add support for localisation where it was missing

2023-01-15 01:46:11 +03:00

TernaryState.cs

Remove redundant nullable suppression directives

2023-06-07 08:20:41 +03:00

TernaryStateMenuItem.cs

Make TernaryStateRadioMenuItem localisable

2024-10-11 18:48:04 -07:00

TernaryStateRadioMenuItem.cs

Make TernaryStateRadioMenuItem localisable

2024-10-11 18:48:04 -07:00

TernaryStateToggleMenuItem.cs

Automated #nullable processing

2022-06-17 16:37:17 +09:00

TimeSlider.cs

Automated pass

2023-06-24 01:00:03 +09:00

ToggleMenuItem.cs

Add support for localisation where it was missing

2023-01-15 01:46:11 +03:00

TwoLayerButton.cs

Remove all song select v1 files

2026-03-03 16:45:14 +09:00