1
0
mirror of https://github.com/ppy/osu.git synced 2024-11-13 16:13:34 +08:00
osu-lazer/osu.Game/Screens/OnlinePlay
Bartłomiej Dach 0d2a47167c
Fix crash on calculating playlist duration when rate-changing mods are present
Regressed in https://github.com/ppy/osu/pull/28399.

To reproduce, enter a playlist that has an item with a rate-changing mod
(rather than create it yourself).

This is happening because `APIRuleset` has `CreateInstance()`
unimplemented:

    b4cefe0cc2/osu.Game/Online/API/Requests/Responses/APIBeatmap.cs (L159)

and only triggers when the playlist items in question originate from
web.

This is why it is bad to have interface implementations throw outside of
maybe mock implementations for tests. `CreateInstance()` is a scourge
elsewhere in general, we need way less of it in the codebase (because
while convenient, it's also problematic to implement in online contexts,
and also expensive because reflection).
2024-06-25 11:28:10 +02:00
..
Components Fix crash on calculating playlist duration when rate-changing mods are present 2024-06-25 11:28:10 +02:00
DailyChallenge Record on single line 2024-06-17 19:16:23 +08:00
Lounge Adjust calls to GetContainingInputManager() 2024-06-18 07:41:19 +02:00
Match Use room mod select overlay rely on explicit binding rather than DI resolution 2024-06-10 12:45:51 +02:00
Multiplayer Update naming of enum fields in StartMode 2024-05-01 17:22:42 +03:00
Playlists Fix crash on calculating playlist duration when rate-changing mods are present 2024-06-25 11:28:10 +02:00
DrawableRoomPlaylist.cs Allow interacting with playlist item buttons when not selected 2024-01-09 14:45:21 +09:00
DrawableRoomPlaylistItem.cs Fix mod display not being aligned with mapper text 2024-05-27 13:36:44 +02:00
FooterButtonFreeMods.cs Fix variable clash 2023-10-06 21:01:23 +09:00
FreeModSelectOverlay.cs Do not show mod effects on free mod select 2023-09-11 09:55:45 +02:00
Header.cs Adjust online play header to be reusable for new daily challenge screen 2024-06-10 12:43:58 +02:00
IOnlinePlaySubScreen.cs Automated pass 2023-06-24 01:00:03 +09:00
IRoomManager.cs Automated #nullable processing 2022-06-17 16:37:17 +09:00
OngoingOperationTracker.cs Partial everything 2022-11-27 00:00:27 +09:00
OnlinePlayComposite.cs Add start date to Room 2024-06-12 11:43:18 +02:00
OnlinePlayScreen.cs Extract OnlinePlayScreenWaveContainer from OnlinePlayScreen 2024-06-10 12:42:37 +02:00
OnlinePlayScreenWaveContainer.cs Extract OnlinePlayScreenWaveContainer from OnlinePlayScreen 2024-06-10 12:42:37 +02:00
OnlinePlaySongSelect.cs Move screen footer to OsuGame 2024-05-16 07:48:58 +03:00
OnlinePlaySubScreen.cs Remove a couple more overrides 2024-01-22 17:00:35 +09:00
OnlinePlaySubScreenStack.cs Manual fixes to reduce warnings to zero 2023-06-24 01:52:53 +09:00