1
0
mirror of https://github.com/ppy/osu.git synced 2025-03-02 00:13:09 +08:00
osu-lazer/osu.Game/Screens
Bartłomiej Dach 6a6db5a22b
Populate metadata from ID3 tags when changing beatmap audio track in editor
- Closes https://github.com/ppy/osu/issues/21189
- Supersedes / closes https://github.com/ppy/osu-framework/pull/5627
- Supersedes / closes https://github.com/ppy/osu/pull/22235

The reason why I opted for a complete rewrite rather than a revival of
that aforementioned pull series is that it always felt quite gross to me
to be pulling framework's audio subsystem into the task of reading ID3
tags, and I also partially don't believe that BASS is *good* at reading
ID3 tags. Meanwhile, we already have another library pulled in that is
*explicitly* intended for reading multimedia metadata, and using it
does not require framework changes. (And it was pulled in explicitly for
use in the editor verify tab as well.)

The hard and dumb part of this diff is hacking the gibson such that
the metadata section on setup screen actually *updates itself*
after the resources section is done doing its thing. After significant
gnashing of teeth I just did the bare minimum to make work by caching
a common parent and exposing an `Action?` on it. If anyone has better
ideas, I'm all ears.
2024-12-27 15:16:03 +01:00
..
Backgrounds Remove requirement of specifying animateOnnter in BackgroundScreen ctor 2024-08-07 19:07:44 +09:00
Edit Populate metadata from ID3 tags when changing beatmap audio track in editor 2024-12-27 15:16:03 +01:00
Footer Explicitly define Hue rather than implicitly provide it by enum value 2024-07-18 00:26:24 +03:00
Import Redesign directory & file selector (and update usages accordingly) 2024-09-24 14:54:48 +02:00
Menu Merge pull request #31259 from peppy/intro-volume-adjust 2024-12-24 10:18:10 +01:00
OnlinePlay Fix null inspections on GameplayChatDisplay 2024-12-17 19:10:09 +09:00
Play Merge branch 'master' into skinnable-mod-display 2024-12-20 21:27:31 +09:00
Ranking Reword comment to hopefully be more understandable 2024-12-13 20:02:17 +09:00
Select Merge pull request #31138 from bdach/mark-as-played 2024-12-24 21:43:15 +09:00
SelectV2 Move BeatmapInfoWedgeV2 to correct namespace 2024-12-12 12:53:05 +09:00
Spectate Remove managed clocks from SpectatorSyncManager on gameplay completion / abort 2024-04-26 15:29:59 +08:00
Utility Adjust calls to GetContainingInputManager() 2024-06-18 07:41:19 +02:00
BackgroundScreen.cs Remove requirement of specifying animateOnnter in BackgroundScreen ctor 2024-08-07 19:07:44 +09:00
BackgroundScreenStack.cs Remove requirement of specifying animateOnnter in BackgroundScreen ctor 2024-08-07 19:07:44 +09:00
IHandlePresentBeatmap.cs Automated pass 2023-06-24 01:00:03 +09:00
IHasSubScreenStack.cs Automated pass 2023-06-24 01:00:03 +09:00
IOsuScreen.cs Fix comment 2024-11-27 06:07:10 -05:00
IPerformFromScreenRunner.cs Automated #nullable processing 2022-06-17 16:37:17 +09:00
Loader.cs Fix test faiulres when seasonal set to true due to non-circles intro 2024-12-20 16:02:43 +09:00
OsuScreen.cs Rename AllowBackButton to AllowUserExit and rewrite visibility flow structure 2024-11-26 16:52:39 -05:00
OsuScreenDependencies.cs Automated #nullable processing 2022-06-17 16:37:17 +09:00
OsuScreenStack.cs Move screen footer to OsuGame 2024-05-16 07:48:58 +03:00
ScorePresentType.cs Remove redundant nullable suppression directives 2023-06-07 08:20:41 +03:00
ScreenWhiteBox.cs Partial everything 2022-11-27 00:00:27 +09:00
StartupScreen.cs Rename AllowBackButton to AllowUserExit and rewrite visibility flow structure 2024-11-26 16:52:39 -05:00