Bartłomiej Dach 2c39e1e9db Ensure submission progress sample is stopped when transitioning into a final state ...

Probably closes https://github.com/ppy/osu/issues/35138. I'm not sure. I
only got the issue to reproduce once, on dev, using a very large
archive that was uploading really slowly, and then never again.

The working theory is that basically handling of `progressSampleChannel`
is quite dodgy and it could possibly, in circumstances unknown, be
allowed to play forevermore after transitioning to failed / canceled
state. Success state does not get this treatment because it has special
logic to set progress to 1.

2c39e1e9db · 2025-09-29 15:30:45 +02:00

History

..

TestSceneBeatDivisorControl.cs

Prevent custom divisor ranges from halting preset cycling

2024-01-24 18:31:39 -05:00

TestSceneBeatmapSubmissionOverlay.cs

Fix missing cached settings in BetamapSubmissionOverlay test

2025-02-07 17:50:32 +09:00

TestSceneBlueprintOrdering.cs

Automated pass

2023-06-24 01:00:03 +09:00

TestSceneColoursSection.cs

Add failing test

2024-10-04 10:00:37 +02:00

TestSceneComposerSelection.cs

Fix up test

2025-06-09 09:16:19 +02:00

TestSceneComposeScreen.cs

Partial everything

2022-11-27 00:00:27 +09:00

TestSceneComposeSelectBox.cs

Assert default origin not null in rotation handle

2024-09-23 11:37:42 +02:00

TestSceneDesignSection.cs

Merge branch 'master' into beatmap-info-purge

2024-11-22 18:47:32 +09:00

TestSceneDifficultyDelete.cs

Decouple editor main menu items from DrawableOsuMenuItem

2024-09-04 12:16:52 +02:00

TestSceneDifficultySwitching.cs

Add failing test case

2024-07-04 14:06:18 +03:00

TestSceneDistanceSnapGrid.cs

Fix code quality

2025-02-03 15:18:03 +01:00

TestSceneEditorBeatmapCreation.cs

Ensure editor is loaded in more places

2025-06-16 16:29:10 +09:00

TestSceneEditorBindings.cs

Partial everything

2022-11-27 00:00:27 +09:00

TestSceneEditorChangeStates.cs

Fix test failures due to automatic break generation kicking in

2024-06-19 11:32:08 +02:00

TestSceneEditorClipboard.cs

Adjust tests to worked with snapped start time

2025-01-20 01:38:18 +01:00

TestSceneEditorClipboardSnapping.cs

Apply NRT to new class

2025-01-22 18:36:13 +09:00

TestSceneEditorClock.cs

Merge branch 'master' into time-accurate

2024-07-08 14:19:57 +02:00

TestSceneEditorComposeRadioButtons.cs

Automated pass

2023-06-24 01:00:03 +09:00

TestSceneEditorMenuBar.cs

Allow context menus to have visible spacers

2023-11-21 14:24:10 +09:00

TestSceneEditorSamplePlayback.cs

Avoid large sample depool overhead on drawable hitobjects with many nested objects

2025-03-26 18:45:12 +09:00

TestSceneEditorSaving.cs

Update existing tests to work with Song Select v2

2025-07-01 17:25:38 +09:00

TestSceneEditorScreenModes.cs

Automated pass

2023-06-24 01:00:03 +09:00

TestSceneEditorSeeking.cs

Add test coverage for seeking between objects in editor

2024-09-13 11:40:01 +02:00

TestSceneEditorSeekSnapping.cs

Partial everything

2022-11-27 00:00:27 +09:00

TestSceneEditorSummaryTimeline.cs

Move bookmarks out of BeatmapInfo

2024-12-03 14:17:14 +01:00

TestSceneEditorTestGameplay.cs

Merge branch 'master' into editor-storyboard-display-2

2025-01-08 15:46:08 +01:00

TestSceneHitObjectComposer.cs

Merge branch 'master' into beatmap-info-purge

2024-11-22 18:47:32 +09:00

TestSceneHitObjectDifficultyPointAdjustments.cs

Rename SliderVelocity to SliderVelocityMultiplier to distinguish from Velocity

2023-09-06 19:01:08 +09:00

TestSceneHitObjectSampleAdjustments.cs

Remove leftover [Solo] attribute

2024-11-26 12:40:49 +01:00

TestSceneLabelledTimeSignature.cs

Cast remaining test usages to IFocusManager to remove obsolete notice

2024-05-22 21:55:53 +08:00

TestSceneLocallyModifyingOnlineBeatmaps.cs

Do not reset online info on beatmap save

2025-01-31 12:21:42 +01:00

TestSceneMetadataSection.cs

Change editor to save metadata changes without explicit textbox commit

2025-04-03 15:31:24 +09:00

TestSceneOpenEditorTimestamp.cs

Update existing tests to work with Song Select v2

2025-07-01 17:25:38 +09:00

TestScenePlacementBlueprint.cs

Add failing test cases that came up in review

2025-03-12 16:52:35 +09:00

TestScenePlaybackControl.cs

Partial everything

2022-11-27 00:00:27 +09:00

TestScenePositionSnapGrid.cs

Merge branch 'master' into grids-2

2024-07-03 10:57:05 +02:00

TestScenePreviewTime.cs

Fix test regression

2024-07-12 16:29:41 +09:00

TestSceneSelectionBlueprintDeselection.cs

Partial everything

2022-11-27 00:00:27 +09:00

TestSceneSetupScreen.cs

Automated pass

2023-06-24 01:00:03 +09:00

TestSceneSubmissionStageProgress.cs

Ensure submission progress sample is stopped when transitioning into a final state

2025-09-29 15:30:45 +02:00

TestSceneTapButton.cs

Partial everything

2022-11-27 00:00:27 +09:00

TestSceneTapTimingControl.cs

Partial everything

2022-11-27 00:00:27 +09:00

TestSceneTimelineBlueprintContainer.cs

Automated pass

2023-06-24 01:00:03 +09:00

TestSceneTimelineHitObjectBlueprint.cs

Automated pass

2023-06-24 01:00:03 +09:00

TestSceneTimelineSelection.cs

Remove unused using directive

2024-07-03 07:11:35 +03:00

TestSceneTimelineTickDisplay.cs

Change BeatDivisorControl to retrive bindable divisor via DI

2023-07-14 14:03:25 +09:00

TestSceneTimelineZoom.cs

Automated pass

2023-06-24 01:00:03 +09:00

TestSceneTimingScreen.cs

Fix adjusting control point offset after undo/redo causing catastrophic failure

2024-12-13 19:33:51 +09:00

TestSceneWaveform.cs

Partial everything

2022-11-27 00:00:27 +09:00

TestSceneZoomableScrollContainer.cs

Update failing assertions

2025-03-03 13:53:42 +01:00

TimelineTestScene.cs

Revert "Add PopoverContainer to TimelineTestScene"

2023-06-01 18:48:12 +02:00