1
0
mirror of https://github.com/ppy/osu.git synced 2026-05-18 11:20:24 +08:00
Files
osu-lazer/osu.Game.Tests/Visual/Editing
T
Bartłomiej Dach 16bc1de9fd Allow changing addition bank button state when objects are selected even if the selection has no addition sounds (#36808)
Before:


https://github.com/user-attachments/assets/d87bd7e3-37f8-4634-9e6a-5859d5bade57

After:


https://github.com/user-attachments/assets/4de940af-1e30-4266-9aac-5ccd12f38742

---

The title is convoluted but basically I'm angling to close
https://github.com/ppy/osu/issues/36705 with this.

The point is that on current `master`, the keyboard-hotkey-based toggles
on the left of the screen get disabled if you select a range of objects
which contains no addition samples. The report linked above finds this
annoying because it means you basically always need to add an addition
sound *first* and *then* pick a bank.

This is not necessary, and this commit changes the behaviour such that
the bank selection toggles are no longer blocked when you select a range
of objects without additions. Choosing an addition bank when there are
no additions still does nothing to the selected object, *but* adding a
sound *after* that bank preselection will use the preselected bank
rather than auto.
16bc1de9fd · 2026-03-07 00:47:35 +09:00
History
..
2023-06-24 01:00:03 +09:00
2024-10-04 10:00:37 +02:00
2025-06-09 09:16:19 +02:00
2022-11-27 00:00:27 +09:00
2025-02-03 15:18:03 +01:00
2022-11-27 00:00:27 +09:00
2023-06-24 01:00:03 +09:00
2022-11-27 00:00:27 +09:00
2024-07-12 16:29:41 +09:00
2023-06-24 01:00:03 +09:00
2022-11-27 00:00:27 +09:00
2023-06-24 01:00:03 +09:00
2022-11-27 00:00:27 +09:00