mirror of
https://github.com/ppy/osu.git
synced 2024-12-17 03:55:30 +08:00
20b1d76269
Closes https://github.com/ppy/osu/issues/29793. I believe that the sequence of events that makes this happens is as follows: - User selects a range of objects. Some of those objects are off-screen, and thus would be presumed to be not alive - except the blueprint container forces them to remain alive, because they're part of the selection. - User moves the selection to another column, which is implemented by temporarily removing the objects from the playfield, changing their column, and re-adding them. This sort of pattern is supposed to kick off the `HitObjectUsageTransferred` flow in `HitObjectUsageEventBuffer` - and it does... for objects that are *currently visible on screen* and thus would be alive regardless of `SetKeepAlive()`. However, this does not hold for objects that are off-screen - nothing ensures they are kept alive again after re-adding, and thus they inadvertently become dead. - Thus, this doesn't kick off the `BlueprintContainer` flows associated with transferring objects to another column, and instead fires the removal flows, which ensure that the off-screen objects that were being moved are instead deselected. I tried a few other options but found no better resolution than this - calling `SetKeepAlive()` directly would require making it public, which seems like a bad idea. There's really no good way to generically handle this either, because it is the ruleset that decides that its way of implementing this operation will be a removal and re-add of objects, so... |
||
|---|---|---|
| .. | ||
| Blueprints | ||
| Checks | ||
| Setup | ||
| DrawableManiaEditorRuleset.cs | ||
| HoldNoteCompositionTool.cs | ||
| ManiaBeatmapVerifier.cs | ||
| ManiaBeatSnapGrid.cs | ||
| ManiaBlueprintContainer.cs | ||
| ManiaEditorPlayfield.cs | ||
| ManiaHitObjectComposer.cs | ||
| ManiaSelectionHandler.cs | ||
| NoteCompositionTool.cs | ||