1
0
mirror of https://github.com/ppy/osu.git synced 2025-01-15 18:13:00 +08:00
osu-lazer/osu.Game/Rulesets
Bartłomiej Dach 13c81db0cf Fix incorrect classic score formula
Upon closer inspection the classic score formula was subtly wrong. The
version given in the wiki is:

	Score = Hit Value + (Hit Value * ((Combo multiplier * Difficulty
	multiplier * Mod multiplier) / 25))

The code previously used:

	bonusScore + baseScore * ((1 + Math.Max(0, HighestCombo.Value - 1)
	* scoreMultiplier) / 25);

which is not equivalent to the version on the wiki. The error is in the 1
factor, as in the above version it is being divided by 25, while it should
be outside the division to keep parity with the previous formula.

The tests attached in the previous commit demonstrate that this change
causes a single hit without combo to increase total score by its exact
numeric value.
2020-04-14 01:09:58 +02:00
..
Configuration Constrain configuration lookup as enum. 2019-12-09 17:45:26 +08:00
Difficulty CA2208: create exceptions correctly. 2019-12-17 13:00:10 +08:00
Edit Cleanup handling of hitobject updates 2020-04-09 20:16:44 +09:00
Judgements Move judgement colours to OsuColour 2020-03-18 17:21:36 +09:00
Mods Merge branch 'master' into show-mod-settings-tooltip 2020-03-29 14:35:04 +09:00
Objects Fix nested hitobjects potentially indirectly masked away 2020-04-11 16:53:45 +09:00
Replays Rename conversion methods for clarity 2020-03-25 20:21:34 +09:00
Scoring Fix incorrect classic score formula 2020-04-14 01:09:58 +02:00
Timing Centralise default beat length specification 2019-08-28 20:22:16 +09:00
UI Fix merge mishap 2020-04-03 23:31:46 +09:00
ILegacyRuleset.cs Remove LegacyID from Ruleset 2019-12-24 13:48:27 +09:00
Ruleset.cs Rework lookups to not require total playfield columns 2020-04-03 12:31:05 +09:00
RulesetConfigCache.cs Suppress warnings 2019-11-12 13:41:54 +09:00
RulesetInfo.cs Simplify RulesetInfo string presentation 2020-02-18 01:17:12 +03:00
RulesetSelector.cs General refactoring 2019-06-26 17:52:25 +09:00
RulesetStore.cs remove from rulesetinfo 2020-01-03 13:08:01 +00:00